You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/08/28 16:44:07 UTC
[GitHub] [incubator-devlake] likyh opened a new pull request, #2862: Refactor/refactor for dynamic connection
likyh opened a new pull request, #2862:
URL: https://github.com/apache/incubator-devlake/pull/2862
### ⚠️ Pre Checklist
> Please complete _ALL_ items in this checklist, and remove before submitting
- [ ] I have read through the [Contributing](https://devlake.apache.org/community/) Documentation & [PR Template](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
- [ ] This PR is using a `label` (bug, feature etc.)
- [ ] My code is has necessary documentation (if appropriate)
- [ ] I have added any relevant tests
- [ ] This section (**⚠️ Pre Checklist**) will be removed when submitting PR
# Summary
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes.
Please fill out as many sections below as possible.
-->
### Does this close any open issues?
Please mention the issues here.
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on pull request #2862: Refactor/refactor for dynamic connection
Posted by GitBox <gi...@apache.org>.
likyh commented on PR #2862:
URL: https://github.com/apache/incubator-devlake/pull/2862#issuecomment-1231676529
> @likyh @klesh I have a different plan for setting up dynamic plugins that I am drafting, I don't agree with much of the changes on this PR. Please invest time in feature tickets and stop refactoring UI.
Please support my idea. Or tell me why don't agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on pull request #2862: Refactor/refactor for dynamic connection
Posted by GitBox <gi...@apache.org>.
e2corporation commented on PR #2862:
URL: https://github.com/apache/incubator-devlake/pull/2862#issuecomment-1231649994
@likyh @klesh Some of the intended goals on this ticket will be addressed and adapted for use with #2882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on pull request #2862: Refactor/refactor for dynamic connection
Posted by GitBox <gi...@apache.org>.
e2corporation commented on PR #2862:
URL: https://github.com/apache/incubator-devlake/pull/2862#issuecomment-1231709274
> > @likyh @klesh I have a different plan for setting up dynamic plugins that I am drafting, I don't agree with much of the changes on this PR. Please invest time in feature tickets and stop refactoring UI.
>
> Please support my idea. Or tell me why don't agree. @e2corporation
@likyh As lead maintainer on UI I have more time invested in the frontend codebase, I have a certain idea of how the configuration system should evolve. Instead of the Product Owner creating a detailed ticket on the needs of "Dynamic" Plugins etc., you are taking it upon yourself without any discussion with me at all to refactor code that has hours of time in development and testing applied to it. This is not proper team co-ordination, and as you continue to run this nature of a refactor we have new features to add to this sprint and I need the UI system to be in a known state. All this time could have been invested in the other feature ticket I opened for Gitlab Proxy. It's not that I don't support your idea, but it has to be inline with my strategy. I already mentioned some of the goals you have on this PR will be accomplished on the other ticket and you will have the opportunity to continue development work there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on pull request #2862: Refactor/refactor for dynamic connection
Posted by GitBox <gi...@apache.org>.
e2corporation commented on PR #2862:
URL: https://github.com/apache/incubator-devlake/pull/2862#issuecomment-1231596651
@likyh @klesh I have a different plan for setting up dynamic plugins that I am drafting, I don't agree with much of the changes on this PR. Please invest time in feature tickets and stop refactoring UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh closed pull request #2862: Refactor/refactor for dynamic connection
Posted by GitBox <gi...@apache.org>.
likyh closed pull request #2862: Refactor/refactor for dynamic connection
URL: https://github.com/apache/incubator-devlake/pull/2862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org