You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/02/07 20:41:00 UTC

[jira] [Commented] (AIRFLOW-3826) Integrate SageMaker operators and sensors per 1 file

    [ https://issues.apache.org/jira/browse/AIRFLOW-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763062#comment-16763062 ] 

ASF GitHub Bot commented on AIRFLOW-3826:
-----------------------------------------

mik-laj commented on pull request #4667: [AIRFLOW-3826] Group SageMaker sensors and operators per file
URL: https://github.com/apache/airflow/pull/4667
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3826
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   This is the second attempt to clean up in Airflow.  The first attempt was made by @kaxil, but was postponed until the release of Airflow 2.0. @kaxil  solution was not backward compatible.
   See: #3000 
   
   My solution is backwards compatible. The user can use old and new paths at the same time.
   In the future, support for old paths may be abandoned.
   
   This is not the last version of the patch. This fix requires UPDATING.md to be completed, but I would like to hear your feedback.
   
   It is worth mentioning that IDE have support for notifications for the developer. The message will not be displayed only at runtime, but also when writing.
   
   ![screenshot 2019-02-07 at 21 36 22](https://user-images.githubusercontent.com/12058428/52441460-e906de00-2b20-11e9-816e-23b070ce1af7.png)
   
   CC: @criccomini, @fenglu-g, @ashb 
   
   ### Tests
   
   No applicable
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   Documentation updated
   
   ### Code Quality
   
   - [X] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Integrate SageMaker operators and sensors per 1 file
> ----------------------------------------------------
>
>                 Key: AIRFLOW-3826
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3826
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Kamil Bregula
>            Priority: Major
>
> There are currently 7 operators:
>  * SageMakerBaseOperator
>  * SageMakerEndpointConfigOperator
>  * SageMakerEndpointOperator
>  * SageMakerModelOperator
>  * SageMakerTrainingOperator
>  * SageMakerTransformOperator
>  * SageMakerTuningOperator
> and 5 operators
>  * SageMakerBaseSensor
>  * SageMakerEndpointSensor
>  * SageMakerTrainingSensor
>  * SageMakerTransformSensor
>  * SageMakerTuningSensor
> It would be ideal to have 2 file sagemaker_operator.py and sagemaker_sensors.py similar to *gcp_spanner_operator.py* containing all the operators related to Google Cloud Spanner.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)