[jira] [Commented] (OPENNLP-912) Add a rule based sentence detector

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513425#comment-17513425 ] 

ASF GitHub Bot commented on OPENNLP-912:
----------------------------------------

jzonthemtn commented on a change in pull request #390:
URL: https://github.com/apache/opennlp/pull/390#discussion_r836497822



##########
File path: opennlp-tools/src/main/java/opennlp/tools/sentdetect/segment/SentenceTokenizer.java
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package opennlp.tools.sentdetect.segment;
+
+import java.util.List;
+
+/**
+ * The interface for rule based sentence detector
+ */
+public interface SentenceTokenizer {

Review comment:
       There is an `opennlp.tools.sentdetect.SentenceDetector` interface that resembles this interface. Since the purpose of the two interfaces seem the same (to break text into sentences), is it possible to reuse the other interface?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add a rule based sentence detector
> ----------------------------------
>
>                 Key: OPENNLP-912
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-912
>             Project: OpenNLP
>          Issue Type: Improvement
>            Reporter: Jörn Kottmann
>            Priority: Major
>              Labels: help-wanted
>
> It would be nice to offer a simpler rule based sentence detector, in some languages this might work rather well.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)