[GitHub] [drill] vvysotskyi commented on a change in pull request #1932: DRILL-7485: NPE on PCAP Batch Reader

[GitBox <gi...@apache.org>]

vvysotskyi commented on a change in pull request #1932: DRILL-7485: NPE on PCAP Batch Reader
URL: https://github.com/apache/drill/pull/1932#discussion_r357700882
 
 

 ##########
 File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/pcap/TestPcapEVFReader.java
 ##########
 @@ -99,4 +99,10 @@ public void testAggregateQuery() throws Exception {
       .baselineValues(true, 16L)
       .go();
   }
+
+  @Test
+  public void testArpPcapFile() throws Exception {
+    String sql = "SELECT type AS packet_type FROM cp.`store/pcap/test2.pcap`";
+    queryBuilder().sql(sql).run();
 
 Review comment:
   Please validate the query results. Also, the filename may be more descriptive to help further contributors to reuse it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services