[GitHub] Ngone51 commented on a change in pull request #23871: [SPARK-23433][SPARK-25250] [CORE] Later created TaskSet should learn about the finished partitions

[GitBox <gi...@apache.org>]

Ngone51 commented on a change in pull request #23871: [SPARK-23433][SPARK-25250] [CORE] Later created TaskSet should learn about the finished partitions 
URL: https://github.com/apache/spark/pull/23871#discussion_r261468249
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
 ##########
 @@ -530,7 +530,7 @@ private[spark] class TaskSetManager(
 
   private def maybeFinishTaskSet() {
     if (isZombie && runningTasks == 0) {
-      sched.taskSetFinished(this)
+      sched.taskSetFinished(this, tasksSuccessful == numTasks)
 
 Review comment:
   I think I made a mistake here. Previously I was thinking a zombie TSM must have at least one failed tasks, so tasksSuccessful can't be equal to numTasks. But now I realize that `markPartitionCompleted` could increase `tasksSuccessful` even if it's an already failed task for that zombie TSM. So, it still be possible for a zombie TSM to achieve  `tasksSuccessful == numTasks`. @cloud-fan 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org