You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/09/20 11:18:22 UTC
[GitHub] [cassandra] ifesdjeen opened a new pull request #754: 16102 followup
ifesdjeen opened a new pull request #754:
URL: https://github.com/apache/cassandra/pull/754
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] dcapwell commented on a change in pull request #754: 16102 followup
Posted by GitBox <gi...@apache.org>.
dcapwell commented on a change in pull request #754:
URL: https://github.com/apache/cassandra/pull/754#discussion_r492220016
##########
File path: src/java/org/apache/cassandra/config/YamlConfigurationLoader.java
##########
@@ -119,7 +119,8 @@ public Config loadConfig(URL url) throws ConfigurationException
throw new AssertionError(e);
}
- Constructor constructor = new CustomConstructor(Config.class);
+
+ Constructor constructor = new CustomConstructor(Config.class, Yaml.class.getClassLoader());
Review comment:
Feel we should use `CustomConstructor.class.getClassLoader()` or `Thread.currentThread().getContextClassLoader()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic closed pull request #754: 16102 followup
Posted by GitBox <gi...@apache.org>.
smiklosovic closed pull request #754:
URL: https://github.com/apache/cassandra/pull/754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] dcapwell commented on a change in pull request #754: 16102 followup
Posted by GitBox <gi...@apache.org>.
dcapwell commented on a change in pull request #754:
URL: https://github.com/apache/cassandra/pull/754#discussion_r492220016
##########
File path: src/java/org/apache/cassandra/config/YamlConfigurationLoader.java
##########
@@ -119,7 +119,8 @@ public Config loadConfig(URL url) throws ConfigurationException
throw new AssertionError(e);
}
- Constructor constructor = new CustomConstructor(Config.class);
+
+ Constructor constructor = new CustomConstructor(Config.class, Yaml.class.getClassLoader());
Review comment:
Feel we should use `CustomConstructor.class.getClassLoader()` or `Thread.currentThread().getContextClassLoader()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org