You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by xunzhang <gi...@git.apache.org> on 2016/10/09 12:38:39 UTC
[GitHub] incubator-hawq pull request #954: HAWQ-1091. Fix HAWQ InputFormat Bugs.
GitHub user xunzhang opened a pull request:
https://github.com/apache/incubator-hawq/pull/954
HAWQ-1091. Fix HAWQ InputFormat Bugs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xunzhang/incubator-hawq HAWQ-1091
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/954.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #954
----
commit 5b03771e8d7ce647312a09caa780fab505c89b22
Author: xunzhang <xu...@gmail.com>
Date: 2016-10-09T12:35:31Z
HAWQ-1091. Fix HAWQ InputFormat Bugs.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #954: HAWQ-1091. Fix HAWQ InputFormat Bugs.
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the issue:
https://github.com/apache/incubator-hawq/pull/954
Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #954: HAWQ-1091. Fix HAWQ InputFormat Bugs.
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang closed the pull request at:
https://github.com/apache/incubator-hawq/pull/954
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #954: HAWQ-1091. Fix HAWQ InputFormat Bugs.
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the issue:
https://github.com/apache/incubator-hawq/pull/954
cc @ictmalili @wcl14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #954: [WIP] HAWQ-1091. Fix HAWQ InputFormat Bugs...
Posted by ictmalili <gi...@git.apache.org>.
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/954#discussion_r82523067
--- Diff: contrib/hawq-hadoop/hawq-mapreduce-common/src/main/java/com/pivotal/hawq/mapreduce/metadata/MetadataYAMLAccessor.java ---
@@ -198,6 +201,9 @@ private HAWQParquetTableMetadata extractParquetMetadata(HAWQDatabaseMetadata dbM
Map<?, ?> file = (Map<?, ?>) files.get(i);
final String filePath = file.get("path").toString();
final long fileLen = Long.parseLong(file.get("size").toString());
+ if (fileLen == 0) {
+ throw new IllegalStateException("Could not new HAWQParquetFileStatus with a empty file.");
+ }
--- End diff --
Could we change the error message to a more meaningful description. For example, "Empty file $filePath, can not be processed by HAWQParquetInputFormat"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---