You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by gi...@git.apache.org on 2017/08/05 02:02:33 UTC

[GitHub] merlimat commented on a change in pull request #641: Added missing copyright notice for Circe library

merlimat commented on a change in pull request #641: Added missing copyright notice for Circe library
URL: https://github.com/apache/incubator-pulsar/pull/641#discussion_r131512100
 
 

 ##########
 File path: NOTICE
 ##########
 @@ -4,3 +4,8 @@ Copyright 2017 The Apache Software Foundation
 
 This product includes software developed at
 The Apache Software Foundation (http://www.apache.org/).
+
+----------------------------------------------------------------------------------------------------
+
+Circe CRC library
 
 Review comment:
   Yes, and that is the reason why we don't mention it in the `LICENSE` file. The question here is whether we should mention the copyright or not. There are 2 different opinions in the replies on the voting thread, since the Circe repo doesn't include a `NOTICE` file. https://lists.apache.org/thread.html/c79ae36fdc1f734337a4f706117be87f4c4c568f87605c59ff4c3a96@%3Cgeneral.incubator.apache.org%3E
   
   My guess is that adding the copyright would not do harm here.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services