You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/08/15 04:53:52 UTC
[Bug 120575] New: optimize a comparing operation from 'memcmp' to
'hash compare' to improve xls loading performance
https://issues.apache.org/ooo/show_bug.cgi?id=120575
Priority: P3
Bug ID: 120575
Assignee: ooo-issues@incubator.apache.org
Summary: optimize a comparing operation from 'memcmp' to 'hash
compare' to improve xls loading performance
Severity: normal
Issue Type: DEFECT
Classification: Code
OS: All
Reporter: lizh.fee@gmail.com
Hardware: All
Status: UNCONFIRMED
Version: AOO 3.4.0
Component: www
Product: performance
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120575] optimize a comparing operation from 'memcmp' to 'hash
compare' to improve xls loading performance
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120575
Wang Lei <le...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|www |code
Target Milestone|not determined |AOO 3.5.0
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120575] optimize a comparing operation from 'memcmp' to 'hash
compare' to improve xls loading performance
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120575
--- Comment #4 from lizh.fee@gmail.com ---
following is test result for sample file (manual test), about 10% improvement.
old: 4.31 4.38 4.37 4.44 4.31 4.34 4.41 4.40 4.47 4.50 avg:4.40
new: 3.90 3.93 3.78 3.75 3.75 3.85 3.84 3.87 4.00 4.00 avg:3.87
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120575] optimize a comparing operation from 'memcmp' to 'hash
compare' to improve xls loading performance
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120575
--- Comment #2 from lizh.fee@gmail.com ---
Root cause:
in xls loading procedure, ScPatternAttr::operator== occupies too much time, in
this function, two sfxitemset are compared by memcmp(...), this is a time
consuming operation.
Resolution:
Instead of memcmp(...), two sfxitemset can be compared 'quickly' by the hashkey
only. And a function SfxItemSet::QuickCompare( SfxItemSet & rCmp) instead of
EqualPatternSets(...).
Test result:
In ScPatternAttr::operator==, SfxItemSet::QuickCompare( SfxItemSet & rCmp) will
be called 3141717 times, including 3114837 times only comparing hash key and
directly return, memcmp(...). will be called 26880 times.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120575] optimize a comparing operation from 'memcmp' to 'hash
compare' to improve xls loading performance
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120575
Wang Lei <le...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
CC| |leiw@apache.org
Resolution|--- |FIXED
--- Comment #6 from Wang Lei <le...@apache.org> ---
Submit in revision 1384677, thanks for your patch
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120575] optimize a comparing operation from 'memcmp' to 'hash
compare' to improve xls loading performance
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120575
--- Comment #5 from SVN Robot <sv...@dev.null.org> ---
"leiw" committed SVN revision 1384677 into trunk:
#i120575 optimize a comparing operation from 'memcmp' to 'hash compare' to
im...
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120575] optimize a comparing operation from 'memcmp' to 'hash
compare' to improve xls loading performance
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120575
lizh.fee@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79115| |review?
Flags| |
--- Comment #1 from lizh.fee@gmail.com ---
Created attachment 79115
--> https://issues.apache.org/ooo/attachment.cgi?id=79115&action=edit
patch for improving xls loading performance
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120575] optimize a comparing operation from 'memcmp' to 'hash
compare' to improve xls loading performance
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120575
--- Comment #3 from lizh.fee@gmail.com ---
Created attachment 79117
--> https://issues.apache.org/ooo/attachment.cgi?id=79117&action=edit
sample
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120575] optimize a comparing operation from 'memcmp' to 'hash
compare' to improve xls loading performance
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120575
lizh.fee@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Issue Type|DEFECT |ENHANCEMENT
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120575] [From Symphony] optimize a comparing operation from
'memcmp' to 'hash compare' to improve xls loading performance
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120575
Shenfeng Liu <li...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |liushenf@gmail.com
Summary|optimize a comparing |[From Symphony] optimize a
|operation from 'memcmp' to |comparing operation from
|'hash compare' to improve |'memcmp' to 'hash compare'
|xls loading performance |to improve xls loading
| |performance
--
You are receiving this mail because:
You are the assignee for the bug.