You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/04/13 15:55:49 UTC

[GitHub] [geode] dschneider-pivotal commented on a diff in pull request #7585: GEODE-10235: fix --maxHeap for java 17

dschneider-pivotal commented on code in PR #7585:
URL: https://github.com/apache/geode/pull/7585#discussion_r849647859


##########
geode-gfsh/src/integrationTest/java/org/apache/geode/management/internal/cli/commands/StartMemberUtilsTest.java:
##########
@@ -172,9 +177,14 @@ public void testAddMaxHeap() {
 
     // Only Max Heap Option Set
     StartMemberUtils.addMaxHeap(baseCommandLine, "32g");
-    assertThat(baseCommandLine.size()).isEqualTo(3);
-    assertThat(baseCommandLine).containsExactly("-Xmx32g", "-XX:+UseConcMarkSweepGC",
-        "-XX:CMSInitiatingOccupancyFraction=" + StartMemberUtils.CMS_INITIAL_OCCUPANCY_FRACTION);
+    if (getJavaMajorVersion() < 14) {
+      assertThat(baseCommandLine.size()).isEqualTo(3);

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org