[GitHub] [shardingsphere] sandynz commented on pull request #14625: Enable inner classes unit test for maven surefire plugin and ignore failed test cases for now

[GitBox <gi...@apache.org>]

sandynz commented on pull request #14625:
URL: https://github.com/apache/shardingsphere/pull/14625#issuecomment-1008218735


   `CosIdIntervalShardingAlgorithmTest` is ignored in `mvn install` by default (refer to [surefire#excludes]( https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#excludes ) for more details).
   
   After I enabled inner classes unit test and did a simple fixing, `CosIdIntervalShardingAlgorithmTest` still has failed cases in GitHub CI, more than I found on local test, refer to https://github.com/apache/shardingsphere/runs/4748280776?check_suite_focus=true for more details.
   
   I've reverted `Collections.singleton` replacement and marked related test classes as `@Ignored` for now.
   
   @Ahoo-Wang , could you help to fix these failed test cases of `CosIdIntervalShardingAlgorithmTest`? Thanks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org