[GitHub] [arrow-datafusion] waynexia commented on a diff in pull request #7455: minor: do not fail analyzer if subquery plan contains extension

["waynexia (via GitHub)" <gi...@apache.org>]

waynexia commented on code in PR #7455:
URL: https://github.com/apache/arrow-datafusion/pull/7455#discussion_r1316851165


##########
datafusion/optimizer/src/analyzer/subquery.rs:
##########
@@ -338,3 +339,57 @@ fn check_mixed_out_refer_in_window(window: &Window) -> Result<()> {
         Ok(())
     }
 }
+
+#[cfg(test)]

Review Comment:
   Great suggestion. I plan to cover this case in `datafusion/core/tests/user_defined/user_defined_plan.rs`. But since the previous TopK is based on optimizer, I may need to add another extension plan and an analyzer rule.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org