You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ted Zlatanov (JIRA)" <ji...@apache.org> on 2010/02/25 17:26:27 UTC
[jira] Created: (CASSANDRA-835) ThriftGlue should have KeyRange,
Mutation, and Deletion creation helper methods to make life easier for
users
ThriftGlue should have KeyRange, Mutation, and Deletion creation helper methods to make life easier for users
-------------------------------------------------------------------------------------------------------------
Key: CASSANDRA-835
URL: https://issues.apache.org/jira/browse/CASSANDRA-835
Project: Cassandra
Issue Type: New Feature
Components: Core
Reporter: Ted Zlatanov
Priority: Minor
ThriftGlue doesn't have any helper methods for KeyRange, Mutation, and Deletion. Those should be provided since we can expect API users to need them.
I propose:
Mutation createMutation(Deletion d)
Mutation createMutation(Column c)
Mutation createMutation(SuperColumn c)
Deletion createDeletion(byte[] supercolumnName)
Deletion createDeletion(SlicePredicate predicate)
KeyRange createKeyRange_Key(String startKey, String endKey)
KeyRange createKeyRange_Token(String startToken, String endToken)
I don't know if it's useful to mix keys and tokens in the key range.
The patch is trivial so let me know if I should put it together.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-835) ThriftGlue should have KeyRange,
Mutation, and Deletion creation helper methods to make life easier for
users
Posted by "Ted Zlatanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841318#action_12841318 ]
Ted Zlatanov commented on CASSANDRA-835:
----------------------------------------
Actually with the new chained Thrift methods this is not an issue and ThriftGlue can be obsoleted, as for example in CassandraServer:
KeyRange range = new KeyRange().setStart_key(start_key).setEnd_key(finish_key).setCount(maxRows);
So as far as I'm concerned this is not an issue.
> ThriftGlue should have KeyRange, Mutation, and Deletion creation helper methods to make life easier for users
> -------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-835
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Ted Zlatanov
> Priority: Minor
> Attachments: 0001-CASSANDRA-835.patch
>
>
> ThriftGlue doesn't have any helper methods for KeyRange, Mutation, and Deletion. Those should be provided since we can expect API users to need them.
> I propose:
> Mutation createMutation(Deletion d)
> Mutation createMutation(Column c)
> Mutation createMutation(SuperColumn c)
> Deletion createDeletion(byte[] supercolumnName)
> Deletion createDeletion(SlicePredicate predicate)
> KeyRange createKeyRange_Key(String startKey, String endKey)
> KeyRange createKeyRange_Token(String startToken, String endToken)
> I don't know if it's useful to mix keys and tokens in the key range.
> The patch is trivial so let me know if I should put it together.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-835) ThriftGlue should have KeyRange,
Mutation, and Deletion creation helper methods to make life easier for
users
Posted by "Ted Zlatanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Zlatanov updated CASSANDRA-835:
-----------------------------------
Attachment: 0001-CASSANDRA-835.patch
> ThriftGlue should have KeyRange, Mutation, and Deletion creation helper methods to make life easier for users
> -------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-835
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Ted Zlatanov
> Priority: Minor
> Attachments: 0001-CASSANDRA-835.patch
>
>
> ThriftGlue doesn't have any helper methods for KeyRange, Mutation, and Deletion. Those should be provided since we can expect API users to need them.
> I propose:
> Mutation createMutation(Deletion d)
> Mutation createMutation(Column c)
> Mutation createMutation(SuperColumn c)
> Deletion createDeletion(byte[] supercolumnName)
> Deletion createDeletion(SlicePredicate predicate)
> KeyRange createKeyRange_Key(String startKey, String endKey)
> KeyRange createKeyRange_Token(String startToken, String endToken)
> I don't know if it's useful to mix keys and tokens in the key range.
> The patch is trivial so let me know if I should put it together.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-835) ThriftGlue should have KeyRange,
Mutation, and Deletion creation helper methods to make life easier for
users
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841040#action_12841040 ]
Jonathan Ellis commented on CASSANDRA-835:
------------------------------------------
This would be more interesting if it refactored existing code to use the new methods.
> ThriftGlue should have KeyRange, Mutation, and Deletion creation helper methods to make life easier for users
> -------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-835
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Ted Zlatanov
> Priority: Minor
> Attachments: 0001-CASSANDRA-835.patch
>
>
> ThriftGlue doesn't have any helper methods for KeyRange, Mutation, and Deletion. Those should be provided since we can expect API users to need them.
> I propose:
> Mutation createMutation(Deletion d)
> Mutation createMutation(Column c)
> Mutation createMutation(SuperColumn c)
> Deletion createDeletion(byte[] supercolumnName)
> Deletion createDeletion(SlicePredicate predicate)
> KeyRange createKeyRange_Key(String startKey, String endKey)
> KeyRange createKeyRange_Token(String startToken, String endToken)
> I don't know if it's useful to mix keys and tokens in the key range.
> The patch is trivial so let me know if I should put it together.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-835) ThriftGlue should have KeyRange,
Mutation, and Deletion creation helper methods to make life easier for
users
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841337#action_12841337 ]
Jonathan Ellis commented on CASSANDRA-835:
------------------------------------------
Give it a shot
> ThriftGlue should have KeyRange, Mutation, and Deletion creation helper methods to make life easier for users
> -------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-835
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Ted Zlatanov
> Priority: Minor
> Attachments: 0001-CASSANDRA-835.patch
>
>
> ThriftGlue doesn't have any helper methods for KeyRange, Mutation, and Deletion. Those should be provided since we can expect API users to need them.
> I propose:
> Mutation createMutation(Deletion d)
> Mutation createMutation(Column c)
> Mutation createMutation(SuperColumn c)
> Deletion createDeletion(byte[] supercolumnName)
> Deletion createDeletion(SlicePredicate predicate)
> KeyRange createKeyRange_Key(String startKey, String endKey)
> KeyRange createKeyRange_Token(String startToken, String endToken)
> I don't know if it's useful to mix keys and tokens in the key range.
> The patch is trivial so let me know if I should put it together.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-835) ThriftGlue should have KeyRange,
Mutation, and Deletion creation helper methods to make life easier for
users
Posted by "Ted Zlatanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841324#action_12841324 ]
Ted Zlatanov commented on CASSANDRA-835:
----------------------------------------
Do you want me to refactor ThriftGlue (since I dragged it in) out of existence or is that not a priority?
> ThriftGlue should have KeyRange, Mutation, and Deletion creation helper methods to make life easier for users
> -------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-835
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Ted Zlatanov
> Priority: Minor
> Attachments: 0001-CASSANDRA-835.patch
>
>
> ThriftGlue doesn't have any helper methods for KeyRange, Mutation, and Deletion. Those should be provided since we can expect API users to need them.
> I propose:
> Mutation createMutation(Deletion d)
> Mutation createMutation(Column c)
> Mutation createMutation(SuperColumn c)
> Deletion createDeletion(byte[] supercolumnName)
> Deletion createDeletion(SlicePredicate predicate)
> KeyRange createKeyRange_Key(String startKey, String endKey)
> KeyRange createKeyRange_Token(String startToken, String endToken)
> I don't know if it's useful to mix keys and tokens in the key range.
> The patch is trivial so let me know if I should put it together.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CASSANDRA-835) ThriftGlue should have
KeyRange, Mutation, and Deletion creation helper methods to make life
easier for users
Posted by "Ted Zlatanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841318#action_12841318 ]
Ted Zlatanov edited comment on CASSANDRA-835 at 3/4/10 3:07 PM:
----------------------------------------------------------------
Actually with the new chained Thrift methods ThriftGlue can be obsoleted, as for example in CassandraServer:
KeyRange range = new KeyRange().setStart_key(start_key).setEnd_key(finish_key).setCount(maxRows);
So as far as I'm concerned this is not an issue.
was (Author: tzz):
Actually with the new chained Thrift methods this is not an issue and ThriftGlue can be obsoleted, as for example in CassandraServer:
KeyRange range = new KeyRange().setStart_key(start_key).setEnd_key(finish_key).setCount(maxRows);
So as far as I'm concerned this is not an issue.
> ThriftGlue should have KeyRange, Mutation, and Deletion creation helper methods to make life easier for users
> -------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-835
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Ted Zlatanov
> Priority: Minor
> Attachments: 0001-CASSANDRA-835.patch
>
>
> ThriftGlue doesn't have any helper methods for KeyRange, Mutation, and Deletion. Those should be provided since we can expect API users to need them.
> I propose:
> Mutation createMutation(Deletion d)
> Mutation createMutation(Column c)
> Mutation createMutation(SuperColumn c)
> Deletion createDeletion(byte[] supercolumnName)
> Deletion createDeletion(SlicePredicate predicate)
> KeyRange createKeyRange_Key(String startKey, String endKey)
> KeyRange createKeyRange_Token(String startToken, String endToken)
> I don't know if it's useful to mix keys and tokens in the key range.
> The patch is trivial so let me know if I should put it together.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-835) ThriftGlue should have KeyRange,
Mutation, and Deletion creation helper methods to make life easier for
users
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841294#action_12841294 ]
Jonathan Ellis commented on CASSANDRA-835:
------------------------------------------
We don't commit code on the basis that it might be useful.
ThriftGlue is for internal use, if you want to make things easier for Java clients, you should be working on http://github.com/rantav/hector.
> ThriftGlue should have KeyRange, Mutation, and Deletion creation helper methods to make life easier for users
> -------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-835
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Ted Zlatanov
> Priority: Minor
> Attachments: 0001-CASSANDRA-835.patch
>
>
> ThriftGlue doesn't have any helper methods for KeyRange, Mutation, and Deletion. Those should be provided since we can expect API users to need them.
> I propose:
> Mutation createMutation(Deletion d)
> Mutation createMutation(Column c)
> Mutation createMutation(SuperColumn c)
> Deletion createDeletion(byte[] supercolumnName)
> Deletion createDeletion(SlicePredicate predicate)
> KeyRange createKeyRange_Key(String startKey, String endKey)
> KeyRange createKeyRange_Token(String startToken, String endToken)
> I don't know if it's useful to mix keys and tokens in the key range.
> The patch is trivial so let me know if I should put it together.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-835) ThriftGlue should have KeyRange,
Mutation, and Deletion creation helper methods to make life easier for
users
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-835.
--------------------------------------
Resolution: Not A Problem
ok, closed
> ThriftGlue should have KeyRange, Mutation, and Deletion creation helper methods to make life easier for users
> -------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-835
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Ted Zlatanov
> Priority: Minor
> Attachments: 0001-CASSANDRA-835.patch
>
>
> ThriftGlue doesn't have any helper methods for KeyRange, Mutation, and Deletion. Those should be provided since we can expect API users to need them.
> I propose:
> Mutation createMutation(Deletion d)
> Mutation createMutation(Column c)
> Mutation createMutation(SuperColumn c)
> Deletion createDeletion(byte[] supercolumnName)
> Deletion createDeletion(SlicePredicate predicate)
> KeyRange createKeyRange_Key(String startKey, String endKey)
> KeyRange createKeyRange_Token(String startToken, String endToken)
> I don't know if it's useful to mix keys and tokens in the key range.
> The patch is trivial so let me know if I should put it together.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-835) ThriftGlue should have KeyRange,
Mutation, and Deletion creation helper methods to make life easier for
users
Posted by "Ted Zlatanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841290#action_12841290 ]
Ted Zlatanov commented on CASSANDRA-835:
----------------------------------------
I can do the refactoring as a followup patch if you think it's essential for acceptance. I think as this stands it's already very useful for API users so I'd like to see this go in and then I'll do a followup ticket for the refactoring.
> ThriftGlue should have KeyRange, Mutation, and Deletion creation helper methods to make life easier for users
> -------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-835
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Ted Zlatanov
> Priority: Minor
> Attachments: 0001-CASSANDRA-835.patch
>
>
> ThriftGlue doesn't have any helper methods for KeyRange, Mutation, and Deletion. Those should be provided since we can expect API users to need them.
> I propose:
> Mutation createMutation(Deletion d)
> Mutation createMutation(Column c)
> Mutation createMutation(SuperColumn c)
> Deletion createDeletion(byte[] supercolumnName)
> Deletion createDeletion(SlicePredicate predicate)
> KeyRange createKeyRange_Key(String startKey, String endKey)
> KeyRange createKeyRange_Token(String startToken, String endToken)
> I don't know if it's useful to mix keys and tokens in the key range.
> The patch is trivial so let me know if I should put it together.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.