You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2017/10/02 22:04:20 UTC

[GitHub] spark pull request #18966: [SPARK-21751][SQL] CodeGeneraor.splitExpressions ...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18966#discussion_r142267872
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala ---
    @@ -769,16 +769,27 @@ class CodegenContext {
           foldFunctions: Seq[String] => String = _.mkString("", ";\n", ";")): String = {
         val blocks = new ArrayBuffer[String]()
         val blockBuilder = new StringBuilder()
    +    val defaultMaxLines = 100
    +    val maxLines = if (SparkEnv.get != null) {
    +      SparkEnv.get.conf.getInt("spark.sql.codegen.expressions.maxCodegenLinesPerFunction",
    --- End diff --
    
    Can we use bytecode size?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org