You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Mete Atamel (JIRA)" <ji...@apache.org> on 2012/07/02 12:26:22 UTC
[jira] [Created] (JCR-3369) Garbage collector improvements
Mete Atamel created JCR-3369:
--------------------------------
Summary: Garbage collector improvements
Key: JCR-3369
URL: https://issues.apache.org/jira/browse/JCR-3369
Project: Jackrabbit Content Repository
Issue Type: Improvement
Components: jackrabbit-core
Reporter: Mete Atamel
We identified a number of improvements to garbage collector related code to make it more robust, specifically:
1- As discussed in JCR-3340, when GC goes through nodes, it can encounter a lot of ItemStateExceptions. Currently, stack trace of these exceptions are not logged and this makes debugging difficult. Instead, ItemStateExceptions should at least be logged with full stack trace every 1 minute or so.
2- As discussed in JCR-3341, GC does not fail fast if there is a problem and it should.
3- Session usage in the GC is problematic. The session in GC is used for traversing the content and marking the binaries, but the listener in that class uses the same session as well, when a node is added. GC should rather use a separate session in onEvent() to avoid concurrent use.
4- GC listens for NODE_ADDED event for moved nodes but instead it should listen for NODE_MOVED.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3369) Garbage collector improvements
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Reutegger updated JCR-3369:
----------------------------------
Fix Version/s: 2.2.13
Merged into 2.2 branch in revision: 1356636
> Garbage collector improvements
> ------------------------------
>
> Key: JCR-3369
> URL: https://issues.apache.org/jira/browse/JCR-3369
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Mete Atamel
> Fix For: 2.2.13, 2.5.1
>
> Attachments: JCR-3369-2.2.patch, JCR-3369-trunk.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> We identified a number of improvements to garbage collector related code to make it more robust, specifically:
> 1- As discussed in JCR-3340, when GC goes through nodes, it can encounter a lot of ItemStateExceptions. Currently, stack trace of these exceptions are not logged and this makes debugging difficult. Instead, ItemStateExceptions should at least be logged with full stack trace every 1 minute or so.
> 2- As discussed in JCR-3341, GC does not fail fast if there is a problem and it should.
> 3- Session usage in the GC is problematic. The session in GC is used for traversing the content and marking the binaries, but the listener in that class uses the same session as well, when a node is added. GC should rather use a separate session in onEvent() to avoid concurrent use.
> 4- GC listens for NODE_ADDED event for moved nodes but instead it should listen for NODE_MOVED.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JCR-3369) Garbage collector improvements
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Mueller resolved JCR-3369.
---------------------------------
Resolution: Fixed
> Garbage collector improvements
> ------------------------------
>
> Key: JCR-3369
> URL: https://issues.apache.org/jira/browse/JCR-3369
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Mete Atamel
> Assignee: Thomas Mueller
> Fix For: 2.2.13, 2.4.3, 2.5.1
>
> Attachments: JCR-3369-2.2.patch, JCR-3369-2.4.patch, JCR-3369-trunk.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> We identified a number of improvements to garbage collector related code to make it more robust, specifically:
> 1- As discussed in JCR-3340, when GC goes through nodes, it can encounter a lot of ItemStateExceptions. Currently, stack trace of these exceptions are not logged and this makes debugging difficult. Instead, ItemStateExceptions should at least be logged with full stack trace every 1 minute or so.
> 2- As discussed in JCR-3341, GC does not fail fast if there is a problem and it should.
> 3- Session usage in the GC is problematic. The session in GC is used for traversing the content and marking the binaries, but the listener in that class uses the same session as well, when a node is added. GC should rather use a separate session in onEvent() to avoid concurrent use.
> 4- GC listens for NODE_ADDED event for moved nodes but instead it should listen for NODE_MOVED.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3369) Garbage collector improvements
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Mueller updated JCR-3369:
--------------------------------
Fix Version/s: 2.4.3
> Garbage collector improvements
> ------------------------------
>
> Key: JCR-3369
> URL: https://issues.apache.org/jira/browse/JCR-3369
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Mete Atamel
> Assignee: Thomas Mueller
> Fix For: 2.2.13, 2.4.3, 2.5.1
>
> Attachments: JCR-3369-2.2.patch, JCR-3369-2.4.patch, JCR-3369-trunk.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> We identified a number of improvements to garbage collector related code to make it more robust, specifically:
> 1- As discussed in JCR-3340, when GC goes through nodes, it can encounter a lot of ItemStateExceptions. Currently, stack trace of these exceptions are not logged and this makes debugging difficult. Instead, ItemStateExceptions should at least be logged with full stack trace every 1 minute or so.
> 2- As discussed in JCR-3341, GC does not fail fast if there is a problem and it should.
> 3- Session usage in the GC is problematic. The session in GC is used for traversing the content and marking the binaries, but the listener in that class uses the same session as well, when a node is added. GC should rather use a separate session in onEvent() to avoid concurrent use.
> 4- GC listens for NODE_ADDED event for moved nodes but instead it should listen for NODE_MOVED.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3369) Garbage collector improvements
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405699#comment-13405699 ]
Marcel Reutegger commented on JCR-3369:
---------------------------------------
+1 patch looks good. Applied it in revision: 1356612
> Garbage collector improvements
> ------------------------------
>
> Key: JCR-3369
> URL: https://issues.apache.org/jira/browse/JCR-3369
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Mete Atamel
> Attachments: JCR-3369-2.2.patch, JCR-3369-trunk.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> We identified a number of improvements to garbage collector related code to make it more robust, specifically:
> 1- As discussed in JCR-3340, when GC goes through nodes, it can encounter a lot of ItemStateExceptions. Currently, stack trace of these exceptions are not logged and this makes debugging difficult. Instead, ItemStateExceptions should at least be logged with full stack trace every 1 minute or so.
> 2- As discussed in JCR-3341, GC does not fail fast if there is a problem and it should.
> 3- Session usage in the GC is problematic. The session in GC is used for traversing the content and marking the binaries, but the listener in that class uses the same session as well, when a node is added. GC should rather use a separate session in onEvent() to avoid concurrent use.
> 4- GC listens for NODE_ADDED event for moved nodes but instead it should listen for NODE_MOVED.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3369) Garbage collector improvements
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405029#comment-13405029 ]
Thomas Mueller commented on JCR-3369:
-------------------------------------
The patch look good to me. Except for slightly different line numbers, the patches contain the exact same changes, right?
> Garbage collector improvements
> ------------------------------
>
> Key: JCR-3369
> URL: https://issues.apache.org/jira/browse/JCR-3369
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Mete Atamel
> Attachments: JCR-3369-2.2.patch, JCR-3369-trunk.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> We identified a number of improvements to garbage collector related code to make it more robust, specifically:
> 1- As discussed in JCR-3340, when GC goes through nodes, it can encounter a lot of ItemStateExceptions. Currently, stack trace of these exceptions are not logged and this makes debugging difficult. Instead, ItemStateExceptions should at least be logged with full stack trace every 1 minute or so.
> 2- As discussed in JCR-3341, GC does not fail fast if there is a problem and it should.
> 3- Session usage in the GC is problematic. The session in GC is used for traversing the content and marking the binaries, but the listener in that class uses the same session as well, when a node is added. GC should rather use a separate session in onEvent() to avoid concurrent use.
> 4- GC listens for NODE_ADDED event for moved nodes but instead it should listen for NODE_MOVED.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (JCR-3369) Garbage collector improvements
Posted by "Mete Atamel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mete Atamel reopened JCR-3369:
------------------------------
I'd be good to fix this in JR/2.4 branch as well. Attached the patch against JR/2.4 branch.
> Garbage collector improvements
> ------------------------------
>
> Key: JCR-3369
> URL: https://issues.apache.org/jira/browse/JCR-3369
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Mete Atamel
> Fix For: 2.2.13, 2.5.1
>
> Attachments: JCR-3369-2.2.patch, JCR-3369-2.4.patch, JCR-3369-trunk.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> We identified a number of improvements to garbage collector related code to make it more robust, specifically:
> 1- As discussed in JCR-3340, when GC goes through nodes, it can encounter a lot of ItemStateExceptions. Currently, stack trace of these exceptions are not logged and this makes debugging difficult. Instead, ItemStateExceptions should at least be logged with full stack trace every 1 minute or so.
> 2- As discussed in JCR-3341, GC does not fail fast if there is a problem and it should.
> 3- Session usage in the GC is problematic. The session in GC is used for traversing the content and marking the binaries, but the listener in that class uses the same session as well, when a node is added. GC should rather use a separate session in onEvent() to avoid concurrent use.
> 4- GC listens for NODE_ADDED event for moved nodes but instead it should listen for NODE_MOVED.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3369) Garbage collector improvements
Posted by "Mete Atamel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mete Atamel updated JCR-3369:
-----------------------------
Status: Patch Available (was: Open)
> Garbage collector improvements
> ------------------------------
>
> Key: JCR-3369
> URL: https://issues.apache.org/jira/browse/JCR-3369
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Mete Atamel
> Attachments: JCR-3369-2.2.patch, JCR-3369-trunk.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> We identified a number of improvements to garbage collector related code to make it more robust, specifically:
> 1- As discussed in JCR-3340, when GC goes through nodes, it can encounter a lot of ItemStateExceptions. Currently, stack trace of these exceptions are not logged and this makes debugging difficult. Instead, ItemStateExceptions should at least be logged with full stack trace every 1 minute or so.
> 2- As discussed in JCR-3341, GC does not fail fast if there is a problem and it should.
> 3- Session usage in the GC is problematic. The session in GC is used for traversing the content and marking the binaries, but the listener in that class uses the same session as well, when a node is added. GC should rather use a separate session in onEvent() to avoid concurrent use.
> 4- GC listens for NODE_ADDED event for moved nodes but instead it should listen for NODE_MOVED.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3369) Garbage collector improvements
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425573#comment-13425573 ]
Thomas Mueller commented on JCR-3369:
-------------------------------------
Merged into the 2.4 branch in revision 1367435
> Garbage collector improvements
> ------------------------------
>
> Key: JCR-3369
> URL: https://issues.apache.org/jira/browse/JCR-3369
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Mete Atamel
> Assignee: Thomas Mueller
> Fix For: 2.2.13, 2.4.3, 2.5.1
>
> Attachments: JCR-3369-2.2.patch, JCR-3369-2.4.patch, JCR-3369-trunk.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> We identified a number of improvements to garbage collector related code to make it more robust, specifically:
> 1- As discussed in JCR-3340, when GC goes through nodes, it can encounter a lot of ItemStateExceptions. Currently, stack trace of these exceptions are not logged and this makes debugging difficult. Instead, ItemStateExceptions should at least be logged with full stack trace every 1 minute or so.
> 2- As discussed in JCR-3341, GC does not fail fast if there is a problem and it should.
> 3- Session usage in the GC is problematic. The session in GC is used for traversing the content and marking the binaries, but the listener in that class uses the same session as well, when a node is added. GC should rather use a separate session in onEvent() to avoid concurrent use.
> 4- GC listens for NODE_ADDED event for moved nodes but instead it should listen for NODE_MOVED.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3369) Garbage collector improvements
Posted by "Mete Atamel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405036#comment-13405036 ]
Mete Atamel commented on JCR-3369:
----------------------------------
Yes. I double checked and all files contain exact same changes. There are a few empty lines in GarbageCollector class hence the line number difference but it doesn't matter.
> Garbage collector improvements
> ------------------------------
>
> Key: JCR-3369
> URL: https://issues.apache.org/jira/browse/JCR-3369
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Mete Atamel
> Attachments: JCR-3369-2.2.patch, JCR-3369-trunk.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> We identified a number of improvements to garbage collector related code to make it more robust, specifically:
> 1- As discussed in JCR-3340, when GC goes through nodes, it can encounter a lot of ItemStateExceptions. Currently, stack trace of these exceptions are not logged and this makes debugging difficult. Instead, ItemStateExceptions should at least be logged with full stack trace every 1 minute or so.
> 2- As discussed in JCR-3341, GC does not fail fast if there is a problem and it should.
> 3- Session usage in the GC is problematic. The session in GC is used for traversing the content and marking the binaries, but the listener in that class uses the same session as well, when a node is added. GC should rather use a separate session in onEvent() to avoid concurrent use.
> 4- GC listens for NODE_ADDED event for moved nodes but instead it should listen for NODE_MOVED.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3369) Garbage collector improvements
Posted by "Mete Atamel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mete Atamel updated JCR-3369:
-----------------------------
Attachment: JCR-3369-2.2.patch
JCR-3369-trunk.patch
Patches against trunk and 2.2 branch.
> Garbage collector improvements
> ------------------------------
>
> Key: JCR-3369
> URL: https://issues.apache.org/jira/browse/JCR-3369
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Mete Atamel
> Attachments: JCR-3369-2.2.patch, JCR-3369-trunk.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> We identified a number of improvements to garbage collector related code to make it more robust, specifically:
> 1- As discussed in JCR-3340, when GC goes through nodes, it can encounter a lot of ItemStateExceptions. Currently, stack trace of these exceptions are not logged and this makes debugging difficult. Instead, ItemStateExceptions should at least be logged with full stack trace every 1 minute or so.
> 2- As discussed in JCR-3341, GC does not fail fast if there is a problem and it should.
> 3- Session usage in the GC is problematic. The session in GC is used for traversing the content and marking the binaries, but the listener in that class uses the same session as well, when a node is added. GC should rather use a separate session in onEvent() to avoid concurrent use.
> 4- GC listens for NODE_ADDED event for moved nodes but instead it should listen for NODE_MOVED.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3369) Garbage collector improvements
Posted by "Mete Atamel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mete Atamel updated JCR-3369:
-----------------------------
Attachment: JCR-3369-2.4.patch
Patch against JR/2.4 branch
> Garbage collector improvements
> ------------------------------
>
> Key: JCR-3369
> URL: https://issues.apache.org/jira/browse/JCR-3369
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Mete Atamel
> Fix For: 2.2.13, 2.5.1
>
> Attachments: JCR-3369-2.2.patch, JCR-3369-2.4.patch, JCR-3369-trunk.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> We identified a number of improvements to garbage collector related code to make it more robust, specifically:
> 1- As discussed in JCR-3340, when GC goes through nodes, it can encounter a lot of ItemStateExceptions. Currently, stack trace of these exceptions are not logged and this makes debugging difficult. Instead, ItemStateExceptions should at least be logged with full stack trace every 1 minute or so.
> 2- As discussed in JCR-3341, GC does not fail fast if there is a problem and it should.
> 3- Session usage in the GC is problematic. The session in GC is used for traversing the content and marking the binaries, but the listener in that class uses the same session as well, when a node is added. GC should rather use a separate session in onEvent() to avoid concurrent use.
> 4- GC listens for NODE_ADDED event for moved nodes but instead it should listen for NODE_MOVED.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (JCR-3369) Garbage collector improvements
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Mueller reassigned JCR-3369:
-----------------------------------
Assignee: Thomas Mueller
> Garbage collector improvements
> ------------------------------
>
> Key: JCR-3369
> URL: https://issues.apache.org/jira/browse/JCR-3369
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Mete Atamel
> Assignee: Thomas Mueller
> Fix For: 2.2.13, 2.5.1
>
> Attachments: JCR-3369-2.2.patch, JCR-3369-2.4.patch, JCR-3369-trunk.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> We identified a number of improvements to garbage collector related code to make it more robust, specifically:
> 1- As discussed in JCR-3340, when GC goes through nodes, it can encounter a lot of ItemStateExceptions. Currently, stack trace of these exceptions are not logged and this makes debugging difficult. Instead, ItemStateExceptions should at least be logged with full stack trace every 1 minute or so.
> 2- As discussed in JCR-3341, GC does not fail fast if there is a problem and it should.
> 3- Session usage in the GC is problematic. The session in GC is used for traversing the content and marking the binaries, but the listener in that class uses the same session as well, when a node is added. GC should rather use a separate session in onEvent() to avoid concurrent use.
> 4- GC listens for NODE_ADDED event for moved nodes but instead it should listen for NODE_MOVED.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3369) Garbage collector improvements
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Reutegger updated JCR-3369:
----------------------------------
Resolution: Fixed
Fix Version/s: 2.5.1
Status: Resolved (was: Patch Available)
> Garbage collector improvements
> ------------------------------
>
> Key: JCR-3369
> URL: https://issues.apache.org/jira/browse/JCR-3369
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Mete Atamel
> Fix For: 2.5.1
>
> Attachments: JCR-3369-2.2.patch, JCR-3369-trunk.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> We identified a number of improvements to garbage collector related code to make it more robust, specifically:
> 1- As discussed in JCR-3340, when GC goes through nodes, it can encounter a lot of ItemStateExceptions. Currently, stack trace of these exceptions are not logged and this makes debugging difficult. Instead, ItemStateExceptions should at least be logged with full stack trace every 1 minute or so.
> 2- As discussed in JCR-3341, GC does not fail fast if there is a problem and it should.
> 3- Session usage in the GC is problematic. The session in GC is used for traversing the content and marking the binaries, but the listener in that class uses the same session as well, when a node is added. GC should rather use a separate session in onEvent() to avoid concurrent use.
> 4- GC listens for NODE_ADDED event for moved nodes but instead it should listen for NODE_MOVED.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3369) Garbage collector improvements
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405708#comment-13405708 ]
Marcel Reutegger commented on JCR-3369:
---------------------------------------
One thing I noticed in the logs: the session in GarbageCollector.Listener is not closed.
Fixed in revision: 1356630
> Garbage collector improvements
> ------------------------------
>
> Key: JCR-3369
> URL: https://issues.apache.org/jira/browse/JCR-3369
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Mete Atamel
> Attachments: JCR-3369-2.2.patch, JCR-3369-trunk.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> We identified a number of improvements to garbage collector related code to make it more robust, specifically:
> 1- As discussed in JCR-3340, when GC goes through nodes, it can encounter a lot of ItemStateExceptions. Currently, stack trace of these exceptions are not logged and this makes debugging difficult. Instead, ItemStateExceptions should at least be logged with full stack trace every 1 minute or so.
> 2- As discussed in JCR-3341, GC does not fail fast if there is a problem and it should.
> 3- Session usage in the GC is problematic. The session in GC is used for traversing the content and marking the binaries, but the listener in that class uses the same session as well, when a node is added. GC should rather use a separate session in onEvent() to avoid concurrent use.
> 4- GC listens for NODE_ADDED event for moved nodes but instead it should listen for NODE_MOVED.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira