[GitHub] [samza] mynameborat commented on a change in pull request #1344: SAMZA-2510: Incorrect shutdown status due to race between runloop and process callback thread

[GitBox <gi...@apache.org>]

mynameborat commented on a change in pull request #1344: SAMZA-2510: Incorrect shutdown status due to race between runloop and process callback thread
URL: https://github.com/apache/samza/pull/1344#discussion_r408490572
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/container/RunLoop.java
 ##########
 @@ -185,6 +180,11 @@ public void run() {
           containerMetrics.utilization().set(((double) activeNs) / totalNs);
         }
       }
+
+      if (throwable != null) {
 
 Review comment:
   That is correct. The semantics of manual call to `RunLoop.shutdown` is loosely defined in the sense that we don't wait for things in flight to finish and trigger shutdown as soon as runloop thread sees the request. So this would be in line with that and may or may not propagate the exception. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services