You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Bill Graham (Created) (JIRA)" <ji...@apache.org> on 2012/03/26 06:44:26 UTC
[jira] [Created] (PIG-2616)
JobControlCompiler.getInputSizeFromLoader must handle exceptions from
LoadFunc.getStatistics.
JobControlCompiler.getInputSizeFromLoader must handle exceptions from LoadFunc.getStatistics.
---------------------------------------------------------------------------------------------
Key: PIG-2616
URL: https://issues.apache.org/jira/browse/PIG-2616
Project: Pig
Issue Type: Bug
Reporter: Bill Graham
Assignee: Bill Graham
PIG-2573 made it possible for {{JobControlCompiler}} to get input size from {{LoadFuncs}}, but in some cases (i.e. {{InterStorage}}), {{getStatistics}} throws an exception:
{noformat}
Caused by: java.lang.UnsupportedOperationException
at org.apache.pig.impl.io.InterStorage.getStatistics(InterStorage.java:189)
at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getInputSizeFromLoader(JobControlCompiler.java:839)
at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getInputSize(JobControlCompiler.java:799)
at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.estimateNumberOfReducers(JobControlCompiler.java:777)
at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getJob(JobControlCompiler.java:599)
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2616)
JobControlCompiler.getInputSizeFromLoader must handle exceptions from
LoadFunc.getStatistics.
Posted by "Jonathan Coveney (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Coveney updated PIG-2616:
----------------------------------
Fix Version/s: 0.11
0.10
> JobControlCompiler.getInputSizeFromLoader must handle exceptions from LoadFunc.getStatistics.
> ---------------------------------------------------------------------------------------------
>
> Key: PIG-2616
> URL: https://issues.apache.org/jira/browse/PIG-2616
> Project: Pig
> Issue Type: Bug
> Reporter: Bill Graham
> Assignee: Bill Graham
> Fix For: 0.10, 0.11
>
> Attachments: pig-2616.1.patch, pig-2616.2.patch
>
>
> PIG-2573 made it possible for {{JobControlCompiler}} to get input size from {{LoadFuncs}}, but in some cases (i.e. {{InterStorage}}), {{getStatistics}} throws an exception:
> {noformat}
> Caused by: java.lang.UnsupportedOperationException
> at org.apache.pig.impl.io.InterStorage.getStatistics(InterStorage.java:189)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getInputSizeFromLoader(JobControlCompiler.java:839)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getInputSize(JobControlCompiler.java:799)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.estimateNumberOfReducers(JobControlCompiler.java:777)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getJob(JobControlCompiler.java:599)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2616)
JobControlCompiler.getInputSizeFromLoader must handle exceptions from
LoadFunc.getStatistics.
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-2616:
----------------------------
Fix Version/s: (was: 0.10.0)
0.10.1
> JobControlCompiler.getInputSizeFromLoader must handle exceptions from LoadFunc.getStatistics.
> ---------------------------------------------------------------------------------------------
>
> Key: PIG-2616
> URL: https://issues.apache.org/jira/browse/PIG-2616
> Project: Pig
> Issue Type: Bug
> Reporter: Bill Graham
> Assignee: Bill Graham
> Labels: 0.10_blocker
> Fix For: 0.11, 0.10.1
>
> Attachments: pig-2616.1.patch, pig-2616.2.patch
>
>
> PIG-2573 made it possible for {{JobControlCompiler}} to get input size from {{LoadFuncs}}, but in some cases (i.e. {{InterStorage}}), {{getStatistics}} throws an exception:
> {noformat}
> Caused by: java.lang.UnsupportedOperationException
> at org.apache.pig.impl.io.InterStorage.getStatistics(InterStorage.java:189)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getInputSizeFromLoader(JobControlCompiler.java:839)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getInputSize(JobControlCompiler.java:799)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.estimateNumberOfReducers(JobControlCompiler.java:777)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getJob(JobControlCompiler.java:599)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2616)
JobControlCompiler.getInputSizeFromLoader must handle exceptions from
LoadFunc.getStatistics.
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Graham updated PIG-2616:
-----------------------------
Attachment: PIG-2616.3.patch
PIG-2574 dealt with half of this patch, which is catching the exception. Attaching a new patch which deals with the other half, which is that {{InterStorage.getStatistics(..)}} should return null.
Will commit this shortly.
> JobControlCompiler.getInputSizeFromLoader must handle exceptions from LoadFunc.getStatistics.
> ---------------------------------------------------------------------------------------------
>
> Key: PIG-2616
> URL: https://issues.apache.org/jira/browse/PIG-2616
> Project: Pig
> Issue Type: Bug
> Reporter: Bill Graham
> Assignee: Bill Graham
> Labels: 0.10_blocker
> Fix For: 0.11, 0.10.1
>
> Attachments: PIG-2616.3.patch, pig-2616.1.patch, pig-2616.2.patch
>
>
> PIG-2573 made it possible for {{JobControlCompiler}} to get input size from {{LoadFuncs}}, but in some cases (i.e. {{InterStorage}}), {{getStatistics}} throws an exception:
> {noformat}
> Caused by: java.lang.UnsupportedOperationException
> at org.apache.pig.impl.io.InterStorage.getStatistics(InterStorage.java:189)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getInputSizeFromLoader(JobControlCompiler.java:839)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getInputSize(JobControlCompiler.java:799)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.estimateNumberOfReducers(JobControlCompiler.java:777)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getJob(JobControlCompiler.java:599)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2616)
JobControlCompiler.getInputSizeFromLoader must handle exceptions from
LoadFunc.getStatistics.
Posted by "Daniel Dai (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238195#comment-13238195 ]
Daniel Dai commented on PIG-2616:
---------------------------------
The fix is fine. You can also drop UnsupportedOperationException in InterStorage.
> JobControlCompiler.getInputSizeFromLoader must handle exceptions from LoadFunc.getStatistics.
> ---------------------------------------------------------------------------------------------
>
> Key: PIG-2616
> URL: https://issues.apache.org/jira/browse/PIG-2616
> Project: Pig
> Issue Type: Bug
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: pig-2616.1.patch
>
>
> PIG-2573 made it possible for {{JobControlCompiler}} to get input size from {{LoadFuncs}}, but in some cases (i.e. {{InterStorage}}), {{getStatistics}} throws an exception:
> {noformat}
> Caused by: java.lang.UnsupportedOperationException
> at org.apache.pig.impl.io.InterStorage.getStatistics(InterStorage.java:189)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getInputSizeFromLoader(JobControlCompiler.java:839)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getInputSize(JobControlCompiler.java:799)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.estimateNumberOfReducers(JobControlCompiler.java:777)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getJob(JobControlCompiler.java:599)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIG-2616)
JobControlCompiler.getInputSizeFromLoader must handle exceptions from
LoadFunc.getStatistics.
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Graham resolved PIG-2616.
------------------------------
Resolution: Fixed
> JobControlCompiler.getInputSizeFromLoader must handle exceptions from LoadFunc.getStatistics.
> ---------------------------------------------------------------------------------------------
>
> Key: PIG-2616
> URL: https://issues.apache.org/jira/browse/PIG-2616
> Project: Pig
> Issue Type: Bug
> Reporter: Bill Graham
> Assignee: Bill Graham
> Fix For: 0.11
>
> Attachments: PIG-2616.3.patch, pig-2616.1.patch, pig-2616.2.patch
>
>
> PIG-2573 made it possible for {{JobControlCompiler}} to get input size from {{LoadFuncs}}, but in some cases (i.e. {{InterStorage}}), {{getStatistics}} throws an exception:
> {noformat}
> Caused by: java.lang.UnsupportedOperationException
> at org.apache.pig.impl.io.InterStorage.getStatistics(InterStorage.java:189)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getInputSizeFromLoader(JobControlCompiler.java:839)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getInputSize(JobControlCompiler.java:799)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.estimateNumberOfReducers(JobControlCompiler.java:777)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getJob(JobControlCompiler.java:599)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2616)
JobControlCompiler.getInputSizeFromLoader must handle exceptions from
LoadFunc.getStatistics.
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Graham updated PIG-2616:
-----------------------------
Fix Version/s: (was: 0.10.1)
> JobControlCompiler.getInputSizeFromLoader must handle exceptions from LoadFunc.getStatistics.
> ---------------------------------------------------------------------------------------------
>
> Key: PIG-2616
> URL: https://issues.apache.org/jira/browse/PIG-2616
> Project: Pig
> Issue Type: Bug
> Reporter: Bill Graham
> Assignee: Bill Graham
> Fix For: 0.11
>
> Attachments: PIG-2616.3.patch, pig-2616.1.patch, pig-2616.2.patch
>
>
> PIG-2573 made it possible for {{JobControlCompiler}} to get input size from {{LoadFuncs}}, but in some cases (i.e. {{InterStorage}}), {{getStatistics}} throws an exception:
> {noformat}
> Caused by: java.lang.UnsupportedOperationException
> at org.apache.pig.impl.io.InterStorage.getStatistics(InterStorage.java:189)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getInputSizeFromLoader(JobControlCompiler.java:839)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getInputSize(JobControlCompiler.java:799)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.estimateNumberOfReducers(JobControlCompiler.java:777)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getJob(JobControlCompiler.java:599)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2616)
JobControlCompiler.getInputSizeFromLoader must handle exceptions from
LoadFunc.getStatistics.
Posted by "Bill Graham (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Graham updated PIG-2616:
-----------------------------
Attachment: pig-2616.1.patch
> JobControlCompiler.getInputSizeFromLoader must handle exceptions from LoadFunc.getStatistics.
> ---------------------------------------------------------------------------------------------
>
> Key: PIG-2616
> URL: https://issues.apache.org/jira/browse/PIG-2616
> Project: Pig
> Issue Type: Bug
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: pig-2616.1.patch
>
>
> PIG-2573 made it possible for {{JobControlCompiler}} to get input size from {{LoadFuncs}}, but in some cases (i.e. {{InterStorage}}), {{getStatistics}} throws an exception:
> {noformat}
> Caused by: java.lang.UnsupportedOperationException
> at org.apache.pig.impl.io.InterStorage.getStatistics(InterStorage.java:189)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getInputSizeFromLoader(JobControlCompiler.java:839)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getInputSize(JobControlCompiler.java:799)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.estimateNumberOfReducers(JobControlCompiler.java:777)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getJob(JobControlCompiler.java:599)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2616)
JobControlCompiler.getInputSizeFromLoader must handle exceptions from
LoadFunc.getStatistics.
Posted by "Bill Graham (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Graham updated PIG-2616:
-----------------------------
Attachment: pig-2616.2.patch
Here's a patch that returns null from {{InterStorage.getStatistics}}, which aligns with the contract of the {{LoadMetadata}} javadoc.
> JobControlCompiler.getInputSizeFromLoader must handle exceptions from LoadFunc.getStatistics.
> ---------------------------------------------------------------------------------------------
>
> Key: PIG-2616
> URL: https://issues.apache.org/jira/browse/PIG-2616
> Project: Pig
> Issue Type: Bug
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: pig-2616.1.patch, pig-2616.2.patch
>
>
> PIG-2573 made it possible for {{JobControlCompiler}} to get input size from {{LoadFuncs}}, but in some cases (i.e. {{InterStorage}}), {{getStatistics}} throws an exception:
> {noformat}
> Caused by: java.lang.UnsupportedOperationException
> at org.apache.pig.impl.io.InterStorage.getStatistics(InterStorage.java:189)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getInputSizeFromLoader(JobControlCompiler.java:839)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getInputSize(JobControlCompiler.java:799)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.estimateNumberOfReducers(JobControlCompiler.java:777)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getJob(JobControlCompiler.java:599)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2616)
JobControlCompiler.getInputSizeFromLoader must handle exceptions from
LoadFunc.getStatistics.
Posted by "Dmitriy V. Ryaboy (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238613#comment-13238613 ]
Dmitriy V. Ryaboy commented on PIG-2616:
----------------------------------------
+1. Don't think tests are needed. Will commit later today.
> JobControlCompiler.getInputSizeFromLoader must handle exceptions from LoadFunc.getStatistics.
> ---------------------------------------------------------------------------------------------
>
> Key: PIG-2616
> URL: https://issues.apache.org/jira/browse/PIG-2616
> Project: Pig
> Issue Type: Bug
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: pig-2616.1.patch, pig-2616.2.patch
>
>
> PIG-2573 made it possible for {{JobControlCompiler}} to get input size from {{LoadFuncs}}, but in some cases (i.e. {{InterStorage}}), {{getStatistics}} throws an exception:
> {noformat}
> Caused by: java.lang.UnsupportedOperationException
> at org.apache.pig.impl.io.InterStorage.getStatistics(InterStorage.java:189)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getInputSizeFromLoader(JobControlCompiler.java:839)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getInputSize(JobControlCompiler.java:799)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.estimateNumberOfReducers(JobControlCompiler.java:777)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getJob(JobControlCompiler.java:599)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira