You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Bart van der Schans (JIRA)" <ji...@apache.org> on 2008/12/31 01:36:44 UTC
[jira] Created: (JCR-1918) DbDataStore keeps ResultSets open
DbDataStore keeps ResultSets open
---------------------------------
Key: JCR-1918
URL: https://issues.apache.org/jira/browse/JCR-1918
Project: Jackrabbit
Issue Type: Bug
Components: jackrabbit-core
Affects Versions: core 1.4.6
Reporter: Bart van der Schans
The DbDataStore does not always close the ResultSet which can lead to memory leaks and/or large memory usage. It seems that this already has been fixed in trunk and 1.5.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1918) DbDataStore keeps ResultSets open
Posted by "Bart van der Schans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665815#action_12665815 ]
Bart van der Schans commented on JCR-1918:
------------------------------------------
Thx Thomas!
> DbDataStore keeps ResultSets open
> ---------------------------------
>
> Key: JCR-1918
> URL: https://issues.apache.org/jira/browse/JCR-1918
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: core 1.4.6, core 1.4.7
> Reporter: Bart van der Schans
> Assignee: Thomas Mueller
> Fix For: core 1.4.8
>
> Attachments: dbdatastore_close_rs.patch
>
>
> The DbDataStore does not always close the ResultSet which can lead to memory leaks and/or large memory usage. It seems that this already has been fixed in trunk and 1.5.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1918) DbDataStore keeps ResultSets open
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665792#action_12665792 ]
Thomas Mueller commented on JCR-1918:
-------------------------------------
The patch is incorrect if copyWhenReading is disabled. I will fix it.
> DbDataStore keeps ResultSets open
> ---------------------------------
>
> Key: JCR-1918
> URL: https://issues.apache.org/jira/browse/JCR-1918
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: core 1.4.6, core 1.4.7
> Reporter: Bart van der Schans
> Assignee: Thomas Mueller
> Fix For: core 1.4.8
>
> Attachments: dbdatastore_close_rs.patch
>
>
> The DbDataStore does not always close the ResultSet which can lead to memory leaks and/or large memory usage. It seems that this already has been fixed in trunk and 1.5.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1918) DbDataStore keeps ResultSets open
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-1918:
-------------------------------
Affects Version/s: core 1.4.7
Fix Version/s: core 1.4.8
Scheduling for jackrabbit-core 1.4.8.
> DbDataStore keeps ResultSets open
> ---------------------------------
>
> Key: JCR-1918
> URL: https://issues.apache.org/jira/browse/JCR-1918
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: core 1.4.6, core 1.4.7
> Reporter: Bart van der Schans
> Fix For: core 1.4.8
>
> Attachments: dbdatastore_close_rs.patch
>
>
> The DbDataStore does not always close the ResultSet which can lead to memory leaks and/or large memory usage. It seems that this already has been fixed in trunk and 1.5.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1918) DbDataStore keeps ResultSets open
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Mueller resolved JCR-1918.
---------------------------------
Resolution: Fixed
Committed in r736286 (1.4 branch)
> DbDataStore keeps ResultSets open
> ---------------------------------
>
> Key: JCR-1918
> URL: https://issues.apache.org/jira/browse/JCR-1918
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: core 1.4.6, core 1.4.7
> Reporter: Bart van der Schans
> Assignee: Thomas Mueller
> Fix For: core 1.4.8
>
> Attachments: dbdatastore_close_rs.patch
>
>
> The DbDataStore does not always close the ResultSet which can lead to memory leaks and/or large memory usage. It seems that this already has been fixed in trunk and 1.5.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JCR-1918) DbDataStore keeps ResultSets open
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Mueller reassigned JCR-1918:
-----------------------------------
Assignee: Thomas Mueller
> DbDataStore keeps ResultSets open
> ---------------------------------
>
> Key: JCR-1918
> URL: https://issues.apache.org/jira/browse/JCR-1918
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: core 1.4.6, core 1.4.7
> Reporter: Bart van der Schans
> Assignee: Thomas Mueller
> Fix For: core 1.4.8
>
> Attachments: dbdatastore_close_rs.patch
>
>
> The DbDataStore does not always close the ResultSet which can lead to memory leaks and/or large memory usage. It seems that this already has been fixed in trunk and 1.5.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1918) DbDataStore keeps ResultSets open
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661619#action_12661619 ]
Thomas Mueller commented on JCR-1918:
-------------------------------------
Instead of committing this patch is backport JCR-1825 (DBDataStore doesn't support concurrent reads). Another difference to the 1.4.x branch is JCR-1864 (Database Data Store: clean up the code).
How important is 1.4.6 for you (why don't you upgrade to 1.5)?
> DbDataStore keeps ResultSets open
> ---------------------------------
>
> Key: JCR-1918
> URL: https://issues.apache.org/jira/browse/JCR-1918
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: core 1.4.6
> Reporter: Bart van der Schans
> Attachments: dbdatastore_close_rs.patch
>
>
> The DbDataStore does not always close the ResultSet which can lead to memory leaks and/or large memory usage. It seems that this already has been fixed in trunk and 1.5.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1918) DbDataStore keeps ResultSets open
Posted by "Bart van der Schans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661753#action_12661753 ]
Bart van der Schans commented on JCR-1918:
------------------------------------------
The code in 1.5 and trunk has clearly improved and looks much better. The idea of this patch instead of backporting the other patches is that it fixes the specific problem without doing any refactoring, minimizing the risk of introducing new behavior or bugs. We will be upgrading to 1.5 within the next month, but I could still be useful to people who are stuck to 1.4 when a new maintenance release is done of the core.
For some background: I ran into this bug when importing some 15GB of data for a customer. Without the patch I ran into OOMs using 1GB of memory within 40 minutes. With the patch the import script was running fine for almost 2 days straight getting all the data in. The setup was running on linux 64bit with java 6 64bit in Tomcat 6 with mysql configured as a datasource.
> DbDataStore keeps ResultSets open
> ---------------------------------
>
> Key: JCR-1918
> URL: https://issues.apache.org/jira/browse/JCR-1918
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: core 1.4.6
> Reporter: Bart van der Schans
> Attachments: dbdatastore_close_rs.patch
>
>
> The DbDataStore does not always close the ResultSet which can lead to memory leaks and/or large memory usage. It seems that this already has been fixed in trunk and 1.5.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1918) DbDataStore keeps ResultSets open
Posted by "Bart van der Schans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bart van der Schans updated JCR-1918:
-------------------------------------
Attachment: dbdatastore_close_rs.patch
> DbDataStore keeps ResultSets open
> ---------------------------------
>
> Key: JCR-1918
> URL: https://issues.apache.org/jira/browse/JCR-1918
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: core 1.4.6
> Reporter: Bart van der Schans
> Attachments: dbdatastore_close_rs.patch
>
>
> The DbDataStore does not always close the ResultSet which can lead to memory leaks and/or large memory usage. It seems that this already has been fixed in trunk and 1.5.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1918) DbDataStore keeps ResultSets open
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665782#action_12665782 ]
Thomas Mueller commented on JCR-1918:
-------------------------------------
The patch doesn't close the first result sets in the method DbDataStore.addRecord.
I will create a new patch and test it.
> DbDataStore keeps ResultSets open
> ---------------------------------
>
> Key: JCR-1918
> URL: https://issues.apache.org/jira/browse/JCR-1918
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: core 1.4.6, core 1.4.7
> Reporter: Bart van der Schans
> Assignee: Thomas Mueller
> Fix For: core 1.4.8
>
> Attachments: dbdatastore_close_rs.patch
>
>
> The DbDataStore does not always close the ResultSet which can lead to memory leaks and/or large memory usage. It seems that this already has been fixed in trunk and 1.5.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1918) DbDataStore keeps ResultSets open
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665783#action_12665783 ]
Thomas Mueller commented on JCR-1918:
-------------------------------------
I'm sorry - it does close the result set. I will test the patch and commit it.
> DbDataStore keeps ResultSets open
> ---------------------------------
>
> Key: JCR-1918
> URL: https://issues.apache.org/jira/browse/JCR-1918
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: core 1.4.6, core 1.4.7
> Reporter: Bart van der Schans
> Assignee: Thomas Mueller
> Fix For: core 1.4.8
>
> Attachments: dbdatastore_close_rs.patch
>
>
> The DbDataStore does not always close the ResultSet which can lead to memory leaks and/or large memory usage. It seems that this already has been fixed in trunk and 1.5.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.