You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/28 01:12:06 UTC
[GitHub] [dubbo-getty] wongoo commented on a change in pull request #57: Ftr: return write length
wongoo commented on a change in pull request #57:
URL: https://github.com/apache/dubbo-getty/pull/57#discussion_r565752758
##########
File path: connection.go
##########
@@ -288,7 +288,8 @@ func (t *gettyTCPConn) send(pkg interface{}) (int, error) {
if buffers, ok := pkg.([][]byte); ok {
netBuf := net.Buffers(buffers)
- if length, err := netBuf.WriteTo(t.conn); err == nil {
+ length, err := netBuf.WriteTo(t.conn)
Review comment:
should change `:=` to `=`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org