You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/10/01 01:31:17 UTC
Review Request 26208: Added a test for the Master <-> Slave
reconciliation race.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26208/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-1696
https://issues.apache.org/jira/browse/MESOS-1696
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/tests/master_slave_reconciliation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/26208/diff/
Testing
-------
Ran this new test in repetition.
Thanks,
Ben Mahler
Re: Review Request 26208: Added a test for the Master <-> Slave
reconciliation race.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26208/#review55053
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26198, 26199, 26200, 26201, 26202, 26203, 26204, 26205, 26206, 26207, 26208]
All tests passed.
- Mesos ReviewBot
On Sept. 30, 2014, 11:31 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26208/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2014, 11:31 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1696
> https://issues.apache.org/jira/browse/MESOS-1696
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/master_slave_reconciliation_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26208/diff/
>
>
> Testing
> -------
>
> Ran this new test in repetition.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 26208: Added a test for the Master <-> Slave
reconciliation race.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26208/#review55904
-----------------------------------------------------------
Bad patch!
Reviews applied: [26198]
Failed command: git apply --index 26198.patch
Error:
error: patch failed: src/master/master.cpp:3925
error: src/master/master.cpp: patch does not apply
- Mesos ReviewBot
On Oct. 8, 2014, 11:39 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26208/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2014, 11:39 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1696
> https://issues.apache.org/jira/browse/MESOS-1696
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/master_slave_reconciliation_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26208/diff/
>
>
> Testing
> -------
>
> Ran this new test in repetition.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 26208: Added a test for the Master <-> Slave
reconciliation race.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26208/#review55914
-----------------------------------------------------------
Bad patch!
Reviews applied: [26206, 26207]
Failed command: git apply --index 26207.patch
Error:
error: patch failed: src/Makefile.am:1104
error: src/Makefile.am: patch does not apply
- Mesos ReviewBot
On Oct. 9, 2014, 12:15 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26208/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 12:15 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1696
> https://issues.apache.org/jira/browse/MESOS-1696
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/master_slave_reconciliation_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26208/diff/
>
>
> Testing
> -------
>
> Ran this new test in repetition.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 26208: Added a test for the Master <-> Slave
reconciliation race.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26208/
-----------------------------------------------------------
(Updated Oct. 9, 2014, 12:15 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Re-added dependency for reviewbot.
Bugs: MESOS-1696
https://issues.apache.org/jira/browse/MESOS-1696
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/tests/master_slave_reconciliation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/26208/diff/
Testing
-------
Ran this new test in repetition.
Thanks,
Ben Mahler
Re: Review Request 26208: Added a test for the Master <-> Slave
reconciliation race.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26208/
-----------------------------------------------------------
(Updated Oct. 9, 2014, 12:11 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Remove dependency.
Bugs: MESOS-1696
https://issues.apache.org/jira/browse/MESOS-1696
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/tests/master_slave_reconciliation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/26208/diff/
Testing
-------
Ran this new test in repetition.
Thanks,
Ben Mahler
Re: Review Request 26208: Added a test for the Master <-> Slave
reconciliation race.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26208/
-----------------------------------------------------------
(Updated Oct. 8, 2014, 11:39 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Vinod's review.
Bugs: MESOS-1696
https://issues.apache.org/jira/browse/MESOS-1696
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/tests/master_slave_reconciliation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/26208/diff/
Testing
-------
Ran this new test in repetition.
Thanks,
Ben Mahler
Re: Review Request 26208: Added a test for the Master <-> Slave
reconciliation race.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26208/#review55157
-----------------------------------------------------------
Ship it!
src/tests/master_slave_reconciliation_tests.cpp
<https://reviews.apache.org/r/26208/#comment95540>
s/launch/launch task/
src/tests/master_slave_reconciliation_tests.cpp
<https://reviews.apache.org/r/26208/#comment95543>
Neither the slave nor the master right?
- Vinod Kone
On Sept. 30, 2014, 11:31 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26208/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2014, 11:31 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1696
> https://issues.apache.org/jira/browse/MESOS-1696
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/master_slave_reconciliation_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26208/diff/
>
>
> Testing
> -------
>
> Ran this new test in repetition.
>
>
> Thanks,
>
> Ben Mahler
>
>