You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by jc...@apache.org on 2008/04/06 23:17:19 UTC
svn commit: r645310 - in
/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket:
markup/html/debug/WicketComponentTreeTestPage_ExpectedResult.html
protocol/http/FirstPage.java protocol/http/SecondPage.java
Author: jcompagner
Date: Sun Apr 6 14:17:18 2008
New Revision: 645310
URL: http://svn.apache.org/viewvc?rev=645310&view=rev
Log:
unit test fixes
Modified:
wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/debug/WicketComponentTreeTestPage_ExpectedResult.html
wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/protocol/http/FirstPage.java
wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/protocol/http/SecondPage.java
Modified: wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/debug/WicketComponentTreeTestPage_ExpectedResult.html
URL: http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/debug/WicketComponentTreeTestPage_ExpectedResult.html?rev=645310&r1=645309&r2=645310&view=diff
==============================================================================
--- wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/debug/WicketComponentTreeTestPage_ExpectedResult.html (original)
+++ wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/debug/WicketComponentTreeTestPage_ExpectedResult.html Sun Apr 6 14:17:18 2008
@@ -34,13 +34,13 @@
<tr wicket:id="components">
<td valign="top" align="left"><span wicket:id="row">1</span> </td>
<td valign="top" align="left"><span wicket:id="path">label1</span> </td>
- <td valign="top" align="left" nowrap><span wicket:id="size">414 bytes</span> </td>
+ <td valign="top" align="left" nowrap><span wicket:id="size">415 bytes</span> </td>
<td valign="top" align="left"><span wicket:id="type">org.apache.wicket.markup.html.basic.Label</span> </td>
<td valign="top" align="left"><span wicket:id="model">test1</span> </td>
</tr><tr wicket:id="components">
<td valign="top" align="left"><span wicket:id="row">2</span> </td>
<td valign="top" align="left"><span wicket:id="path">label2</span> </td>
- <td valign="top" align="left" nowrap><span wicket:id="size">415 bytes</span> </td>
+ <td valign="top" align="left" nowrap><span wicket:id="size">416 bytes</span> </td>
<td valign="top" align="left"><span wicket:id="type">org.apache.wicket.markup.html.basic.Label</span> </td>
<td valign="top" align="left"><span wicket:id="model">test22</span> </td>
</tr>
Modified: wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/protocol/http/FirstPage.java
URL: http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/protocol/http/FirstPage.java?rev=645310&r1=645309&r2=645310&view=diff
==============================================================================
--- wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/protocol/http/FirstPage.java (original)
+++ wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/protocol/http/FirstPage.java Sun Apr 6 14:17:18 2008
@@ -1,3 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
package org.apache.wicket.protocol.http;
import org.apache.wicket.Page;
Modified: wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/protocol/http/SecondPage.java
URL: http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/protocol/http/SecondPage.java?rev=645310&r1=645309&r2=645310&view=diff
==============================================================================
--- wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/protocol/http/SecondPage.java (original)
+++ wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/protocol/http/SecondPage.java Sun Apr 6 14:17:18 2008
@@ -1,3 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
package org.apache.wicket.protocol.http;
import org.apache.wicket.Page;
Re: svn commit: r645310 - in /wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket: markup/html/debug/WicketComponentTreeTestPage_ExpectedResult.html protocol/http/FirstPage.java protocol/http/SecondPage.java
Posted by Igor Vaynberg <ig...@gmail.com>.
id gladly trade a 10% increased chance of stack overflow if you can
save 5 bytes!
-igor
On Mon, Apr 7, 2008 at 5:09 AM, Johan Compagner <jc...@gmail.com> wrote:
> only the serialization output, not in memory.
>
> But i guess i can revert that change so that we save 1 byte in the serial
> output
> Then we have now and then a stackoverflow under certain situations but i
> guess that is way better yes..
> Maybe i can change it that way that i only save 1 byte maybe, maybe other
> things also will stop working then in certain situations
> but then we can store a lot of pages!
>
> /me starts calculating now how many then fit in a 500GB hd...
>
> johan
>
>
>
>
> On Mon, Apr 7, 2008 at 12:06 AM, Martijn Dashorst <
> martijn.dashorst@gmail.com> wrote:
>
> > On 4/6/08, jcompagner@apache.org <jc...@apache.org> wrote:
> > > - <td valign="top" align="left" nowrap><span
> > wicket:id="size">414 bytes</span> </td>
> > > + <td valign="top" align="left" nowrap><span
> > wicket:id="size">415 bytes</span> </td>
> >
> > > - <td valign="top" align="left" nowrap><span
> > wicket:id="size">415 bytes</span> </td>
> > > + <td valign="top" align="left" nowrap><span
> > wicket:id="size">416 bytes</span> </td>
> >
> > You increased the memory usage! Heretic!!!
> >
> > Martijn
> >
> > --
> > Buy Wicket in Action: http://manning.com/dashorst
> > Apache Wicket 1.3.2 is released
> > Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.2
> >
>
Re: svn commit: r645310 - in /wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket: markup/html/debug/WicketComponentTreeTestPage_ExpectedResult.html protocol/http/FirstPage.java protocol/http/SecondPage.java
Posted by Johan Compagner <jc...@gmail.com>.
only the serialization output, not in memory.
But i guess i can revert that change so that we save 1 byte in the serial
output
Then we have now and then a stackoverflow under certain situations but i
guess that is way better yes..
Maybe i can change it that way that i only save 1 byte maybe, maybe other
things also will stop working then in certain situations
but then we can store a lot of pages!
/me starts calculating now how many then fit in a 500GB hd...
johan
On Mon, Apr 7, 2008 at 12:06 AM, Martijn Dashorst <
martijn.dashorst@gmail.com> wrote:
> On 4/6/08, jcompagner@apache.org <jc...@apache.org> wrote:
> > - <td valign="top" align="left" nowrap><span
> wicket:id="size">414 bytes</span> </td>
> > + <td valign="top" align="left" nowrap><span
> wicket:id="size">415 bytes</span> </td>
>
> > - <td valign="top" align="left" nowrap><span
> wicket:id="size">415 bytes</span> </td>
> > + <td valign="top" align="left" nowrap><span
> wicket:id="size">416 bytes</span> </td>
>
> You increased the memory usage! Heretic!!!
>
> Martijn
>
> --
> Buy Wicket in Action: http://manning.com/dashorst
> Apache Wicket 1.3.2 is released
> Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.2
>
Re: svn commit: r645310 - in /wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket: markup/html/debug/WicketComponentTreeTestPage_ExpectedResult.html protocol/http/FirstPage.java protocol/http/SecondPage.java
Posted by Martijn Dashorst <ma...@gmail.com>.
On 4/6/08, jcompagner@apache.org <jc...@apache.org> wrote:
> - <td valign="top" align="left" nowrap><span wicket:id="size">414 bytes</span> </td>
> + <td valign="top" align="left" nowrap><span wicket:id="size">415 bytes</span> </td>
> - <td valign="top" align="left" nowrap><span wicket:id="size">415 bytes</span> </td>
> + <td valign="top" align="left" nowrap><span wicket:id="size">416 bytes</span> </td>
You increased the memory usage! Heretic!!!
Martijn
--
Buy Wicket in Action: http://manning.com/dashorst
Apache Wicket 1.3.2 is released
Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.2