You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/11/24 23:53:52 UTC
[GitHub] leakingoxide opened a new pull request #6430: Add See Tableview
Form button to the Datasource Editor modal
leakingoxide opened a new pull request #6430: Add See Tableview Form button to the Datasource Editor modal
URL: https://github.com/apache/incubator-superset/pull/6430
This is a PR for https://github.com/apache/incubator-superset/issues/6101.
Turned out to be easier than I thought because edit_url was already in the props.
Things to be especially considered in the review phase:
* Modal doesn't have all of the fields that are available in the /edit link, and if I understand correctly, this was a motivation for creating this issue. I can still add those, even though the edit button is now here, if desired (perhaps in a new PR?)
* Whether the new button should stay on the left or right side of modal, as pointed out by hughhhh during our conversation
Preview:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org