You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "jbertram (via GitHub)" <gi...@apache.org> on 2024/09/18 20:01:15 UTC
[PR] ARTEMIS-5052 hash authentication cache keys [activemq-artemis]
jbertram opened a new pull request, #5236:
URL: https://github.com/apache/activemq-artemis/pull/5236
Existing tests should suffice to validate this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-5052 hash authentication cache keys [activemq-artemis]
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #5236:
URL: https://github.com/apache/activemq-artemis/pull/5236#issuecomment-2361890546
@tabish121, the latest run looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-5052 hash authentication cache keys [activemq-artemis]
Posted by "tabish121 (via GitHub)" <gi...@apache.org>.
tabish121 commented on PR #5236:
URL: https://github.com/apache/activemq-artemis/pull/5236#issuecomment-2361426801
I ran a CI build of this change to check existing tests cover it and sure enough there's some failures:
> [main] 15:20:34,876 INFO [org.apache.activemq.artemis.tests.extensions.LogTestNameExtension] *** start test MessageConsumerTest testRelayMessage() ***
[Thread-2 (ActiveMQ-server-ActiveMQServerImpl::name=localhost)] 15:20:34,904 WARN [org.apache.activemq.artemis.core.server] AMQ222225: Sending unexpected exception to the client
java.lang.ArrayIndexOutOfBoundsException: arraycopy: last destination index 101 out of bounds for byte[64]
at java.base/java.lang.System.arraycopy(Native Method) ~[?:?]
at java.base/sun.security.provider.DigestBase.engineUpdate(DigestBase.java:118) ~[?:?]
at java.base/sun.security.provider.SHA2.implDigest(SHA2.java:107) ~[?:?]
at java.base/sun.security.provider.DigestBase.engineDigest(DigestBase.java:210) ~[?:?]
at java.base/sun.security.provider.DigestBase.engineDigest(DigestBase.java:189) ~[?:?]
at java.base/java.security.MessageDigest$Delegate.engineDigest(MessageDigest.java:639) ~[?:?]
at java.base/java.security.MessageDigest.digest(MessageDigest.java:385) ~[?:?]
at java.base/java.security.MessageDigest.digest(MessageDigest.java:431) ~[?:?]
at org.apache.activemq.artemis.core.security.impl.SecurityStoreImpl.createAuthenticationCacheKey(SecurityStoreImpl.java:550) ~[classes/:?]
at org.apache.activemq.artemis.core.security.impl.SecurityStoreImpl.getAuthenticationCacheEntry(SecurityStoreImpl.java:492) ~[classes/:?]
at org.apache.activemq.artemis.core.security.impl.SecurityStoreImpl.getSubjectForAuthorization(SecurityStoreImpl.java:447) ~[classes/:?]
at org.apache.activemq.artemis.core.security.impl.SecurityStoreImpl.check(SecurityStoreImpl.java:308) ~[classes/:?]
at org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.securityCheck(ServerSessionImpl.java:518) ~[classes/:?]
at org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.doSend(ServerSessionImpl.java:2333) ~[classes/:?]
at org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.send(ServerSessionImpl.java:1963) ~[classes/:?]
at org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.send(ServerSessionImpl.java:1902) ~[classes/:?]
at org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.send(ServerSessionImpl.java:1893) ~[classes/:?]
at org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.send(ServerSessionImpl.java:1885) ~[classes/:?]
at org.apache.activemq.artemis.core.protocol.core.ServerSessionPacketHandler.onSessionSend(ServerSessionPacketHandler.java:795) ~[classes/:?]
at org.apache.activemq.artemis.core.protocol.core.ServerSessionPacketHandler.onMessagePacket(ServerSessionPacketHandler.java:302) ~[classes/:?]
at org.apache.activemq.artemis.utils.actors.Actor.doTask(Actor.java:32) ~[classes/:?]
at org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:68) ~[classes/:?]
at org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:57) ~[classes/:?]
at org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:32) ~[classes/:?]
at org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:68) ~[classes/:?]
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
at org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118) [classes/:?]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-5052 hash authentication cache keys [activemq-artemis]
Posted by "tabish121 (via GitHub)" <gi...@apache.org>.
tabish121 merged PR #5236:
URL: https://github.com/apache/activemq-artemis/pull/5236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-5052 hash authentication cache keys [activemq-artemis]
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #5236:
URL: https://github.com/apache/activemq-artemis/pull/5236#issuecomment-2361782427
Looks like it was a concurrency issue with the `MessageDigest` instance. I've adjusted the code, and I'm running the test-suite again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact