You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/06/13 09:45:58 UTC
[GitHub] [dubbo] chickenlj opened a new pull request, #10148: register MetadataService as internal service
chickenlj opened a new pull request, #10148:
URL: https://github.com/apache/dubbo/pull/10148
related issue https://github.com/apache/dubbo/issues/10120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] chickenlj commented on pull request #10148: register MetadataService as internal service
Posted by GitBox <gi...@apache.org>.
chickenlj commented on PR #10148:
URL: https://github.com/apache/dubbo/pull/10148#issuecomment-1157308253
related https://github.com/apache/dubbo/pull/10110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #10148: register MetadataService as internal service
Posted by GitBox <gi...@apache.org>.
AlbumenJ merged PR #10148:
URL: https://github.com/apache/dubbo/pull/10148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #10148: register MetadataService as internal service
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #10148:
URL: https://github.com/apache/dubbo/pull/10148#issuecomment-1157276209
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/10148?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10148](https://codecov.io/gh/apache/dubbo/pull/10148?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f246b7) into [3.0](https://codecov.io/gh/apache/dubbo/commit/89863e048d745b5c655a6b859347b32939b743db?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (89863e0) will **decrease** coverage by `0.29%`.
> The diff coverage is `93.84%`.
> :exclamation: Current head 2f246b7 differs from pull request most recent head 147a29b. Consider uploading reports for the commit 147a29b to get more accurate results
```diff
@@ Coverage Diff @@
## 3.0 #10148 +/- ##
============================================
- Coverage 65.68% 65.39% -0.30%
+ Complexity 320 319 -1
============================================
Files 1224 1225 +1
Lines 53413 53422 +9
Branches 8077 8048 -29
============================================
- Hits 35086 34933 -153
- Misses 14508 14649 +141
- Partials 3819 3840 +21
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/10148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/dubbo/common/constants/CommonConstants.java](https://codecov.io/gh/apache/dubbo/pull/10148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uc3RhbnRzL0NvbW1vbkNvbnN0YW50cy5qYXZh) | `100.00% <ø> (ø)` | |
| [...che/dubbo/metadata/AbstractServiceNameMapping.java](https://codecov.io/gh/apache/dubbo/pull/10148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9BYnN0cmFjdFNlcnZpY2VOYW1lTWFwcGluZy5qYXZh) | `83.62% <ø> (ø)` | |
| [.../dubbo/registry/client/metadata/MetadataUtils.java](https://codecov.io/gh/apache/dubbo/pull/10148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvbWV0YWRhdGEvTWV0YWRhdGFVdGlscy5qYXZh) | `65.34% <84.00%> (+1.06%)` | :arrow_up: |
| [.../threadpool/manager/DefaultExecutorRepository.java](https://codecov.io/gh/apache/dubbo/pull/10148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9tYW5hZ2VyL0RlZmF1bHRFeGVjdXRvclJlcG9zaXRvcnkuamF2YQ==) | `70.05% <100.00%> (+0.92%)` | :arrow_up: |
| [...n/java/org/apache/dubbo/rpc/model/ModuleModel.java](https://codecov.io/gh/apache/dubbo/pull/10148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvTW9kdWxlTW9kZWwuamF2YQ==) | `93.58% <100.00%> (+1.16%)` | :arrow_up: |
| [...pache/dubbo/rpc/model/ModuleServiceRepository.java](https://codecov.io/gh/apache/dubbo/pull/10148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvTW9kdWxlU2VydmljZVJlcG9zaXRvcnkuamF2YQ==) | `68.04% <100.00%> (ø)` | |
| [.../metadata/ConfigurableMetadataServiceExporter.java](https://codecov.io/gh/apache/dubbo/pull/10148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9tZXRhZGF0YS9Db25maWd1cmFibGVNZXRhZGF0YVNlcnZpY2VFeHBvcnRlci5qYXZh) | `77.52% <100.00%> (+1.33%)` | :arrow_up: |
| [...apache/dubbo/metadata/MetadataServiceDetector.java](https://codecov.io/gh/apache/dubbo/pull/10148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9NZXRhZGF0YVNlcnZpY2VEZXRlY3Rvci5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...nt/metadata/StandardMetadataServiceURLBuilder.java](https://codecov.io/gh/apache/dubbo/pull/10148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvbWV0YWRhdGEvU3RhbmRhcmRNZXRhZGF0YVNlcnZpY2VVUkxCdWlsZGVyLmphdmE=) | `88.67% <100.00%> (+0.67%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/TripleProtocol.java](https://codecov.io/gh/apache/dubbo/pull/10148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlUHJvdG9jb2wuamF2YQ==) | `85.36% <100.00%> (ø)` | |
| ... and [77 more](https://codecov.io/gh/apache/dubbo/pull/10148/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/10148?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/10148?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [89863e0...147a29b](https://codecov.io/gh/apache/dubbo/pull/10148?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org