You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Neha Narkhede (JIRA)" <ji...@apache.org> on 2011/08/18 22:37:27 UTC

[jira] [Created] (KAFKA-112) Improve the command line tools in the bin directory to use the compression feature correctly

Improve the command line tools in the bin directory to use the compression feature correctly
--------------------------------------------------------------------------------------------

                 Key: KAFKA-112
                 URL: https://issues.apache.org/jira/browse/KAFKA-112
             Project: Kafka
          Issue Type: Improvement
    Affects Versions: 0.7
            Reporter: Neha Narkhede


This ticket is filed to improve various command line tools -

1. The command line tools are still using the older Iterator API of the ByteBufferMessageSet.
2. A bug in ProducerPerformance does not set the compression codec correctly.
3. The simple consumer shell lacks some useful command line options and needs better logging
4. All tools need to use the new Iterator API for ByteBufferMessageSet that returns MessageAndOffset


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (KAFKA-112) Improve the command line tools in the bin directory to use the compression feature correctly

Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jun Rao updated KAFKA-112:
--------------------------

       Resolution: Fixed
    Fix Version/s: 0.7
           Status: Resolved  (was: Patch Available)

> Improve the command line tools in the bin directory to use the compression feature correctly
> --------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-112
>                 URL: https://issues.apache.org/jira/browse/KAFKA-112
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.7
>            Reporter: Neha Narkhede
>             Fix For: 0.7
>
>         Attachments: KAFKA-112.patch, KAFKA-112.patch
>
>
> This ticket is filed to improve various command line tools -
> 1. All tools need to use the new Iterator API for ByteBufferMessageSet that returns MessageAndOffset
> 2. A bug in ProducerPerformance does not set the compression codec correctly.
> 3. The simple consumer shell lacks some useful command line options and needs better logging

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (KAFKA-112) Improve the command line tools in the bin directory to use the compression feature correctly

Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KAFKA-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088006#comment-13088006 ] 

Jun Rao commented on KAFKA-112:
-------------------------------

The patch looks good. The patch doesn't apply because you moved DumpLogSegment from the util to tools (which is good).

> Improve the command line tools in the bin directory to use the compression feature correctly
> --------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-112
>                 URL: https://issues.apache.org/jira/browse/KAFKA-112
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.7
>            Reporter: Neha Narkhede
>         Attachments: KAFKA-112.patch, KAFKA-112.patch
>
>
> This ticket is filed to improve various command line tools -
> 1. All tools need to use the new Iterator API for ByteBufferMessageSet that returns MessageAndOffset
> 2. A bug in ProducerPerformance does not set the compression codec correctly.
> 3. The simple consumer shell lacks some useful command line options and needs better logging

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (KAFKA-112) Improve the command line tools in the bin directory to use the compression feature correctly

Posted by "Neha Narkhede (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Neha Narkhede updated KAFKA-112:
--------------------------------

    Status: Patch Available  (was: Open)

> Improve the command line tools in the bin directory to use the compression feature correctly
> --------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-112
>                 URL: https://issues.apache.org/jira/browse/KAFKA-112
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.7
>            Reporter: Neha Narkhede
>         Attachments: KAFKA-112.patch
>
>
> This ticket is filed to improve various command line tools -
> 1. All tools need to use the new Iterator API for ByteBufferMessageSet that returns MessageAndOffset
> 2. A bug in ProducerPerformance does not set the compression codec correctly.
> 3. The simple consumer shell lacks some useful command line options and needs better logging

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (KAFKA-112) Improve the command line tools in the bin directory to use the compression feature correctly

Posted by "Neha Narkhede (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Neha Narkhede updated KAFKA-112:
--------------------------------

    Attachment: KAFKA-112.patch

Jun,

That makes sense. I reverted that change to the DumpLogSegments utility.

Thanks,
Neha

> Improve the command line tools in the bin directory to use the compression feature correctly
> --------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-112
>                 URL: https://issues.apache.org/jira/browse/KAFKA-112
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.7
>            Reporter: Neha Narkhede
>         Attachments: KAFKA-112.patch, KAFKA-112.patch
>
>
> This ticket is filed to improve various command line tools -
> 1. All tools need to use the new Iterator API for ByteBufferMessageSet that returns MessageAndOffset
> 2. A bug in ProducerPerformance does not set the compression codec correctly.
> 3. The simple consumer shell lacks some useful command line options and needs better logging

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (KAFKA-112) Improve the command line tools in the bin directory to use the compression feature correctly

Posted by "Neha Narkhede (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Neha Narkhede updated KAFKA-112:
--------------------------------

    Description: 
This ticket is filed to improve various command line tools -

1. All tools need to use the new Iterator API for ByteBufferMessageSet that returns MessageAndOffset
2. A bug in ProducerPerformance does not set the compression codec correctly.
3. The simple consumer shell lacks some useful command line options and needs better logging



  was:
This ticket is filed to improve various command line tools -

1. The command line tools are still using the older Iterator API of the ByteBufferMessageSet.
2. A bug in ProducerPerformance does not set the compression codec correctly.
3. The simple consumer shell lacks some useful command line options and needs better logging
4. All tools need to use the new Iterator API for ByteBufferMessageSet that returns MessageAndOffset



> Improve the command line tools in the bin directory to use the compression feature correctly
> --------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-112
>                 URL: https://issues.apache.org/jira/browse/KAFKA-112
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.7
>            Reporter: Neha Narkhede
>
> This ticket is filed to improve various command line tools -
> 1. All tools need to use the new Iterator API for ByteBufferMessageSet that returns MessageAndOffset
> 2. A bug in ProducerPerformance does not set the compression codec correctly.
> 3. The simple consumer shell lacks some useful command line options and needs better logging

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (KAFKA-112) Improve the command line tools in the bin directory to use the compression feature correctly

Posted by "Neha Narkhede (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Neha Narkhede updated KAFKA-112:
--------------------------------

    Attachment: KAFKA-112.patch

> Improve the command line tools in the bin directory to use the compression feature correctly
> --------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-112
>                 URL: https://issues.apache.org/jira/browse/KAFKA-112
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.7
>            Reporter: Neha Narkhede
>         Attachments: KAFKA-112.patch
>
>
> This ticket is filed to improve various command line tools -
> 1. All tools need to use the new Iterator API for ByteBufferMessageSet that returns MessageAndOffset
> 2. A bug in ProducerPerformance does not set the compression codec correctly.
> 3. The simple consumer shell lacks some useful command line options and needs better logging

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (KAFKA-112) Improve the command line tools in the bin directory to use the compression feature correctly

Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KAFKA-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087329#comment-13087329 ] 

Jun Rao commented on KAFKA-112:
-------------------------------

1. DumpLogSegments currently returns the absolute offset, which is ideal. With the patch, it returns relative offset within a file. This will be confusing if a file starts at an offset other than 0.
2. The patch doesn't seem to apply on trunk. Could you rebase?

> Improve the command line tools in the bin directory to use the compression feature correctly
> --------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-112
>                 URL: https://issues.apache.org/jira/browse/KAFKA-112
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.7
>            Reporter: Neha Narkhede
>         Attachments: KAFKA-112.patch
>
>
> This ticket is filed to improve various command line tools -
> 1. All tools need to use the new Iterator API for ByteBufferMessageSet that returns MessageAndOffset
> 2. A bug in ProducerPerformance does not set the compression codec correctly.
> 3. The simple consumer shell lacks some useful command line options and needs better logging

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira