You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/05/24 02:15:25 UTC
[GitHub] [hbase] bharathv opened a new pull request #1766: HBASE-24422: Remove hbase-native-client code from the master branch
bharathv opened a new pull request #1766:
URL: https://github.com/apache/hbase/pull/1766
Per recent discussions in the slack channel, there is not much value
in having this code in the master branch. This code has it's dedicated
git repo at https://github.com/apache/hbase-native-client.
It was already removed from branch-1 (HBASE-19419) and branch-2
(HBASE-19176)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1766: HBASE-24422: Remove hbase-native-client code from the master branch
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1766:
URL: https://github.com/apache/hbase/pull/1766#issuecomment-633167179
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 1s | Shelldocs was not available. |
| +0 :ok: | markdownlint | 0m 1s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | shellcheck | 0m 1s | The patch generated 0 new + 1 unchanged - 40 fixed = 1 total (was 41) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. |
| | | 2m 7s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1766/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1766 |
| JIRA Issue | HBASE-24422 |
| Optional Tests | dupname asflicense shellcheck shelldocs cc markdownlint golang |
| uname | Linux ac28087ef7c3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c303f9d329 |
| Max. process+thread count | 51 (vs. ulimit of 12500) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1766/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] busbey commented on pull request #1766: HBASE-24422: Remove hbase-native-client code from the master branch
Posted by GitBox <gi...@apache.org>.
busbey commented on pull request #1766:
URL: https://github.com/apache/hbase/pull/1766#issuecomment-633168486
Conversations in slack generally should not count as project discussions per the "must be on the mailing list" bit.
However, totally agree we're overdue on removing this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bharathv merged pull request #1766: HBASE-24422: Remove hbase-native-client code from the master branch
Posted by GitBox <gi...@apache.org>.
bharathv merged pull request #1766:
URL: https://github.com/apache/hbase/pull/1766
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bharathv commented on pull request #1766: HBASE-24422: Remove hbase-native-client code from the master branch
Posted by GitBox <gi...@apache.org>.
bharathv commented on pull request #1766:
URL: https://github.com/apache/hbase/pull/1766#issuecomment-633314796
> Conversations in slack generally should not count as project discussions per the "must be on the mailing list" bit.
Fixed the commit message to remove this part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1766: HBASE-24422: Remove hbase-native-client code from the master branch
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1766:
URL: https://github.com/apache/hbase/pull/1766#issuecomment-633315174
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1766: HBASE-24422: Remove hbase-native-client code from the master branch
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1766:
URL: https://github.com/apache/hbase/pull/1766#issuecomment-633188411
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 24s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 1s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 49s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 258m 4s | root in the patch passed. |
| | | 270m 27s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1766/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1766 |
| JIRA Issue | HBASE-24422 |
| Optional Tests | unit |
| uname | Linux d729380f12af 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c303f9d329 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1766/1/testReport/ |
| Max. process+thread count | 5012 (vs. ulimit of 12500) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1766/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org