You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/08/02 17:51:59 UTC
Re: Review Request 61270: Added container PID namespace control
protobuf field in LinuxInfo.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61270/
-----------------------------------------------------------
(Updated Aug. 2, 2017, 10:51 a.m.)
Review request for mesos, Avinash sridharan, Gastón Kleiman, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone.
Repository: mesos
Description
-------
User facing interface for container configurable PID namespace.
Diffs (updated)
-----
include/mesos/mesos.proto f31f5bdc2ace2b261885b252e7c01ceb9b76c461
include/mesos/v1/mesos.proto 66386a84bc21989d1c1237e629d5d04662a368fa
Diff: https://reviews.apache.org/r/61270/diff/2/
Changes: https://reviews.apache.org/r/61270/diff/1-2/
Testing
-------
make
Thanks,
Gilbert Song
Re: Review Request 61270: Added container PID namespace control
protobuf field in LinuxInfo.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61270/#review182019
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Aug. 2, 2017, 5:51 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61270/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2017, 5:51 p.m.)
>
>
> Review request for mesos, Avinash sridharan, Gastón Kleiman, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> User facing interface for container configurable PID namespace.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto f31f5bdc2ace2b261885b252e7c01ceb9b76c461
> include/mesos/v1/mesos.proto 66386a84bc21989d1c1237e629d5d04662a368fa
>
>
> Diff: https://reviews.apache.org/r/61270/diff/2/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 61270: Added container PID namespace control
protobuf field in LinuxInfo.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61270/#review182113
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/mesos.proto
Lines 2741 (patched)
<https://reviews.apache.org/r/61270/#comment257969>
s/namepace/namespace/
include/mesos/mesos.proto
Lines 2744 (patched)
<https://reviews.apache.org/r/61270/#comment257970>
s/namespce/namespace/
include/mesos/v1/mesos.proto
Lines 2724 (patched)
<https://reviews.apache.org/r/61270/#comment257971>
Ditto.
include/mesos/v1/mesos.proto
Lines 2727 (patched)
<https://reviews.apache.org/r/61270/#comment257972>
Ditto.
- Qian Zhang
On Aug. 3, 2017, 1:51 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61270/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2017, 1:51 a.m.)
>
>
> Review request for mesos, Avinash sridharan, Gastón Kleiman, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> User facing interface for container configurable PID namespace.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto f31f5bdc2ace2b261885b252e7c01ceb9b76c461
> include/mesos/v1/mesos.proto 66386a84bc21989d1c1237e629d5d04662a368fa
>
>
> Diff: https://reviews.apache.org/r/61270/diff/2/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 61270: Added container PID namespace control
protobuf field in LinuxInfo.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61270/
-----------------------------------------------------------
(Updated Aug. 11, 2017, 11:52 a.m.)
Review request for mesos, Avinash sridharan, Gastón Kleiman, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone.
Repository: mesos
Description
-------
User facing interface for container configurable PID namespace.
Diffs (updated)
-----
include/mesos/mesos.proto f31f5bdc2ace2b261885b252e7c01ceb9b76c461
include/mesos/v1/mesos.proto 66386a84bc21989d1c1237e629d5d04662a368fa
Diff: https://reviews.apache.org/r/61270/diff/4/
Changes: https://reviews.apache.org/r/61270/diff/3-4/
Testing
-------
make
Thanks,
Gilbert Song
Re: Review Request 61270: Added container PID namespace control
protobuf field in LinuxInfo.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61270/#review182250
-----------------------------------------------------------
include/mesos/mesos.proto
Lines 2741-2746 (patched)
<https://reviews.apache.org/r/61270/#comment258147>
I'd put something like this:
```
If set, then the container will share the PID namespace with its parent. If the container is a top-level container, then it will share the PID namespace with the agent. If it is a nested container, it will shar the PID namespace with its parent container. This field will be ignored if the `namespaces/pid` isolator is not enabled.
```
- Gastón Kleiman
On Aug. 3, 2017, 9:40 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61270/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2017, 9:40 p.m.)
>
>
> Review request for mesos, Avinash sridharan, Gastón Kleiman, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> User facing interface for container configurable PID namespace.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto f31f5bdc2ace2b261885b252e7c01ceb9b76c461
> include/mesos/v1/mesos.proto 66386a84bc21989d1c1237e629d5d04662a368fa
>
>
> Diff: https://reviews.apache.org/r/61270/diff/3/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 61270: Added container PID namespace control
protobuf field in LinuxInfo.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61270/
-----------------------------------------------------------
(Updated Aug. 3, 2017, 2:40 p.m.)
Review request for mesos, Avinash sridharan, Gastón Kleiman, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone.
Repository: mesos
Description
-------
User facing interface for container configurable PID namespace.
Diffs (updated)
-----
include/mesos/mesos.proto f31f5bdc2ace2b261885b252e7c01ceb9b76c461
include/mesos/v1/mesos.proto 66386a84bc21989d1c1237e629d5d04662a368fa
Diff: https://reviews.apache.org/r/61270/diff/3/
Changes: https://reviews.apache.org/r/61270/diff/2-3/
Testing
-------
make
Thanks,
Gilbert Song