You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/27 07:56:11 UTC
[GitHub] [flink] zhuzhurk opened a new pull request, #20080: [FLINK-28258][runtime] Introduce ExecutionHistory to host historical …
zhuzhurk opened a new pull request, #20080:
URL: https://github.com/apache/flink/pull/20080
…executions for each execution vertex
## What is the purpose of the change
With speculative execution, tracking prior executions in an EvictingBoundedList does not work. This is because when using EvictingBoundedList relies on the assumption that the historical executions are added in ascending order of attempt number successively. This is no longer true if speculative execution is enabled. e.g. 3 speculative execution attempts #1, #2, #3 are running concurrently, later #3 failed, and then #1 failed, and execution attempt #2 keeps running.
The broken assumption may result in exceptions in REST, job archiving and so on.
This PR introduces an ExecutionHistory to replace EvictingBoundedList. It hosts the historical executions in a LinkedHashMap with a size bound. When the map grows beyond the size bound, elements are dropped from the head of the map (FIFO order).
## Brief change log
- *Introduced ExecutionHistory to replace EvictingBoundedList*
- *Reworked the usages*
- *Reworked the statements of prior executions to historical executions*
## Verifying this change
- *Added unit tests ExecutionHistoryTest*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (**yes** / no / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20080: [FLINK-28258] Introduce ExecutionHistory to host historical executions for each execution vertex
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20080:
URL: https://github.com/apache/flink/pull/20080#issuecomment-1167016783
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8c81b16d2b5efe4a78a455e8ddae83f60289bd73",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c81b16d2b5efe4a78a455e8ddae83f60289bd73",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c81b16d2b5efe4a78a455e8ddae83f60289bd73 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on pull request #20080: [FLINK-28258] Introduce ExecutionHistory to host historical executions for each execution vertex
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on PR #20080:
URL: https://github.com/apache/flink/pull/20080#issuecomment-1168154340
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a diff in pull request #20080: [FLINK-28258] Introduce ExecutionHistory to host historical executions for each execution vertex
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on code in PR #20080:
URL: https://github.com/apache/flink/pull/20080#discussion_r907288171
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionHistory.java:
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.executiongraph;
+
+import java.io.Serializable;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.Map;
+import java.util.Optional;
+
+/**
+ * This class hosts the historical executions of an {@link ExecutionVertex} in a {@link
+ * LinkedHashMap} with a size bound. When the map grows beyond the size bound, elements are dropped
+ * from the head of the map (FIFO order). Note that the historical executions does not include the
+ * current execution attempt.
+ */
+public class ExecutionHistory implements Serializable {
+
+ private static final long serialVersionUID = 1L;
+
+ private final BoundedLinkedHashMap<Integer, ArchivedExecution> historicalExecutions;
+
+ private int maxAttemptNumber;
+
+ public ExecutionHistory(int sizeLimit) {
+ super();
+ this.historicalExecutions = new BoundedLinkedHashMap(sizeLimit);
+ this.maxAttemptNumber = -1;
+ }
+
+ ExecutionHistory(ExecutionHistory other) {
+ this.historicalExecutions = new BoundedLinkedHashMap<>(other.historicalExecutions);
+ this.maxAttemptNumber = other.maxAttemptNumber;
+ }
+
+ void add(ArchivedExecution execution) {
+ if (execution.getAttemptNumber() > maxAttemptNumber) {
+ maxAttemptNumber = execution.getAttemptNumber();
+ }
+
+ historicalExecutions.put(execution.getAttemptNumber(), execution);
+ }
+
+ public Optional<ArchivedExecution> getHistoricalExecution(int attemptNumber) {
+ if (isValidAttemptNumber(attemptNumber)) {
+ return Optional.ofNullable(historicalExecutions.get(attemptNumber));
+ } else {
+ throw new IllegalArgumentException("Invalid attempt number.");
+ }
+ }
+
+ public Collection<ArchivedExecution> getHistoricalExecutions() {
+ return Collections.unmodifiableCollection(historicalExecutions.values());
+ }
+
+ public boolean isValidAttemptNumber(int attemptNumber) {
+ return attemptNumber >= 0 && attemptNumber <= maxAttemptNumber;
+ }
+
+ private static class BoundedLinkedHashMap<K, V> extends LinkedHashMap<K, V> {
+ private final int sizeLimit;
+
+ private BoundedLinkedHashMap(int sizeLimit) {
+ this.sizeLimit = sizeLimit;
+ }
+
+ private BoundedLinkedHashMap(BoundedLinkedHashMap other) {
Review Comment:
OK.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionHistory.java:
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.executiongraph;
+
+import java.io.Serializable;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.Map;
+import java.util.Optional;
+
+/**
+ * This class hosts the historical executions of an {@link ExecutionVertex} in a {@link
+ * LinkedHashMap} with a size bound. When the map grows beyond the size bound, elements are dropped
+ * from the head of the map (FIFO order). Note that the historical executions does not include the
+ * current execution attempt.
+ */
+public class ExecutionHistory implements Serializable {
+
+ private static final long serialVersionUID = 1L;
+
+ private final BoundedLinkedHashMap<Integer, ArchivedExecution> historicalExecutions;
+
+ private int maxAttemptNumber;
+
+ public ExecutionHistory(int sizeLimit) {
+ super();
+ this.historicalExecutions = new BoundedLinkedHashMap(sizeLimit);
Review Comment:
Ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhoulii commented on a diff in pull request #20080: [FLINK-28258] Introduce ExecutionHistory to host historical executions for each execution vertex
Posted by GitBox <gi...@apache.org>.
zhoulii commented on code in PR #20080:
URL: https://github.com/apache/flink/pull/20080#discussion_r907160500
##########
flink-tests/src/test/java/org/apache/flink/test/runtime/DefaultSchedulerLocalRecoveryITCase.java:
##########
@@ -90,7 +90,9 @@ private void assertNonLocalRecoveredTasksEquals(ArchivedExecutionGraph graph, in
continue;
}
AllocationID priorAllocation =
- vertex.getPriorExecutionAttempt(currentAttemptNumber - 1)
+ vertex.getExecutionHistory()
+ .getHistoricalExecution(currentAttemptNumber - 1)
+ .get()
.getAssignedAllocationID();
Review Comment:
We may need to check whether the result is null.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionHistory.java:
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.executiongraph;
+
+import java.io.Serializable;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.Map;
+import java.util.Optional;
+
+/**
+ * This class hosts the historical executions of an {@link ExecutionVertex} in a {@link
+ * LinkedHashMap} with a size bound. When the map grows beyond the size bound, elements are dropped
+ * from the head of the map (FIFO order). Note that the historical executions does not include the
+ * current execution attempt.
+ */
+public class ExecutionHistory implements Serializable {
+
+ private static final long serialVersionUID = 1L;
+
+ private final BoundedLinkedHashMap<Integer, ArchivedExecution> historicalExecutions;
+
+ private int maxAttemptNumber;
+
+ public ExecutionHistory(int sizeLimit) {
+ super();
+ this.historicalExecutions = new BoundedLinkedHashMap(sizeLimit);
Review Comment:
```suggestion
this.historicalExecutions = new BoundedLinkedHashMap<>(sizeLimit);
```
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionHistory.java:
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.executiongraph;
+
+import java.io.Serializable;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.Map;
+import java.util.Optional;
+
+/**
+ * This class hosts the historical executions of an {@link ExecutionVertex} in a {@link
+ * LinkedHashMap} with a size bound. When the map grows beyond the size bound, elements are dropped
+ * from the head of the map (FIFO order). Note that the historical executions does not include the
+ * current execution attempt.
+ */
+public class ExecutionHistory implements Serializable {
+
+ private static final long serialVersionUID = 1L;
+
+ private final BoundedLinkedHashMap<Integer, ArchivedExecution> historicalExecutions;
+
+ private int maxAttemptNumber;
+
+ public ExecutionHistory(int sizeLimit) {
+ super();
+ this.historicalExecutions = new BoundedLinkedHashMap(sizeLimit);
+ this.maxAttemptNumber = -1;
+ }
+
+ ExecutionHistory(ExecutionHistory other) {
+ this.historicalExecutions = new BoundedLinkedHashMap<>(other.historicalExecutions);
+ this.maxAttemptNumber = other.maxAttemptNumber;
+ }
+
+ void add(ArchivedExecution execution) {
+ if (execution.getAttemptNumber() > maxAttemptNumber) {
+ maxAttemptNumber = execution.getAttemptNumber();
+ }
+
+ historicalExecutions.put(execution.getAttemptNumber(), execution);
+ }
+
+ public Optional<ArchivedExecution> getHistoricalExecution(int attemptNumber) {
+ if (isValidAttemptNumber(attemptNumber)) {
+ return Optional.ofNullable(historicalExecutions.get(attemptNumber));
+ } else {
+ throw new IllegalArgumentException("Invalid attempt number.");
+ }
+ }
+
+ public Collection<ArchivedExecution> getHistoricalExecutions() {
+ return Collections.unmodifiableCollection(historicalExecutions.values());
+ }
+
+ public boolean isValidAttemptNumber(int attemptNumber) {
+ return attemptNumber >= 0 && attemptNumber <= maxAttemptNumber;
+ }
+
+ private static class BoundedLinkedHashMap<K, V> extends LinkedHashMap<K, V> {
+ private final int sizeLimit;
+
+ private BoundedLinkedHashMap(int sizeLimit) {
+ this.sizeLimit = sizeLimit;
+ }
+
+ private BoundedLinkedHashMap(BoundedLinkedHashMap other) {
Review Comment:
```suggestion
private BoundedLinkedHashMap(BoundedLinkedHashMap<? extends K, ? extends V> other) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wanglijie95 commented on a diff in pull request #20080: [FLINK-28258] Introduce ExecutionHistory to host historical executions for each execution vertex
Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on code in PR #20080:
URL: https://github.com/apache/flink/pull/20080#discussion_r907258779
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java:
##########
@@ -270,16 +269,9 @@ public TaskManagerLocation getCurrentAssignedResourceLocation() {
return currentExecution.getAssignedResourceLocation();
}
- @Nullable
@Override
- public ArchivedExecution getPriorExecutionAttempt(int attemptNumber) {
- synchronized (priorExecutions) {
- if (attemptNumber >= 0 && attemptNumber < priorExecutions.size()) {
- return priorExecutions.get(attemptNumber);
- } else {
- throw new IllegalArgumentException("attempt does not exist");
- }
- }
+ public ExecutionHistory getExecutionHistory() {
+ return executionHistory;
Review Comment:
I'm not quite sure what the `synchronized` is for, is it safe to delete it?
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ArchivedExecutionVertex.java:
##########
@@ -100,13 +99,12 @@ public TaskManagerLocation getCurrentAssignedResourceLocation() {
return currentExecution.getAssignedResourceLocation();
}
- @Nullable
@Override
- public ArchivedExecution getPriorExecutionAttempt(int attemptNumber) {
- if (attemptNumber >= 0 && attemptNumber < priorExecutions.size()) {
- return priorExecutions.get(attemptNumber);
- } else {
- throw new IllegalArgumentException("attempt does not exist");
- }
+ public ExecutionHistory getExecutionHistory() {
+ return executionHistory;
+ }
+
+ static ExecutionHistory getCopyOfExecutionHistory(ExecutionVertex executionVertex) {
Review Comment:
can be private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a diff in pull request #20080: [FLINK-28258] Introduce ExecutionHistory to host historical executions for each execution vertex
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on code in PR #20080:
URL: https://github.com/apache/flink/pull/20080#discussion_r907288015
##########
flink-tests/src/test/java/org/apache/flink/test/runtime/DefaultSchedulerLocalRecoveryITCase.java:
##########
@@ -90,7 +90,9 @@ private void assertNonLocalRecoveredTasksEquals(ArchivedExecutionGraph graph, in
continue;
}
AllocationID priorAllocation =
- vertex.getPriorExecutionAttempt(currentAttemptNumber - 1)
+ vertex.getExecutionHistory()
+ .getHistoricalExecution(currentAttemptNumber - 1)
+ .get()
.getAssignedAllocationID();
Review Comment:
In my understanding, it's fine for tests. If NPE happens, it should be a production problem and I prefer to expose it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a diff in pull request #20080: [FLINK-28258] Introduce ExecutionHistory to host historical executions for each execution vertex
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on code in PR #20080:
URL: https://github.com/apache/flink/pull/20080#discussion_r907292066
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java:
##########
@@ -270,16 +269,9 @@ public TaskManagerLocation getCurrentAssignedResourceLocation() {
return currentExecution.getAssignedResourceLocation();
}
- @Nullable
@Override
- public ArchivedExecution getPriorExecutionAttempt(int attemptNumber) {
- synchronized (priorExecutions) {
- if (attemptNumber >= 0 && attemptNumber < priorExecutions.size()) {
- return priorExecutions.get(attemptNumber);
- } else {
- throw new IllegalArgumentException("attempt does not exist");
- }
- }
+ public ExecutionHistory getExecutionHistory() {
+ return executionHistory;
Review Comment:
ExecutionGraph used to be possible to be concurrently modified&accessed. Now with the new JM thread model(single-threaded of JM status access&modification), concurrency would not happen anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on pull request #20080: [FLINK-28258] Introduce ExecutionHistory to host historical executions for each execution vertex
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on PR #20080:
URL: https://github.com/apache/flink/pull/20080#issuecomment-1168193020
Thanks for the reviewing! @zhoulii @wanglijie95
Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a diff in pull request #20080: [FLINK-28258] Introduce ExecutionHistory to host historical executions for each execution vertex
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on code in PR #20080:
URL: https://github.com/apache/flink/pull/20080#discussion_r907290772
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ArchivedExecutionVertex.java:
##########
@@ -100,13 +99,12 @@ public TaskManagerLocation getCurrentAssignedResourceLocation() {
return currentExecution.getAssignedResourceLocation();
}
- @Nullable
@Override
- public ArchivedExecution getPriorExecutionAttempt(int attemptNumber) {
- if (attemptNumber >= 0 && attemptNumber < priorExecutions.size()) {
- return priorExecutions.get(attemptNumber);
- } else {
- throw new IllegalArgumentException("attempt does not exist");
- }
+ public ExecutionHistory getExecutionHistory() {
+ return executionHistory;
+ }
+
+ static ExecutionHistory getCopyOfExecutionHistory(ExecutionVertex executionVertex) {
Review Comment:
It will be used by `ArchivedSpeculativeExecutionVertex` in a latter pr(#20082), I would keep its default scope to avoid back&forth changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk closed pull request #20080: [FLINK-28258] Introduce ExecutionHistory to host historical executions for each execution vertex
Posted by GitBox <gi...@apache.org>.
zhuzhurk closed pull request #20080: [FLINK-28258] Introduce ExecutionHistory to host historical executions for each execution vertex
URL: https://github.com/apache/flink/pull/20080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org