You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tapestry.apache.org by "Jochen Kemnade (JIRA)" <ji...@apache.org> on 2014/04/26 13:25:15 UTC

[jira] [Commented] (TAP5-2293) Closure minimizer produces invalid output on non-UTF-8 systems

    [ https://issues.apache.org/jira/browse/TAP5-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981951#comment-13981951 ] 

Jochen Kemnade commented on TAP5-2293:
--------------------------------------

The patch might be wrong. We may need to use {{SymbolConstants.CHARSET}} instead. I haven't yet figured out where the response encoding header is actually set.

> Closure minimizer produces invalid output on non-UTF-8 systems
> --------------------------------------------------------------
>
>                 Key: TAP5-2293
>                 URL: https://issues.apache.org/jira/browse/TAP5-2293
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-webresources
>    Affects Versions: 5.4
>            Reporter: Jochen Kemnade
>            Assignee: Jochen Kemnade
>            Priority: Blocker
>              Labels: patch
>         Attachments: 0001-specify-encoding-when-getting-an-InputStream-from-a-.patch
>
>
> When reading the minimization result from the Closure Compiler, the String is turned into an input stream using the platform's default encoding. If that is not UTF-8, the content that is sent to the browser is probably broken.



--
This message was sent by Atlassian JIRA
(v6.2#6252)