You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hemanth Yamijala (JIRA)" <ji...@apache.org> on 2008/08/20 08:53:30 UTC
[jira] Created: (HADOOP-3975) test-patch can report the
modifications found in the workspace along with the error message
test-patch can report the modifications found in the workspace along with the error message
-------------------------------------------------------------------------------------------
Key: HADOOP-3975
URL: https://issues.apache.org/jira/browse/HADOOP-3975
Project: Hadoop Core
Issue Type: Improvement
Components: build
Reporter: Hemanth Yamijala
Priority: Minor
When test-patch is run on a developer workspace which contains modifications, it errors out by saying "ERROR: can't run in a workspace that contains modifications". It appears this is printed when svn stat command returns a non-empty output. It would be helpful to report this output, so that developers can be alerted to what modifications are causing this error. Sometimes these modifications may not be because of a direct code change they've done, but remnants of an incorrect cleanup of the last build, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3975) test-patch can report the
modifications found in the workspace along with the error message
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3975:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Rayma
> test-patch can report the modifications found in the workspace along with the error message
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-3975
> URL: https://issues.apache.org/jira/browse/HADOOP-3975
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Hemanth Yamijala
> Assignee: Ramya R
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: hadoop-3975-v1.txt, Hadoop-3975-v2.txt, hadoop-3975.txt, test-patch1.txt
>
>
> When test-patch is run on a developer workspace which contains modifications, it errors out by saying "ERROR: can't run in a workspace that contains modifications". It appears this is printed when svn stat command returns a non-empty output. It would be helpful to report this output, so that developers can be alerted to what modifications are causing this error. Sometimes these modifications may not be because of a direct code change they've done, but remnants of an incorrect cleanup of the last build, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3975) test-patch can report the
modifications found in the workspace along with the error message
Posted by "Ramya R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramya R updated HADOOP-3975:
----------------------------
Status: Patch Available (was: Open)
> test-patch can report the modifications found in the workspace along with the error message
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-3975
> URL: https://issues.apache.org/jira/browse/HADOOP-3975
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Hemanth Yamijala
> Assignee: Ramya R
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: hadoop-3975-v1.txt, hadoop-3975.txt, test-patch1.txt
>
>
> When test-patch is run on a developer workspace which contains modifications, it errors out by saying "ERROR: can't run in a workspace that contains modifications". It appears this is printed when svn stat command returns a non-empty output. It would be helpful to report this output, so that developers can be alerted to what modifications are causing this error. Sometimes these modifications may not be because of a direct code change they've done, but remnants of an incorrect cleanup of the last build, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3975) test-patch can report the
modifications found in the workspace along with the error message
Posted by "Ramya R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramya R updated HADOOP-3975:
----------------------------
Attachment: hadoop-3975.txt
Running "$SVN stat" only once and storing the result as suggested by Vinod.
> test-patch can report the modifications found in the workspace along with the error message
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-3975
> URL: https://issues.apache.org/jira/browse/HADOOP-3975
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Hemanth Yamijala
> Priority: Minor
> Attachments: hadoop-3975.txt, test-patch1.txt
>
>
> When test-patch is run on a developer workspace which contains modifications, it errors out by saying "ERROR: can't run in a workspace that contains modifications". It appears this is printed when svn stat command returns a non-empty output. It would be helpful to report this output, so that developers can be alerted to what modifications are causing this error. Sometimes these modifications may not be because of a direct code change they've done, but remnants of an incorrect cleanup of the last build, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3975) test-patch can report the
modifications found in the workspace along with the error message
Posted by "Ramya R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramya R updated HADOOP-3975:
----------------------------
Status: Patch Available (was: Open)
> test-patch can report the modifications found in the workspace along with the error message
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-3975
> URL: https://issues.apache.org/jira/browse/HADOOP-3975
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Hemanth Yamijala
> Priority: Minor
> Attachments: test-patch1.txt
>
>
> When test-patch is run on a developer workspace which contains modifications, it errors out by saying "ERROR: can't run in a workspace that contains modifications". It appears this is printed when svn stat command returns a non-empty output. It would be helpful to report this output, so that developers can be alerted to what modifications are causing this error. Sometimes these modifications may not be because of a direct code change they've done, but remnants of an incorrect cleanup of the last build, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3975) test-patch can report the
modifications found in the workspace along with the error message
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625577#action_12625577 ]
Hadoop QA commented on HADOOP-3975:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12388833/hadoop-3975.txt
against trunk revision 688923.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3098/console
This message is automatically generated.
> test-patch can report the modifications found in the workspace along with the error message
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-3975
> URL: https://issues.apache.org/jira/browse/HADOOP-3975
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Hemanth Yamijala
> Priority: Minor
> Attachments: hadoop-3975.txt, test-patch1.txt
>
>
> When test-patch is run on a developer workspace which contains modifications, it errors out by saying "ERROR: can't run in a workspace that contains modifications". It appears this is printed when svn stat command returns a non-empty output. It would be helpful to report this output, so that developers can be alerted to what modifications are causing this error. Sometimes these modifications may not be because of a direct code change they've done, but remnants of an incorrect cleanup of the last build, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3975) test-patch can report the
modifications found in the workspace along with the error message
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630162#action_12630162 ]
Enis Soztutar commented on HADOOP-3975:
---------------------------------------
I think, test-patch should be able to run in an environment where svn stat != "". Specifically a requirement arises when we are adding a new lib, and to run the audit checks we put the lib in trunk.
I think we should either use [`$SVN stat | grep -v "?"` != "" ], or better switch to a binary diff-patch process.
> test-patch can report the modifications found in the workspace along with the error message
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-3975
> URL: https://issues.apache.org/jira/browse/HADOOP-3975
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Hemanth Yamijala
> Assignee: Ramya R
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: hadoop-3975-v1.txt, hadoop-3975.txt, test-patch1.txt
>
>
> When test-patch is run on a developer workspace which contains modifications, it errors out by saying "ERROR: can't run in a workspace that contains modifications". It appears this is printed when svn stat command returns a non-empty output. It would be helpful to report this output, so that developers can be alerted to what modifications are causing this error. Sometimes these modifications may not be because of a direct code change they've done, but remnants of an incorrect cleanup of the last build, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3975) test-patch can report the
modifications found in the workspace along with the error message
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-3975:
--------------------------------
Assignee: Ramya R
Status: Open (was: Patch Available)
Ramya, please submit an updated patch that applies.
Thanks!
> test-patch can report the modifications found in the workspace along with the error message
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-3975
> URL: https://issues.apache.org/jira/browse/HADOOP-3975
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Hemanth Yamijala
> Assignee: Ramya R
> Priority: Minor
> Attachments: hadoop-3975.txt, test-patch1.txt
>
>
> When test-patch is run on a developer workspace which contains modifications, it errors out by saying "ERROR: can't run in a workspace that contains modifications". It appears this is printed when svn stat command returns a non-empty output. It would be helpful to report this output, so that developers can be alerted to what modifications are causing this error. Sometimes these modifications may not be because of a direct code change they've done, but remnants of an incorrect cleanup of the last build, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3975) test-patch can report the
modifications found in the workspace along with the error message
Posted by "Ramya R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramya R updated HADOOP-3975:
----------------------------
Attachment: test-patch1.txt
> test-patch can report the modifications found in the workspace along with the error message
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-3975
> URL: https://issues.apache.org/jira/browse/HADOOP-3975
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Hemanth Yamijala
> Priority: Minor
> Attachments: test-patch1.txt
>
>
> When test-patch is run on a developer workspace which contains modifications, it errors out by saying "ERROR: can't run in a workspace that contains modifications". It appears this is printed when svn stat command returns a non-empty output. It would be helpful to report this output, so that developers can be alerted to what modifications are causing this error. Sometimes these modifications may not be because of a direct code change they've done, but remnants of an incorrect cleanup of the last build, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3975) test-patch can report the
modifications found in the workspace along with the error message
Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624615#action_12624615 ]
Vinod Kumar Vavilapalli commented on HADOOP-3975:
-------------------------------------------------
Minor comment. You could store the output of "$SVN stat" in a variable and use it, instead of running it two times.
> test-patch can report the modifications found in the workspace along with the error message
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-3975
> URL: https://issues.apache.org/jira/browse/HADOOP-3975
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Hemanth Yamijala
> Priority: Minor
> Attachments: test-patch1.txt
>
>
> When test-patch is run on a developer workspace which contains modifications, it errors out by saying "ERROR: can't run in a workspace that contains modifications". It appears this is printed when svn stat command returns a non-empty output. It would be helpful to report this output, so that developers can be alerted to what modifications are causing this error. Sometimes these modifications may not be because of a direct code change they've done, but remnants of an incorrect cleanup of the last build, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3975) test-patch can report the
modifications found in the workspace along with the error message
Posted by "Ramya R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramya R updated HADOOP-3975:
----------------------------
Attachment: hadoop-3975-v1.txt
Updated patch submitted.
> test-patch can report the modifications found in the workspace along with the error message
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-3975
> URL: https://issues.apache.org/jira/browse/HADOOP-3975
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Hemanth Yamijala
> Assignee: Ramya R
> Priority: Minor
> Attachments: hadoop-3975-v1.txt, hadoop-3975.txt, test-patch1.txt
>
>
> When test-patch is run on a developer workspace which contains modifications, it errors out by saying "ERROR: can't run in a workspace that contains modifications". It appears this is printed when svn stat command returns a non-empty output. It would be helpful to report this output, so that developers can be alerted to what modifications are causing this error. Sometimes these modifications may not be because of a direct code change they've done, but remnants of an incorrect cleanup of the last build, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3975) test-patch can report the
modifications found in the workspace along with the error message
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627564#action_12627564 ]
Hadoop QA commented on HADOOP-3975:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12389266/hadoop-3975-v1.txt
against trunk revision 691055.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3153/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3153/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3153/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3153/console
This message is automatically generated.
> test-patch can report the modifications found in the workspace along with the error message
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-3975
> URL: https://issues.apache.org/jira/browse/HADOOP-3975
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Hemanth Yamijala
> Assignee: Ramya R
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: hadoop-3975-v1.txt, hadoop-3975.txt, test-patch1.txt
>
>
> When test-patch is run on a developer workspace which contains modifications, it errors out by saying "ERROR: can't run in a workspace that contains modifications". It appears this is printed when svn stat command returns a non-empty output. It would be helpful to report this output, so that developers can be alerted to what modifications are causing this error. Sometimes these modifications may not be because of a direct code change they've done, but remnants of an incorrect cleanup of the last build, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3975) test-patch can report the
modifications found in the workspace along with the error message
Posted by "Ramya R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramya R updated HADOOP-3975:
----------------------------
Component/s: (was: build)
test
Fix Version/s: 0.19.0
> test-patch can report the modifications found in the workspace along with the error message
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-3975
> URL: https://issues.apache.org/jira/browse/HADOOP-3975
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Hemanth Yamijala
> Assignee: Ramya R
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: hadoop-3975-v1.txt, hadoop-3975.txt, test-patch1.txt
>
>
> When test-patch is run on a developer workspace which contains modifications, it errors out by saying "ERROR: can't run in a workspace that contains modifications". It appears this is printed when svn stat command returns a non-empty output. It would be helpful to report this output, so that developers can be alerted to what modifications are causing this error. Sometimes these modifications may not be because of a direct code change they've done, but remnants of an incorrect cleanup of the last build, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3975) test-patch can report the
modifications found in the workspace along with the error message
Posted by "Ramya R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramya R updated HADOOP-3975:
----------------------------
Attachment: Hadoop-3975-v2.txt
Incorporating Chris's comments. Uploading the new patch.
> test-patch can report the modifications found in the workspace along with the error message
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-3975
> URL: https://issues.apache.org/jira/browse/HADOOP-3975
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Hemanth Yamijala
> Assignee: Ramya R
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: hadoop-3975-v1.txt, Hadoop-3975-v2.txt, hadoop-3975.txt, test-patch1.txt
>
>
> When test-patch is run on a developer workspace which contains modifications, it errors out by saying "ERROR: can't run in a workspace that contains modifications". It appears this is printed when svn stat command returns a non-empty output. It would be helpful to report this output, so that developers can be alerted to what modifications are causing this error. Sometimes these modifications may not be because of a direct code change they've done, but remnants of an incorrect cleanup of the last build, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3975) test-patch can report the
modifications found in the workspace along with the error message
Posted by "Ramya R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632097#action_12632097 ]
Ramya R commented on HADOOP-3975:
---------------------------------
Ran test-patch locally, here are the results:
[exec] +1 overall.
[exec] +1 @author. The patch does not contain any @author tags.
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
> test-patch can report the modifications found in the workspace along with the error message
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-3975
> URL: https://issues.apache.org/jira/browse/HADOOP-3975
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Hemanth Yamijala
> Assignee: Ramya R
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: hadoop-3975-v1.txt, Hadoop-3975-v2.txt, hadoop-3975.txt, test-patch1.txt
>
>
> When test-patch is run on a developer workspace which contains modifications, it errors out by saying "ERROR: can't run in a workspace that contains modifications". It appears this is printed when svn stat command returns a non-empty output. It would be helpful to report this output, so that developers can be alerted to what modifications are causing this error. Sometimes these modifications may not be because of a direct code change they've done, but remnants of an incorrect cleanup of the last build, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3975) test-patch can report the
modifications found in the workspace along with the error message
Posted by "Ramya R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624567#action_12624567 ]
Ramya R commented on HADOOP-3975:
---------------------------------
Seems a reasonable thing to do. Uploading the patch.
> test-patch can report the modifications found in the workspace along with the error message
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-3975
> URL: https://issues.apache.org/jira/browse/HADOOP-3975
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Hemanth Yamijala
> Priority: Minor
> Attachments: test-patch1.txt
>
>
> When test-patch is run on a developer workspace which contains modifications, it errors out by saying "ERROR: can't run in a workspace that contains modifications". It appears this is printed when svn stat command returns a non-empty output. It would be helpful to report this output, so that developers can be alerted to what modifications are causing this error. Sometimes these modifications may not be because of a direct code change they've done, but remnants of an incorrect cleanup of the last build, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3975) test-patch can report the
modifications found in the workspace along with the error message
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633294#action_12633294 ]
Hudson commented on HADOOP-3975:
--------------------------------
Integrated in Hadoop-trunk #611 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/611/])
> test-patch can report the modifications found in the workspace along with the error message
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-3975
> URL: https://issues.apache.org/jira/browse/HADOOP-3975
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Hemanth Yamijala
> Assignee: Ramya R
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: hadoop-3975-v1.txt, Hadoop-3975-v2.txt, hadoop-3975.txt, test-patch1.txt
>
>
> When test-patch is run on a developer workspace which contains modifications, it errors out by saying "ERROR: can't run in a workspace that contains modifications". It appears this is printed when svn stat command returns a non-empty output. It would be helpful to report this output, so that developers can be alerted to what modifications are causing this error. Sometimes these modifications may not be because of a direct code change they've done, but remnants of an incorrect cleanup of the last build, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3975) test-patch can report the
modifications found in the workspace along with the error message
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627559#action_12627559 ]
Chris Douglas commented on HADOOP-3975:
---------------------------------------
Shouldn't test-patch return non-zero in this case?
> test-patch can report the modifications found in the workspace along with the error message
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-3975
> URL: https://issues.apache.org/jira/browse/HADOOP-3975
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Hemanth Yamijala
> Assignee: Ramya R
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: hadoop-3975-v1.txt, hadoop-3975.txt, test-patch1.txt
>
>
> When test-patch is run on a developer workspace which contains modifications, it errors out by saying "ERROR: can't run in a workspace that contains modifications". It appears this is printed when svn stat command returns a non-empty output. It would be helpful to report this output, so that developers can be alerted to what modifications are causing this error. Sometimes these modifications may not be because of a direct code change they've done, but remnants of an incorrect cleanup of the last build, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3975) test-patch can report the
modifications found in the workspace along with the error message
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630730#action_12630730 ]
Nigel Daley commented on HADOOP-3975:
-------------------------------------
I think Chris is right, it should return non-zero. Ramya, can you update the patch?
Enis, regarding your comments, please file a new Jira. I think this patch makes the current system a little better. Your suggestion may require a much bigger change.
> test-patch can report the modifications found in the workspace along with the error message
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-3975
> URL: https://issues.apache.org/jira/browse/HADOOP-3975
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Hemanth Yamijala
> Assignee: Ramya R
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: hadoop-3975-v1.txt, hadoop-3975.txt, test-patch1.txt
>
>
> When test-patch is run on a developer workspace which contains modifications, it errors out by saying "ERROR: can't run in a workspace that contains modifications". It appears this is printed when svn stat command returns a non-empty output. It would be helpful to report this output, so that developers can be alerted to what modifications are causing this error. Sometimes these modifications may not be because of a direct code change they've done, but remnants of an incorrect cleanup of the last build, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.