[GitHub] [orc] wgtmac commented on a diff in pull request #1299: ORC-1304: [C++] Fix bug of seeking over empty PRESENT stream

[GitBox <gi...@apache.org>]

wgtmac commented on code in PR #1299:
URL: https://github.com/apache/orc/pull/1299#discussion_r1010493186


##########
c++/test/TestPredicatePushdown.cc:
##########
@@ -557,4 +557,103 @@ namespace orc {
       TestFirstStripeSelectedWithStripeStats(reader.get(), pos);
     }
   }
+
+  TEST(TestPredicatePushdown, testSeekOverEmptyPresentStream) {

Review Comment:
   nit: the bug has nothing to do with predicate pushdown, we'd better move it out of here.



##########
c++/test/TestWriter.cc:
##########
@@ -2044,103 +2044,5 @@ namespace orc {
     testSuppressPresentStream(CompressionKind_SNAPPY);
   }
 
-  TEST(WriterTest, testSeekWithNestedType) {

Review Comment:
   Why is it removed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org