You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/15 07:32:38 UTC

[GitHub] [flink] zjuwangg opened a new pull request #11748: [FLINK-17152]fix wrong Aggfunction resultType and accType in FunctionDefinitionUtil

zjuwangg opened a new pull request #11748: [FLINK-17152]fix wrong Aggfunction resultType and accType in FunctionDefinitionUtil
URL: https://github.com/apache/flink/pull/11748
 
 
   ## What is the purpose of the change
   
   * In [FLINK-16414](https://github.com/apache/flink/pull/11302), I fixed the problem that using using udaf/udtf which doesn't implement getResultType, but also introduce this problem careless. This pr aims to solve aggregate function can not get correct return type.
   
   ## Brief change log
   
     - #9ed7dbb fix bug and add corresponding unit test.
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - *Added more unit tests in FunctionDefinitionUtilTest*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no )
     - The runtime per-record code paths (performance sensitive): (no )
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zjuwangg commented on issue #11748: [FLINK-17152]fix wrong Aggfunction resultType and accType in FunctionDefinitionUtil

Posted by GitBox <gi...@apache.org>.
zjuwangg commented on issue #11748: [FLINK-17152]fix wrong Aggfunction resultType and accType in FunctionDefinitionUtil
URL: https://github.com/apache/flink/pull/11748#issuecomment-613870106
 
 
   cc @KurtYoung @wuchong @bowenli86 to have a review when you are free. I think this bug should be in release 1.10.1 too. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11748: [FLINK-17152]fix wrong Aggfunction resultType and accType in FunctionDefinitionUtil

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11748: [FLINK-17152]fix wrong Aggfunction resultType and accType in FunctionDefinitionUtil
URL: https://github.com/apache/flink/pull/11748#issuecomment-613878009
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9ed7dbb1ef92c536b3a81d68bc0afe5792d83261",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7497",
       "triggerID" : "9ed7dbb1ef92c536b3a81d68bc0afe5792d83261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9ed7dbb1ef92c536b3a81d68bc0afe5792d83261",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160338442",
       "triggerID" : "9ed7dbb1ef92c536b3a81d68bc0afe5792d83261",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9ed7dbb1ef92c536b3a81d68bc0afe5792d83261 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160338442) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7497) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zjuwangg commented on issue #11748: [FLINK-17152]fix wrong Aggfunction resultType and accType in FunctionDefinitionUtil

Posted by GitBox <gi...@apache.org>.
zjuwangg commented on issue #11748: [FLINK-17152]fix wrong Aggfunction resultType and accType in FunctionDefinitionUtil
URL: https://github.com/apache/flink/pull/11748#issuecomment-614399852
 
 
   cc @JingsongLi to have a review too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11748: [FLINK-17152]fix wrong Aggfunction resultType and accType in FunctionDefinitionUtil

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11748: [FLINK-17152]fix wrong Aggfunction resultType and accType in FunctionDefinitionUtil
URL: https://github.com/apache/flink/pull/11748#issuecomment-613878009
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9ed7dbb1ef92c536b3a81d68bc0afe5792d83261",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7497",
       "triggerID" : "9ed7dbb1ef92c536b3a81d68bc0afe5792d83261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9ed7dbb1ef92c536b3a81d68bc0afe5792d83261",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160338442",
       "triggerID" : "9ed7dbb1ef92c536b3a81d68bc0afe5792d83261",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9ed7dbb1ef92c536b3a81d68bc0afe5792d83261 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160338442) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7497) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong merged pull request #11748: [FLINK-17152]fix wrong Aggfunction resultType and accType in FunctionDefinitionUtil

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #11748: [FLINK-17152]fix wrong Aggfunction resultType and accType in FunctionDefinitionUtil
URL: https://github.com/apache/flink/pull/11748
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11748: [FLINK-17152]fix wrong Aggfunction resultType and accType in FunctionDefinitionUtil

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11748: [FLINK-17152]fix wrong Aggfunction resultType and accType in FunctionDefinitionUtil
URL: https://github.com/apache/flink/pull/11748#issuecomment-613869781
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 9ed7dbb1ef92c536b3a81d68bc0afe5792d83261 (Wed Apr 15 07:34:39 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17152).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zjuwangg commented on issue #11748: [FLINK-17152]fix wrong Aggfunction resultType and accType in FunctionDefinitionUtil

Posted by GitBox <gi...@apache.org>.
zjuwangg commented on issue #11748: [FLINK-17152]fix wrong Aggfunction resultType and accType in FunctionDefinitionUtil
URL: https://github.com/apache/flink/pull/11748#issuecomment-614404606
 
 
   Thanks @wuchong 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11748: [FLINK-17152]fix wrong Aggfunction resultType and accType in FunctionDefinitionUtil

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11748: [FLINK-17152]fix wrong Aggfunction resultType and accType in FunctionDefinitionUtil
URL: https://github.com/apache/flink/pull/11748#issuecomment-613878009
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9ed7dbb1ef92c536b3a81d68bc0afe5792d83261",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7497",
       "triggerID" : "9ed7dbb1ef92c536b3a81d68bc0afe5792d83261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9ed7dbb1ef92c536b3a81d68bc0afe5792d83261",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160338442",
       "triggerID" : "9ed7dbb1ef92c536b3a81d68bc0afe5792d83261",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9ed7dbb1ef92c536b3a81d68bc0afe5792d83261 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160338442) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7497) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11748: [FLINK-17152]fix wrong Aggfunction resultType and accType in FunctionDefinitionUtil

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11748: [FLINK-17152]fix wrong Aggfunction resultType and accType in FunctionDefinitionUtil
URL: https://github.com/apache/flink/pull/11748#issuecomment-613878009
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9ed7dbb1ef92c536b3a81d68bc0afe5792d83261",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9ed7dbb1ef92c536b3a81d68bc0afe5792d83261",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9ed7dbb1ef92c536b3a81d68bc0afe5792d83261 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services