You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/05/03 21:01:37 UTC

[GitHub] [superset] michael-s-molina commented on pull request #23908: fix(sqllab): clean comments within quotes

michael-s-molina commented on PR #23908:
URL: https://github.com/apache/superset/pull/23908#issuecomment-1533743757

   > @justinpark @michael-s-molina @ktmud we have a fair deal of logic for this in the backend - is there some reason we want to parse for this kind of stuff in the frontend? It feels like we should centralize this in one place.
   
   I didn't know about that @villebro. Could you point to the code? I agree that if there's no reason for doing it in the frontend, we should centralize it in the backend.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org