You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2015/11/04 19:39:03 UTC
Review Request 39946: Moved definition of ctors and dtors for mock
classes out of header file.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39946/
-----------------------------------------------------------
Review request for mesos and Joris Van Remoortere.
Bugs: MESOS-3827
https://issues.apache.org/jira/browse/MESOS-3827
Repository: mesos
Description
-------
As discussed in MESOS-3827, this can improve compilation time of classes that
use GMock. On my system, this improves the compilation time of the unit tests by
about 8%.
Note that we can't use this technique with TestAllocator, because it is
templatized.
Diffs
-----
src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db
src/tests/containerizer/launcher.hpp 5d34bab789bdafe71d94e8ec263710c50b83e180
src/tests/containerizer/launcher.cpp PRE-CREATION
src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217
src/tests/mesos.cpp ab2d85b091d121113931e4190a5b496901dcd7a5
Diff: https://reviews.apache.org/r/39946/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 39946: Moved definition of ctors and dtors for mock
classes out of header file.
Posted by Neil Conway <ne...@gmail.com>.
> On Nov. 5, 2015, 12:08 a.m., Ben Mahler wrote:
> > src/tests/mesos.cpp, line 447
> > <https://reviews.apache.org/r/39946/diff/1/?file=1115773#file1115773line447>
> >
> > We tend to avoid abbreviations (like ctor, dtor):
> >
> > ```
> > ? mesos git:(master) ? grep -R destructor src | wc -l
> > 22
> > ? mesos git:(master) ? grep -R dtor src | wc -l
> > 0
> > ```
Thanks! Fixed.
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39946/#review105181
-----------------------------------------------------------
On Nov. 5, 2015, 12:56 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39946/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2015, 12:56 a.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3827
> https://issues.apache.org/jira/browse/MESOS-3827
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As discussed in MESOS-3827, this can improve compilation time of classes that
> use GMock. On my system, this improves the compilation time of the unit tests by
> about 8%.
>
> Note that we can't use this technique with TestAllocator, because it is
> templatized.
>
>
> Diffs
> -----
>
> src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db
> src/tests/containerizer/launcher.hpp 5d34bab789bdafe71d94e8ec263710c50b83e180
> src/tests/containerizer/launcher.cpp PRE-CREATION
> src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217
> src/tests/mesos.cpp ab2d85b091d121113931e4190a5b496901dcd7a5
>
> Diff: https://reviews.apache.org/r/39946/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 39946: Moved definition of ctors and dtors for mock
classes out of header file.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39946/#review105181
-----------------------------------------------------------
src/tests/mesos.cpp (line 447)
<https://reviews.apache.org/r/39946/#comment163604>
We tend to avoid abbreviations (like ctor, dtor):
```
? mesos git:(master) ? grep -R destructor src | wc -l
22
? mesos git:(master) ? grep -R dtor src | wc -l
0
```
- Ben Mahler
On Nov. 4, 2015, 6:39 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39946/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 6:39 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3827
> https://issues.apache.org/jira/browse/MESOS-3827
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As discussed in MESOS-3827, this can improve compilation time of classes that
> use GMock. On my system, this improves the compilation time of the unit tests by
> about 8%.
>
> Note that we can't use this technique with TestAllocator, because it is
> templatized.
>
>
> Diffs
> -----
>
> src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db
> src/tests/containerizer/launcher.hpp 5d34bab789bdafe71d94e8ec263710c50b83e180
> src/tests/containerizer/launcher.cpp PRE-CREATION
> src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217
> src/tests/mesos.cpp ab2d85b091d121113931e4190a5b496901dcd7a5
>
> Diff: https://reviews.apache.org/r/39946/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 39946: Moved definition of ctors and dtors for mock
classes out of header file.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39946/#review108010
-----------------------------------------------------------
Ship it!
src/Makefile.am (line 1740)
<https://reviews.apache.org/r/39946/#comment167383>
alignment.
src/tests/containerizer/launcher.cpp (line 46)
<https://reviews.apache.org/r/39946/#comment167379>
indentation.
src/tests/mesos.cpp (lines 463 - 473)
<https://reviews.apache.org/r/39946/#comment167374>
indentation.
src/tests/mesos.cpp (lines 482 - 490)
<https://reviews.apache.org/r/39946/#comment167375>
indentation.
src/tests/mesos.cpp (lines 498 - 507)
<https://reviews.apache.org/r/39946/#comment167376>
indentation.
src/tests/mesos.cpp (lines 634 - 637)
<https://reviews.apache.org/r/39946/#comment167378>
indentation.
- Joris Van Remoortere
On Nov. 23, 2015, 5:10 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39946/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 5:10 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3827
> https://issues.apache.org/jira/browse/MESOS-3827
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As discussed in MESOS-3827, this can improve compilation time of classes that
> use GMock. On my system, this improves the compilation time of the unit tests by
> about 8%.
>
> Note that we can't use this technique with TestAllocator, because it is
> templatized.
>
>
> Diffs
> -----
>
> src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b
> src/tests/containerizer/launcher.hpp 09c4ba29d6240a3fbc132d82733d7df7b28e00a1
> src/tests/containerizer/launcher.cpp PRE-CREATION
> src/tests/mesos.hpp a2a76f55f9a4091cccfccd9672c2d2897b34ddcd
> src/tests/mesos.cpp b2211d59ed571ec8ddc132f69ed1cf5da9eeef10
>
> Diff: https://reviews.apache.org/r/39946/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 39946: Moved definition of ctors and dtors for mock
classes out of header file.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39946/
-----------------------------------------------------------
(Updated Nov. 23, 2015, 5:10 p.m.)
Review request for mesos and Joris Van Remoortere.
Changes
-------
Rebase.
Bugs: MESOS-3827
https://issues.apache.org/jira/browse/MESOS-3827
Repository: mesos
Description
-------
As discussed in MESOS-3827, this can improve compilation time of classes that
use GMock. On my system, this improves the compilation time of the unit tests by
about 8%.
Note that we can't use this technique with TestAllocator, because it is
templatized.
Diffs (updated)
-----
src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b
src/tests/containerizer/launcher.hpp 09c4ba29d6240a3fbc132d82733d7df7b28e00a1
src/tests/containerizer/launcher.cpp PRE-CREATION
src/tests/mesos.hpp a2a76f55f9a4091cccfccd9672c2d2897b34ddcd
src/tests/mesos.cpp b2211d59ed571ec8ddc132f69ed1cf5da9eeef10
Diff: https://reviews.apache.org/r/39946/diff/
Testing
-------
make check
Thanks,
Neil Conway
Re: Review Request 39946: Moved definition of ctors and dtors for mock
classes out of header file.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39946/
-----------------------------------------------------------
(Updated Nov. 14, 2015, 3:11 a.m.)
Review request for mesos and Joris Van Remoortere.
Changes
-------
Whitespace fix.
Bugs: MESOS-3827
https://issues.apache.org/jira/browse/MESOS-3827
Repository: mesos
Description
-------
As discussed in MESOS-3827, this can improve compilation time of classes that
use GMock. On my system, this improves the compilation time of the unit tests by
about 8%.
Note that we can't use this technique with TestAllocator, because it is
templatized.
Diffs (updated)
-----
src/Makefile.am 92d07c3da897c7664c63e2af91d45921d66f64aa
src/tests/containerizer/launcher.hpp f587dda7a2a968f96acb8cb316fd4079d37d9ca2
src/tests/containerizer/launcher.cpp PRE-CREATION
src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed
src/tests/mesos.cpp 5667e961fe70d15defbb127c174e91376ca9de3d
Diff: https://reviews.apache.org/r/39946/diff/
Testing (updated)
-------
make check
Thanks,
Neil Conway
Re: Review Request 39946: Moved definition of ctors and dtors for mock
classes out of header file.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39946/
-----------------------------------------------------------
(Updated Nov. 14, 2015, 3:04 a.m.)
Review request for mesos and Joris Van Remoortere.
Changes
-------
Rebase.
Bugs: MESOS-3827
https://issues.apache.org/jira/browse/MESOS-3827
Repository: mesos
Description
-------
As discussed in MESOS-3827, this can improve compilation time of classes that
use GMock. On my system, this improves the compilation time of the unit tests by
about 8%.
Note that we can't use this technique with TestAllocator, because it is
templatized.
Diffs (updated)
-----
src/Makefile.am 92d07c3da897c7664c63e2af91d45921d66f64aa
src/tests/containerizer/launcher.hpp f587dda7a2a968f96acb8cb316fd4079d37d9ca2
src/tests/containerizer/launcher.cpp PRE-CREATION
src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed
src/tests/mesos.cpp 5667e961fe70d15defbb127c174e91376ca9de3d
Diff: https://reviews.apache.org/r/39946/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 39946: Moved definition of ctors and dtors for mock
classes out of header file.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39946/
-----------------------------------------------------------
(Updated Nov. 5, 2015, 12:56 a.m.)
Review request for mesos and Joris Van Remoortere.
Changes
-------
Fix ctor/dtor per BenM.
Bugs: MESOS-3827
https://issues.apache.org/jira/browse/MESOS-3827
Repository: mesos
Description
-------
As discussed in MESOS-3827, this can improve compilation time of classes that
use GMock. On my system, this improves the compilation time of the unit tests by
about 8%.
Note that we can't use this technique with TestAllocator, because it is
templatized.
Diffs (updated)
-----
src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db
src/tests/containerizer/launcher.hpp 5d34bab789bdafe71d94e8ec263710c50b83e180
src/tests/containerizer/launcher.cpp PRE-CREATION
src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217
src/tests/mesos.cpp ab2d85b091d121113931e4190a5b496901dcd7a5
Diff: https://reviews.apache.org/r/39946/diff/
Testing
-------
Thanks,
Neil Conway