You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/11/03 02:09:35 UTC

[GitHub] [iotdb] liuminghui233 edited a comment on pull request #4234: [IOTDB-1280] Solve the performance reduction caused by syntax error in SLL prediction mode

liuminghui233 edited a comment on pull request #4234:
URL: https://github.com/apache/iotdb/pull/4234#issuecomment-958598635


   > @liuminghui233 Hi, I have some changes on the ANTLR part. And I am wondering about the way you find the causes of the performance issue. Could you explain a little bit?
   > 
   > Thanks!
   
   Hi, you can refer to this [blog](https://tomassetti.me/improving-the-performance-of-an-antlr-parser) to learn more about the performance of Antlr4. Before merging your PR, you can experiment with the parsing performance of some critical statements (such as insert and query statements). Good luck!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org