[GitHub] [arrow] AlvinJ15 commented on a change in pull request #11759: ARROW-14748: [C++] Fix issue on replace with mask for null values

[GitBox <gi...@apache.org>]

AlvinJ15 commented on a change in pull request #11759:
URL: https://github.com/apache/arrow/pull/11759#discussion_r755641465



##########
File path: cpp/src/arrow/compute/kernels/vector_replace.cc
##########
@@ -73,6 +73,10 @@ struct CopyArrayBitmap {
   const uint8_t* in_bitmap;
   int64_t in_offset;
 
+  const uint8_t* GetInBitmap() const {
+    return in_bitmap;
+  }
+

Review comment:
       I add this because the CopyBitmap is a template with  typename for this struct and can't acces to the in_bitmap property.

##########
File path: cpp/src/arrow/compute/kernels/vector_replace.cc
##########
@@ -96,6 +108,10 @@ struct CopyScalarBitmap {
   void SetBit(uint8_t* out_bitmap, int64_t out_offset, int64_t offset) const {
     BitUtil::SetBitTo(out_bitmap, out_offset, is_valid);
   }
+
+  void SetBitTrue(uint8_t* out_bitmap, int64_t out_offset, int64_t offset) const {
+    BitUtil::SetBitTo(out_bitmap, out_offset, true);
+  }

Review comment:
       solved




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org