You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/05 18:01:27 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7529: Fix some configure error in Windows native build
xiaoxiang781216 commented on code in PR #7529:
URL: https://github.com/apache/incubator-nuttx/pull/7529#discussion_r1014672295
##########
tools/Config.mk:
##########
@@ -523,12 +523,18 @@ ifeq ($(CONFIG_ARCH_COVERAGE),y)
endif
ifeq ($(CONFIG_WINDOWS_NATIVE),y)
+
+define NEWLINE
+
+
+endef
+
define CLEAN
$(Q) if exist *$(OBJEXT) (del /f /q *$(OBJEXT))
$(Q) if exist *$(LIBEXT) (del /f /q *$(LIBEXT))
$(Q) if exist *~ (del /f /q *~)
$(Q) if exist (del /f /q .*.swp)
- $(Q) if exist $(OBJS) (del /f /q $(OBJS))
+ $(foreach OBJ, $(OBJS), $(NEWLINE) $(call DELFILE,$(OBJ)))
Review Comment:
why not call del like before?
##########
tools/Config.mk:
##########
@@ -523,12 +523,18 @@ ifeq ($(CONFIG_ARCH_COVERAGE),y)
endif
ifeq ($(CONFIG_WINDOWS_NATIVE),y)
+
+define NEWLINE
Review Comment:
why need append NEWLINE to the command?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org