You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Devaraj K (JIRA)" <ji...@apache.org> on 2011/05/31 07:40:47 UTC
[jira] [Created] (MAPREDUCE-2548) Log improvements in
DBOutputFormat.java and CounterGroup.java
Log improvements in DBOutputFormat.java and CounterGroup.java
-------------------------------------------------------------
Key: MAPREDUCE-2548
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2548
Project: Hadoop Map/Reduce
Issue Type: Improvement
Reporter: Devaraj K
Assignee: Devaraj K
1. Instead of the printing the stack trace on the console, It can be logged.
{code:title=DBOutputFormat.java|borderStyle=solid}
public void write(K key, V value) throws IOException {
try {
key.write(statement);
statement.addBatch();
} catch (SQLException e) {
e.printStackTrace();
}
}
{code}
2. Missing resource information can be logged.
{code:title=CounterGroup .java|borderStyle=solid}
protected CounterGroup(String name) {
this.name = name;
try {
bundle = getResourceBundle(name);
}
catch (MissingResourceException neverMind) {
}
displayName = localize("CounterGroupName", name);
}
private String localize(String key, String defaultValue) {
String result = defaultValue;
if (bundle != null) {
try {
result = bundle.getString(key);
}
catch (MissingResourceException mre) {
}
}
return result;
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2548) Log improvements in
DBOutputFormat.java and CounterGroup.java
Posted by "Devaraj K (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj K updated MAPREDUCE-2548:
---------------------------------
Fix Version/s: 0.23.0
Status: Patch Available (was: Open)
> Log improvements in DBOutputFormat.java and CounterGroup.java
> -------------------------------------------------------------
>
> Key: MAPREDUCE-2548
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2548
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2548.patch
>
>
> 1. Instead of the printing the stack trace on the console, It can be logged.
> {code:title=DBOutputFormat.java|borderStyle=solid}
>
> public void write(K key, V value) throws IOException {
> try {
> key.write(statement);
> statement.addBatch();
> } catch (SQLException e) {
> e.printStackTrace();
> }
> }
> {code}
> 2. Missing resource information can be logged.
> {code:title=CounterGroup .java|borderStyle=solid}
> protected CounterGroup(String name) {
> this.name = name;
> try {
> bundle = getResourceBundle(name);
> }
> catch (MissingResourceException neverMind) {
> }
> displayName = localize("CounterGroupName", name);
> }
> private String localize(String key, String defaultValue) {
> String result = defaultValue;
> if (bundle != null) {
> try {
> result = bundle.getString(key);
> }
> catch (MissingResourceException mre) {
> }
> }
> return result;
> }
> {code}
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2548) Log improvements in
DBOutputFormat.java and CounterGroup.java
Posted by "Devaraj K (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj K updated MAPREDUCE-2548:
---------------------------------
Fix Version/s: (was: 0.24.0)
Affects Version/s: 2.0.0
Status: Patch Available (was: Open)
Thank you harsh for taking look into the patch. Sorry for the late response.
There is no issue with CounterGroup.java in the latest. I have updated the message in DBOutputFormat.java.
Can you please have look into the updated patch?
> Log improvements in DBOutputFormat.java and CounterGroup.java
> -------------------------------------------------------------
>
> Key: MAPREDUCE-2548
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2548
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Attachments: MAPREDUCE-2548-1.patch, MAPREDUCE-2548.patch
>
>
> 1. Instead of the printing the stack trace on the console, It can be logged.
> {code:title=DBOutputFormat.java|borderStyle=solid}
>
> public void write(K key, V value) throws IOException {
> try {
> key.write(statement);
> statement.addBatch();
> } catch (SQLException e) {
> e.printStackTrace();
> }
> }
> {code}
> 2. Missing resource information can be logged.
> {code:title=CounterGroup .java|borderStyle=solid}
> protected CounterGroup(String name) {
> this.name = name;
> try {
> bundle = getResourceBundle(name);
> }
> catch (MissingResourceException neverMind) {
> }
> displayName = localize("CounterGroupName", name);
> }
> private String localize(String key, String defaultValue) {
> String result = defaultValue;
> if (bundle != null) {
> try {
> result = bundle.getString(key);
> }
> catch (MissingResourceException mre) {
> }
> }
> return result;
> }
> {code}
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2548) Log improvements in
DBOutputFormat.java and CounterGroup.java
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042878#comment-13042878 ]
Hadoop QA commented on MAPREDUCE-2548:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12481234/MAPREDUCE-2548.patch
against trunk revision 1130554.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.cli.TestMRCLI
org.apache.hadoop.mapred.TestDebugScript
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/334//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/334//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/334//console
This message is automatically generated.
> Log improvements in DBOutputFormat.java and CounterGroup.java
> -------------------------------------------------------------
>
> Key: MAPREDUCE-2548
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2548
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2548.patch
>
>
> 1. Instead of the printing the stack trace on the console, It can be logged.
> {code:title=DBOutputFormat.java|borderStyle=solid}
>
> public void write(K key, V value) throws IOException {
> try {
> key.write(statement);
> statement.addBatch();
> } catch (SQLException e) {
> e.printStackTrace();
> }
> }
> {code}
> 2. Missing resource information can be logged.
> {code:title=CounterGroup .java|borderStyle=solid}
> protected CounterGroup(String name) {
> this.name = name;
> try {
> bundle = getResourceBundle(name);
> }
> catch (MissingResourceException neverMind) {
> }
> displayName = localize("CounterGroupName", name);
> }
> private String localize(String key, String defaultValue) {
> String result = defaultValue;
> if (bundle != null) {
> try {
> result = bundle.getString(key);
> }
> catch (MissingResourceException mre) {
> }
> }
> return result;
> }
> {code}
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2548) Log improvements in
DBOutputFormat.java and CounterGroup.java
Posted by "Harsh J (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258242#comment-13258242 ]
Harsh J commented on MAPREDUCE-2548:
------------------------------------
This change appears fine, but we do not need to stringify exceptions anymore.
A better way would be to {{LOG.warn("Some message regarding the failure here", exceptionObject);}} and that'd work nicely with the logger.
> Log improvements in DBOutputFormat.java and CounterGroup.java
> -------------------------------------------------------------
>
> Key: MAPREDUCE-2548
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2548
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Attachments: MAPREDUCE-2548-1.patch, MAPREDUCE-2548.patch
>
>
> 1. Instead of the printing the stack trace on the console, It can be logged.
> {code:title=DBOutputFormat.java|borderStyle=solid}
>
> public void write(K key, V value) throws IOException {
> try {
> key.write(statement);
> statement.addBatch();
> } catch (SQLException e) {
> e.printStackTrace();
> }
> }
> {code}
> 2. Missing resource information can be logged.
> {code:title=CounterGroup .java|borderStyle=solid}
> protected CounterGroup(String name) {
> this.name = name;
> try {
> bundle = getResourceBundle(name);
> }
> catch (MissingResourceException neverMind) {
> }
> displayName = localize("CounterGroupName", name);
> }
> private String localize(String key, String defaultValue) {
> String result = defaultValue;
> if (bundle != null) {
> try {
> result = bundle.getString(key);
> }
> catch (MissingResourceException mre) {
> }
> }
> return result;
> }
> {code}
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2548) Log improvements in
DBOutputFormat.java and CounterGroup.java
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097001#comment-13097001 ]
Harsh J commented on MAPREDUCE-2548:
------------------------------------
Some comments/nits:
- Logging object can be private, doesn't need to be public.
- Please wrap debug logging with is-debug-enabled checks.
Thanks! :)
> Log improvements in DBOutputFormat.java and CounterGroup.java
> -------------------------------------------------------------
>
> Key: MAPREDUCE-2548
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2548
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2548.patch
>
>
> 1. Instead of the printing the stack trace on the console, It can be logged.
> {code:title=DBOutputFormat.java|borderStyle=solid}
>
> public void write(K key, V value) throws IOException {
> try {
> key.write(statement);
> statement.addBatch();
> } catch (SQLException e) {
> e.printStackTrace();
> }
> }
> {code}
> 2. Missing resource information can be logged.
> {code:title=CounterGroup .java|borderStyle=solid}
> protected CounterGroup(String name) {
> this.name = name;
> try {
> bundle = getResourceBundle(name);
> }
> catch (MissingResourceException neverMind) {
> }
> displayName = localize("CounterGroupName", name);
> }
> private String localize(String key, String defaultValue) {
> String result = defaultValue;
> if (bundle != null) {
> try {
> result = bundle.getString(key);
> }
> catch (MissingResourceException mre) {
> }
> }
> return result;
> }
> {code}
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2548) Log improvements in
DBOutputFormat.java and CounterGroup.java
Posted by "Devaraj K (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj K updated MAPREDUCE-2548:
---------------------------------
Attachment: MAPREDUCE-2548-1.patch
> Log improvements in DBOutputFormat.java and CounterGroup.java
> -------------------------------------------------------------
>
> Key: MAPREDUCE-2548
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2548
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.24.0
>
> Attachments: MAPREDUCE-2548-1.patch, MAPREDUCE-2548.patch
>
>
> 1. Instead of the printing the stack trace on the console, It can be logged.
> {code:title=DBOutputFormat.java|borderStyle=solid}
>
> public void write(K key, V value) throws IOException {
> try {
> key.write(statement);
> statement.addBatch();
> } catch (SQLException e) {
> e.printStackTrace();
> }
> }
> {code}
> 2. Missing resource information can be logged.
> {code:title=CounterGroup .java|borderStyle=solid}
> protected CounterGroup(String name) {
> this.name = name;
> try {
> bundle = getResourceBundle(name);
> }
> catch (MissingResourceException neverMind) {
> }
> displayName = localize("CounterGroupName", name);
> }
> private String localize(String key, String defaultValue) {
> String result = defaultValue;
> if (bundle != null) {
> try {
> result = bundle.getString(key);
> }
> catch (MissingResourceException mre) {
> }
> }
> return result;
> }
> {code}
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2548) Log improvements in
DBOutputFormat.java and CounterGroup.java
Posted by "Devaraj K (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj K updated MAPREDUCE-2548:
---------------------------------
Attachment: MAPREDUCE-2548.patch
> Log improvements in DBOutputFormat.java and CounterGroup.java
> -------------------------------------------------------------
>
> Key: MAPREDUCE-2548
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2548
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Devaraj K
> Assignee: Devaraj K
> Attachments: MAPREDUCE-2548.patch
>
>
> 1. Instead of the printing the stack trace on the console, It can be logged.
> {code:title=DBOutputFormat.java|borderStyle=solid}
>
> public void write(K key, V value) throws IOException {
> try {
> key.write(statement);
> statement.addBatch();
> } catch (SQLException e) {
> e.printStackTrace();
> }
> }
> {code}
> 2. Missing resource information can be logged.
> {code:title=CounterGroup .java|borderStyle=solid}
> protected CounterGroup(String name) {
> this.name = name;
> try {
> bundle = getResourceBundle(name);
> }
> catch (MissingResourceException neverMind) {
> }
> displayName = localize("CounterGroupName", name);
> }
> private String localize(String key, String defaultValue) {
> String result = defaultValue;
> if (bundle != null) {
> try {
> result = bundle.getString(key);
> }
> catch (MissingResourceException mre) {
> }
> }
> return result;
> }
> {code}
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2548) Log improvements in
DBOutputFormat.java and CounterGroup.java
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240570#comment-13240570 ]
Hadoop QA commented on MAPREDUCE-2548:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520282/MAPREDUCE-2548-1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2110//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2110//console
This message is automatically generated.
> Log improvements in DBOutputFormat.java and CounterGroup.java
> -------------------------------------------------------------
>
> Key: MAPREDUCE-2548
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2548
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Attachments: MAPREDUCE-2548-1.patch, MAPREDUCE-2548.patch
>
>
> 1. Instead of the printing the stack trace on the console, It can be logged.
> {code:title=DBOutputFormat.java|borderStyle=solid}
>
> public void write(K key, V value) throws IOException {
> try {
> key.write(statement);
> statement.addBatch();
> } catch (SQLException e) {
> e.printStackTrace();
> }
> }
> {code}
> 2. Missing resource information can be logged.
> {code:title=CounterGroup .java|borderStyle=solid}
> protected CounterGroup(String name) {
> this.name = name;
> try {
> bundle = getResourceBundle(name);
> }
> catch (MissingResourceException neverMind) {
> }
> displayName = localize("CounterGroupName", name);
> }
> private String localize(String key, String defaultValue) {
> String result = defaultValue;
> if (bundle != null) {
> try {
> result = bundle.getString(key);
> }
> catch (MissingResourceException mre) {
> }
> }
> return result;
> }
> {code}
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2548) Log improvements in
DBOutputFormat.java and CounterGroup.java
Posted by "Devaraj K (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj K updated MAPREDUCE-2548:
---------------------------------
Status: Open (was: Patch Available)
> Log improvements in DBOutputFormat.java and CounterGroup.java
> -------------------------------------------------------------
>
> Key: MAPREDUCE-2548
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2548
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.24.0
>
> Attachments: MAPREDUCE-2548-1.patch, MAPREDUCE-2548.patch
>
>
> 1. Instead of the printing the stack trace on the console, It can be logged.
> {code:title=DBOutputFormat.java|borderStyle=solid}
>
> public void write(K key, V value) throws IOException {
> try {
> key.write(statement);
> statement.addBatch();
> } catch (SQLException e) {
> e.printStackTrace();
> }
> }
> {code}
> 2. Missing resource information can be logged.
> {code:title=CounterGroup .java|borderStyle=solid}
> protected CounterGroup(String name) {
> this.name = name;
> try {
> bundle = getResourceBundle(name);
> }
> catch (MissingResourceException neverMind) {
> }
> displayName = localize("CounterGroupName", name);
> }
> private String localize(String key, String defaultValue) {
> String result = defaultValue;
> if (bundle != null) {
> try {
> result = bundle.getString(key);
> }
> catch (MissingResourceException mre) {
> }
> }
> return result;
> }
> {code}
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira