You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2023/06/20 18:09:04 UTC
[GitHub] [arrow-adbc] zeroshade opened a new pull request, #825: feat(go/adbc/flightsql): Add cookie middleware option
zeroshade opened a new pull request, #825:
URL: https://github.com/apache/arrow-adbc/pull/825
Fixes #716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade commented on a diff in pull request #825: feat(go/adbc/driver/flightsql): Add cookie middleware option
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #825:
URL: https://github.com/apache/arrow-adbc/pull/825#discussion_r1235940671
##########
docs/source/driver/flight_sql.rst:
##########
@@ -185,6 +185,11 @@ These options map 1:1 with the options in FlightClientOptions:
defaults to 16 MiB since Flight services tend to return larger
reponse payloads. Should be a positive integer number of bytes.
+``adbc.flight.sql.rpc.with_cookie_middleware``
+ Enable or disable middleware that processes and handles "set-cookie"
+ metadata headers returned from the server and sends "Cookie" headers
+ back from the client. Value should be ``true`` or ``false``.
Review Comment:
Good point, let me update it. Default is `false`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] github-actions[bot] commented on pull request #825: feat(go/adbc/flightsql): Add cookie middleware option
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #825:
URL: https://github.com/apache/arrow-adbc/pull/825#issuecomment-1599273740
:warning: Please follow the [Conventional Commits format in CONTRIBUTING.md](https://github.com/apache/arrow-adbc/blob/main/CONTRIBUTING.md) for PR titles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade merged pull request #825: feat(go/adbc/driver/flightsql): Add cookie middleware option
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #825:
URL: https://github.com/apache/arrow-adbc/pull/825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #825: feat(go/adbc/driver/flightsql): Add cookie middleware option
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #825:
URL: https://github.com/apache/arrow-adbc/pull/825#discussion_r1235750130
##########
docs/source/driver/flight_sql.rst:
##########
@@ -185,6 +185,11 @@ These options map 1:1 with the options in FlightClientOptions:
defaults to 16 MiB since Flight services tend to return larger
reponse payloads. Should be a positive integer number of bytes.
+``adbc.flight.sql.rpc.with_cookie_middleware``
+ Enable or disable middleware that processes and handles "set-cookie"
+ metadata headers returned from the server and sends "Cookie" headers
+ back from the client. Value should be ``true`` or ``false``.
Review Comment:
What's the default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org