You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by Abhishek Tiwari <ab...@apache.org> on 2018/03/27 00:01:44 UTC
[VOTE] Apache Gobblin 0.12.0 release RC2
The Apache Gobblin community has voted on and approved the release of
Apache Gobblin 0.12.0 (incubating):
https://www.mail-archive.com/dev@gobblin.incubator.apache.org/msg01772.html
Results:
5 binding +1 votes
No 0 votes
No -1 votes
The feedback from previous release candidates has been addressed:
RC0 thread: https://www.mail-archive.com/general@incubator.
apache.org/msg62151.html
RC0 resolution: LICENSE and NOTICE files have been updated (tracked by
GOBBLIN-431 <https://issues.apache.org/jira/browse/GOBBLIN-431>)
RC1 thread: https://www.mail-archive.com/dev@gobblin.
incubator.apache.org/msg01733.html
RC1 resolution: gradlew scripts have been included in the source
distribution, and the steps for building the distribution has been added to
README (including the way to obtain gradlew jar)
I'd like to call a vote in general to approve the release.
The source release candidate RC2 can be downloaded here:
https://dist.apache.org/repos/dist/dev/incubator/gobblin/
apache-gobblin-incubating-0.12.0-rc2/
The artifacts (i.e. JARs) corresponding to this release candidate can be
found here:
https://repository.apache.org/content/repositories/orgapachegobblin-1002
This has been signed with PGP key 234E3FE3, corresponding to
abti@apache.org, which is included in the repository's KEYS file (
https://dist.apache.org/repos/dist/release/incubator/gobblin/KEYS). This
key can be found on keyservers, such as:
*http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3
<http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3>*
It is also listed here:
https://people.apache.org/keys/committer/abti.asc
The release candidate has been tagged with release-0.12.0-rc2.
I've also created a branch 0.12.0.
For reference, here is a list of all closed JIRAs tagged with 0.12.0:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20GOBBLIN%20AND%
20fixVersion%20%3D%200.12.0%20AND%20status%20in%20(Closed%
2C%20Resolved)%20ORDER%20BY%20updatedDate%20DESC%2C%20createdDate%20DESC%2C%
20status%20DESC%2C%20priority%20DESC
For a summary of the changes in this release, see:
https://github.com/apache/incubator-gobblin/blob/0.12.0/CHANGELOG.md
Please review and vote. The vote will be open for 72 hours.
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)
Thanks,
Abhishek, on behalf of the Apache Gobblin PPMC
[RESULT] [VOTE] Apache Gobblin 0.12.0 release RC3
Posted by Abhishek Tiwari <fi...@gmail.com>.
Thanks to all who voted!
The release has PASSED with the following IPMC votes:
+1 Jim Jagielski (binding)
+1 Justin Mclean (binding)
+1 Olivier Lamy (binding)
I will proceed to publish the release and send ANNOUNCE.
On behalf of Apache Gobblin, thank you!
Regards,
Abhishek
Vote thread reference:
https://www.mail-archive.com/general@incubator.apache.org/msg64040.html
[RESULT] [VOTE] Apache Gobblin 0.12.0 release RC3
Posted by Abhishek Tiwari <fi...@gmail.com>.
Thanks to all who voted!
The release has PASSED with the following IPMC votes:
+1 Jim Jagielski (binding)
+1 Justin Mclean (binding)
+1 Olivier Lamy (binding)
I will proceed to publish the release and send ANNOUNCE.
On behalf of Apache Gobblin, thank you!
Regards,
Abhishek
Vote thread reference:
https://www.mail-archive.com/general@incubator.apache.org/msg64040.html
Re: [VOTE] Apache Gobblin 0.12.0 release RC3
Posted by Abhishek Tiwari <ab...@apache.org>.
Hi Jim,
Thanks for the vote. Hope Scotland was fun this time of year :)
Everyone,
Thanks for the review and vote. I will close the vote now, and send out a
result mail.
Regards,
Abhishek
On Mon, Jul 2, 2018 at 4:19 PM Jim Jagielski <ji...@jagunet.com> wrote:
> Just got back from a week+ in Scotland... sorry for the delay.
>
> +1 (binding) from me.
>
> > On Jul 1, 2018, at 1:18 PM, Abhishek Tiwari <ab...@apache.org> wrote:
> >
> > We are still looking for 1 more +1, will really appreciate it if anyone
> can
> > spare sometime to review and vote :)
> >
> > Abhishek
> >
> > On Sun, Jul 1, 2018 at 6:41 AM Abhishek Tiwari <ab...@apache.org> wrote:
> >
> >> Thanks Justin. I will remove the md5.
> >>
> >> Abhishek
> >>
> >> On Sun, Jul 1, 2018 at 3:02 AM Justin Mclean <ju...@classsoftware.com>
> >> wrote:
> >>
> >>> Hi,
> >>>
> >>> +1 (binding)
> >>>
> >>> Please remove the md5 hash from the release area before releasing as
> >>> these should not longer be used.
> >>>
> >>> I checked:
> >>> - incubating in artefacts name
> >>> - signatures ands hashes correct
> >>> - DISCLAIMER exists
> >>> - LICENSE is missing a license
> >>> - NOTICE is correct
> >>> - Source file have headers, but there a few shell scripts missing them
> >>> [1][2][3][4][5]
> >>> - can compile from source
> >>>
> >>> LICENSE is missing license for the glyphicons-halflings font. [6]
> >>>
> >>> Thanks,
> >>> Justin
> >>>
> >>> 1.
> apache-gobblin-incubating-sources-0.12.0/bin/gobblin-cluster-worker.sh
> >>> 2. apache-gobblin-incubating-sources-0.12.0/bin/gobblin-service.sh
> >>> 3.
> apache-gobblin-incubating-sources-0.12.0/bin/gobblin-cluster-master.sh
> >>> 4.
> >>>
> apache-gobblin-incubating-sources-0.12.0/gobblin-aws/src/test/resources/workerCloudInit.sh
> >>> 5.
> >>>
> apache-gobblin-incubating-sources-0.12.0/gobblin-aws/src/test/resources/masterCloudInit.sh
> >>> 6.
> >>>
> apache-gobblin-incubating-sources-0.12.0/gobblin-admin/src/main/resources/static/fonts/glyphicons-halflings-regular.*
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >>> For additional commands, e-mail: general-help@incubator.apache.org
> >>>
> >>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Apache Gobblin 0.12.0 release RC3
Posted by Abhishek Tiwari <ab...@apache.org>.
Hi Jim,
Thanks for the vote. Hope Scotland was fun this time of year :)
Everyone,
Thanks for the review and vote. I will close the vote now, and send out a
result mail.
Regards,
Abhishek
On Mon, Jul 2, 2018 at 4:19 PM Jim Jagielski <ji...@jagunet.com> wrote:
> Just got back from a week+ in Scotland... sorry for the delay.
>
> +1 (binding) from me.
>
> > On Jul 1, 2018, at 1:18 PM, Abhishek Tiwari <ab...@apache.org> wrote:
> >
> > We are still looking for 1 more +1, will really appreciate it if anyone
> can
> > spare sometime to review and vote :)
> >
> > Abhishek
> >
> > On Sun, Jul 1, 2018 at 6:41 AM Abhishek Tiwari <ab...@apache.org> wrote:
> >
> >> Thanks Justin. I will remove the md5.
> >>
> >> Abhishek
> >>
> >> On Sun, Jul 1, 2018 at 3:02 AM Justin Mclean <ju...@classsoftware.com>
> >> wrote:
> >>
> >>> Hi,
> >>>
> >>> +1 (binding)
> >>>
> >>> Please remove the md5 hash from the release area before releasing as
> >>> these should not longer be used.
> >>>
> >>> I checked:
> >>> - incubating in artefacts name
> >>> - signatures ands hashes correct
> >>> - DISCLAIMER exists
> >>> - LICENSE is missing a license
> >>> - NOTICE is correct
> >>> - Source file have headers, but there a few shell scripts missing them
> >>> [1][2][3][4][5]
> >>> - can compile from source
> >>>
> >>> LICENSE is missing license for the glyphicons-halflings font. [6]
> >>>
> >>> Thanks,
> >>> Justin
> >>>
> >>> 1.
> apache-gobblin-incubating-sources-0.12.0/bin/gobblin-cluster-worker.sh
> >>> 2. apache-gobblin-incubating-sources-0.12.0/bin/gobblin-service.sh
> >>> 3.
> apache-gobblin-incubating-sources-0.12.0/bin/gobblin-cluster-master.sh
> >>> 4.
> >>>
> apache-gobblin-incubating-sources-0.12.0/gobblin-aws/src/test/resources/workerCloudInit.sh
> >>> 5.
> >>>
> apache-gobblin-incubating-sources-0.12.0/gobblin-aws/src/test/resources/masterCloudInit.sh
> >>> 6.
> >>>
> apache-gobblin-incubating-sources-0.12.0/gobblin-admin/src/main/resources/static/fonts/glyphicons-halflings-regular.*
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >>> For additional commands, e-mail: general-help@incubator.apache.org
> >>>
> >>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Apache Gobblin 0.12.0 release RC3
Posted by Jim Jagielski <ji...@jaguNET.com>.
Just got back from a week+ in Scotland... sorry for the delay.
+1 (binding) from me.
> On Jul 1, 2018, at 1:18 PM, Abhishek Tiwari <ab...@apache.org> wrote:
>
> We are still looking for 1 more +1, will really appreciate it if anyone can
> spare sometime to review and vote :)
>
> Abhishek
>
> On Sun, Jul 1, 2018 at 6:41 AM Abhishek Tiwari <ab...@apache.org> wrote:
>
>> Thanks Justin. I will remove the md5.
>>
>> Abhishek
>>
>> On Sun, Jul 1, 2018 at 3:02 AM Justin Mclean <ju...@classsoftware.com>
>> wrote:
>>
>>> Hi,
>>>
>>> +1 (binding)
>>>
>>> Please remove the md5 hash from the release area before releasing as
>>> these should not longer be used.
>>>
>>> I checked:
>>> - incubating in artefacts name
>>> - signatures ands hashes correct
>>> - DISCLAIMER exists
>>> - LICENSE is missing a license
>>> - NOTICE is correct
>>> - Source file have headers, but there a few shell scripts missing them
>>> [1][2][3][4][5]
>>> - can compile from source
>>>
>>> LICENSE is missing license for the glyphicons-halflings font. [6]
>>>
>>> Thanks,
>>> Justin
>>>
>>> 1. apache-gobblin-incubating-sources-0.12.0/bin/gobblin-cluster-worker.sh
>>> 2. apache-gobblin-incubating-sources-0.12.0/bin/gobblin-service.sh
>>> 3. apache-gobblin-incubating-sources-0.12.0/bin/gobblin-cluster-master.sh
>>> 4.
>>> apache-gobblin-incubating-sources-0.12.0/gobblin-aws/src/test/resources/workerCloudInit.sh
>>> 5.
>>> apache-gobblin-incubating-sources-0.12.0/gobblin-aws/src/test/resources/masterCloudInit.sh
>>> 6.
>>> apache-gobblin-incubating-sources-0.12.0/gobblin-admin/src/main/resources/static/fonts/glyphicons-halflings-regular.*
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>
>>>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Gobblin 0.12.0 release RC3
Posted by Abhishek Tiwari <ab...@apache.org>.
We are still looking for 1 more +1, will really appreciate it if anyone can
spare sometime to review and vote :)
Abhishek
On Sun, Jul 1, 2018 at 6:41 AM Abhishek Tiwari <ab...@apache.org> wrote:
> Thanks Justin. I will remove the md5.
>
> Abhishek
>
> On Sun, Jul 1, 2018 at 3:02 AM Justin Mclean <ju...@classsoftware.com>
> wrote:
>
>> Hi,
>>
>> +1 (binding)
>>
>> Please remove the md5 hash from the release area before releasing as
>> these should not longer be used.
>>
>> I checked:
>> - incubating in artefacts name
>> - signatures ands hashes correct
>> - DISCLAIMER exists
>> - LICENSE is missing a license
>> - NOTICE is correct
>> - Source file have headers, but there a few shell scripts missing them
>> [1][2][3][4][5]
>> - can compile from source
>>
>> LICENSE is missing license for the glyphicons-halflings font. [6]
>>
>> Thanks,
>> Justin
>>
>> 1. apache-gobblin-incubating-sources-0.12.0/bin/gobblin-cluster-worker.sh
>> 2. apache-gobblin-incubating-sources-0.12.0/bin/gobblin-service.sh
>> 3. apache-gobblin-incubating-sources-0.12.0/bin/gobblin-cluster-master.sh
>> 4.
>> apache-gobblin-incubating-sources-0.12.0/gobblin-aws/src/test/resources/workerCloudInit.sh
>> 5.
>> apache-gobblin-incubating-sources-0.12.0/gobblin-aws/src/test/resources/masterCloudInit.sh
>> 6.
>> apache-gobblin-incubating-sources-0.12.0/gobblin-admin/src/main/resources/static/fonts/glyphicons-halflings-regular.*
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>>
>>
Re: [VOTE] Apache Gobblin 0.12.0 release RC3
Posted by Abhishek Tiwari <ab...@apache.org>.
Thanks Justin. I will remove the md5.
Abhishek
On Sun, Jul 1, 2018 at 3:02 AM Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> +1 (binding)
>
> Please remove the md5 hash from the release area before releasing as these
> should not longer be used.
>
> I checked:
> - incubating in artefacts name
> - signatures ands hashes correct
> - DISCLAIMER exists
> - LICENSE is missing a license
> - NOTICE is correct
> - Source file have headers, but there a few shell scripts missing them
> [1][2][3][4][5]
> - can compile from source
>
> LICENSE is missing license for the glyphicons-halflings font. [6]
>
> Thanks,
> Justin
>
> 1. apache-gobblin-incubating-sources-0.12.0/bin/gobblin-cluster-worker.sh
> 2. apache-gobblin-incubating-sources-0.12.0/bin/gobblin-service.sh
> 3. apache-gobblin-incubating-sources-0.12.0/bin/gobblin-cluster-master.sh
> 4.
> apache-gobblin-incubating-sources-0.12.0/gobblin-aws/src/test/resources/workerCloudInit.sh
> 5.
> apache-gobblin-incubating-sources-0.12.0/gobblin-aws/src/test/resources/masterCloudInit.sh
> 6.
> apache-gobblin-incubating-sources-0.12.0/gobblin-admin/src/main/resources/static/fonts/glyphicons-halflings-regular.*
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Apache Gobblin 0.12.0 release RC3
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
+1 (binding)
Please remove the md5 hash from the release area before releasing as these should not longer be used.
I checked:
- incubating in artefacts name
- signatures ands hashes correct
- DISCLAIMER exists
- LICENSE is missing a license
- NOTICE is correct
- Source file have headers, but there a few shell scripts missing them [1][2][3][4][5]
- can compile from source
LICENSE is missing license for the glyphicons-halflings font. [6]
Thanks,
Justin
1. apache-gobblin-incubating-sources-0.12.0/bin/gobblin-cluster-worker.sh
2. apache-gobblin-incubating-sources-0.12.0/bin/gobblin-service.sh
3. apache-gobblin-incubating-sources-0.12.0/bin/gobblin-cluster-master.sh
4. apache-gobblin-incubating-sources-0.12.0/gobblin-aws/src/test/resources/workerCloudInit.sh
5. apache-gobblin-incubating-sources-0.12.0/gobblin-aws/src/test/resources/masterCloudInit.sh
6. apache-gobblin-incubating-sources-0.12.0/gobblin-admin/src/main/resources/static/fonts/glyphicons-halflings-regular.*
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Gobblin 0.12.0 release RC3
Posted by Abhishek Tiwari <ab...@apache.org>.
Thanks Olivier.
Abhishek
On Sat, Jun 30, 2018 at 10:11 AM Olivier Lamy <ol...@apache.org> wrote:
> +1
>
> On Thu, 28 Jun 2018 at 3:05 am, Abhishek Tiwari <ab...@apache.org> wrote:
>
> > [bump up to get traction]
> >
> > Abhishek
> >
> > On Sat, Jun 23, 2018 at 1:57 PM Abhishek Tiwari <ab...@apache.org> wrote:
> >
> > > The Apache Gobblin community has voted on and approved the release of
> > > Apache Gobblin 0.12.0 (incubating):
> > >
> > >
> >
> https://www.mail-archive.com/dev@gobblin.incubator.apache.org/msg01981.html
> > >
> > > Results:
> > > 5 binding +1 votes
> > > 1 non-binding +1 vote
> > > No 0 votes
> > > No -1 votes
> > >
> > > The feedback from previous release candidates has been addressed:
> > > RC0 thread: https://www.mail-archive.com/general@incubator.apache
> > > .org/msg62151.html
> > > RC0 resolution: LICENSE and NOTICE files have been updated (tracked by
> > > GOBBLIN-431 <https://issues.apache.org/jira/browse/GOBBLIN-431>)
> > > RC1 thread: https://www.mail-archive.com/dev@gobblin.incubator.apache
> > > .org/msg01733.html
> > > RC1 resolution: gradlew scripts have been included in the source
> > > distribution, and the steps for building the distribution has been
> added
> > to
> > > README (including the way to obtain gradlew jar)
> > > RC 2 thread: https://mail-archives.apache
> > >
> >
> .org/mod_mbox/incubator-general/201804.mbox/%3CCAD+38UAE+Cpv3syCYH1RHGLbdHNqZHPfVh3YS6g=
> > Qxhhb8n3fg@mail.gmail.com%3E
> > > RC 2 resolution: This release candidate (RC3) has been cut with
> Justin's
> > > changes to NOTICE file to make it Apache compliant
> > >
> > > I'd like to call a vote in general to approve the release.
> > >
> > > The source release candidate RC3 can be downloaded here:
> > >
> https://dist.apache.org/repos/dist/dev/incubator/gobblin/apache-gobblin
> > > -incubating-0.12.0-rc3/
> > >
> > > The artifacts (i.e. JARs) corresponding to this release candidate can
> be
> > > found here:
> > >
> https://repository.apache.org/content/repositories/orgapachegobblin-1003
> > >
> > > This has been signed with PGP key 234E3FE3, corresponding to
> > > abti@apache.org, which is included in the repository's KEYS file (
> > > https://dist.apache.org/repos/dist/release/incubator/gobblin/KEYS).
> > This
> > > key can be found on keyservers, such as:
> > >
> > > *http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3
> > > <http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3>*
> > >
> > > It is also listed here:
> > > https://people.apache.org/keys/committer/abti.asc
> > >
> > > The release candidate has been tagged with release-0.12.0-rc3.
> > > I've also created a branch 0.12.0.
> > >
> > > For reference, here is a list of all closed JIRAs tagged with 0.12.0:
> > >
> > >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20GOBBLIN%20AND%20fixVersion%20%3D%200.12.0%20AND%20status%20in%20(Closed%2C%20Resolved)%20ORDER%20BY%20updatedDate%20DESC%2C%20createdDate%20DESC%2C%20status%20DESC%2C%20priority%20DESC
> > >
> > >
> > > For a summary of the changes in this release, see:
> > > https://github.com/apache/incubator-gobblin/blob/0.12.0/CHANGELOG.md
> > >
> > > Please review and vote. The vote will be open for 72 hours.
> > >
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove (and reason why)
> > >
> > > Thanks,
> > > Abhishek, on behalf of the Apache Gobblin PPMC
> > >
> > >
> >
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
Re: [VOTE] Apache Gobblin 0.12.0 release RC3
Posted by Olivier Lamy <ol...@apache.org>.
+1
On Thu, 28 Jun 2018 at 3:05 am, Abhishek Tiwari <ab...@apache.org> wrote:
> [bump up to get traction]
>
> Abhishek
>
> On Sat, Jun 23, 2018 at 1:57 PM Abhishek Tiwari <ab...@apache.org> wrote:
>
> > The Apache Gobblin community has voted on and approved the release of
> > Apache Gobblin 0.12.0 (incubating):
> >
> >
> https://www.mail-archive.com/dev@gobblin.incubator.apache.org/msg01981.html
> >
> > Results:
> > 5 binding +1 votes
> > 1 non-binding +1 vote
> > No 0 votes
> > No -1 votes
> >
> > The feedback from previous release candidates has been addressed:
> > RC0 thread: https://www.mail-archive.com/general@incubator.apache
> > .org/msg62151.html
> > RC0 resolution: LICENSE and NOTICE files have been updated (tracked by
> > GOBBLIN-431 <https://issues.apache.org/jira/browse/GOBBLIN-431>)
> > RC1 thread: https://www.mail-archive.com/dev@gobblin.incubator.apache
> > .org/msg01733.html
> > RC1 resolution: gradlew scripts have been included in the source
> > distribution, and the steps for building the distribution has been added
> to
> > README (including the way to obtain gradlew jar)
> > RC 2 thread: https://mail-archives.apache
> >
> .org/mod_mbox/incubator-general/201804.mbox/%3CCAD+38UAE+Cpv3syCYH1RHGLbdHNqZHPfVh3YS6g=
> Qxhhb8n3fg@mail.gmail.com%3E
> > RC 2 resolution: This release candidate (RC3) has been cut with Justin's
> > changes to NOTICE file to make it Apache compliant
> >
> > I'd like to call a vote in general to approve the release.
> >
> > The source release candidate RC3 can be downloaded here:
> > https://dist.apache.org/repos/dist/dev/incubator/gobblin/apache-gobblin
> > -incubating-0.12.0-rc3/
> >
> > The artifacts (i.e. JARs) corresponding to this release candidate can be
> > found here:
> > https://repository.apache.org/content/repositories/orgapachegobblin-1003
> >
> > This has been signed with PGP key 234E3FE3, corresponding to
> > abti@apache.org, which is included in the repository's KEYS file (
> > https://dist.apache.org/repos/dist/release/incubator/gobblin/KEYS).
> This
> > key can be found on keyservers, such as:
> >
> > *http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3
> > <http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3>*
> >
> > It is also listed here:
> > https://people.apache.org/keys/committer/abti.asc
> >
> > The release candidate has been tagged with release-0.12.0-rc3.
> > I've also created a branch 0.12.0.
> >
> > For reference, here is a list of all closed JIRAs tagged with 0.12.0:
> >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20GOBBLIN%20AND%20fixVersion%20%3D%200.12.0%20AND%20status%20in%20(Closed%2C%20Resolved)%20ORDER%20BY%20updatedDate%20DESC%2C%20createdDate%20DESC%2C%20status%20DESC%2C%20priority%20DESC
> >
> >
> > For a summary of the changes in this release, see:
> > https://github.com/apache/incubator-gobblin/blob/0.12.0/CHANGELOG.md
> >
> > Please review and vote. The vote will be open for 72 hours.
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
> > Thanks,
> > Abhishek, on behalf of the Apache Gobblin PPMC
> >
> >
>
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: [VOTE] Apache Gobblin 0.12.0 release RC3
Posted by Abhishek Tiwari <ab...@apache.org>.
[bump up to get traction]
Abhishek
On Sat, Jun 23, 2018 at 1:57 PM Abhishek Tiwari <ab...@apache.org> wrote:
> The Apache Gobblin community has voted on and approved the release of
> Apache Gobblin 0.12.0 (incubating):
>
> https://www.mail-archive.com/dev@gobblin.incubator.apache.org/msg01981.html
>
> Results:
> 5 binding +1 votes
> 1 non-binding +1 vote
> No 0 votes
> No -1 votes
>
> The feedback from previous release candidates has been addressed:
> RC0 thread: https://www.mail-archive.com/general@incubator.apache
> .org/msg62151.html
> RC0 resolution: LICENSE and NOTICE files have been updated (tracked by
> GOBBLIN-431 <https://issues.apache.org/jira/browse/GOBBLIN-431>)
> RC1 thread: https://www.mail-archive.com/dev@gobblin.incubator.apache
> .org/msg01733.html
> RC1 resolution: gradlew scripts have been included in the source
> distribution, and the steps for building the distribution has been added to
> README (including the way to obtain gradlew jar)
> RC 2 thread: https://mail-archives.apache
> .org/mod_mbox/incubator-general/201804.mbox/%3CCAD+38UAE+Cpv3syCYH1RHGLbdHNqZHPfVh3YS6g=Qxhhb8n3fg@mail.gmail.com%3E
> RC 2 resolution: This release candidate (RC3) has been cut with Justin's
> changes to NOTICE file to make it Apache compliant
>
> I'd like to call a vote in general to approve the release.
>
> The source release candidate RC3 can be downloaded here:
> https://dist.apache.org/repos/dist/dev/incubator/gobblin/apache-gobblin
> -incubating-0.12.0-rc3/
>
> The artifacts (i.e. JARs) corresponding to this release candidate can be
> found here:
> https://repository.apache.org/content/repositories/orgapachegobblin-1003
>
> This has been signed with PGP key 234E3FE3, corresponding to
> abti@apache.org, which is included in the repository's KEYS file (
> https://dist.apache.org/repos/dist/release/incubator/gobblin/KEYS). This
> key can be found on keyservers, such as:
>
> *http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3
> <http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3>*
>
> It is also listed here:
> https://people.apache.org/keys/committer/abti.asc
>
> The release candidate has been tagged with release-0.12.0-rc3.
> I've also created a branch 0.12.0.
>
> For reference, here is a list of all closed JIRAs tagged with 0.12.0:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20GOBBLIN%20AND%20fixVersion%20%3D%200.12.0%20AND%20status%20in%20(Closed%2C%20Resolved)%20ORDER%20BY%20updatedDate%20DESC%2C%20createdDate%20DESC%2C%20status%20DESC%2C%20priority%20DESC
>
>
> For a summary of the changes in this release, see:
> https://github.com/apache/incubator-gobblin/blob/0.12.0/CHANGELOG.md
>
> Please review and vote. The vote will be open for 72 hours.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Thanks,
> Abhishek, on behalf of the Apache Gobblin PPMC
>
>
[VOTE] Apache Gobblin 0.12.0 release RC3
Posted by Abhishek Tiwari <ab...@apache.org>.
The Apache Gobblin community has voted on and approved the release of
Apache Gobblin 0.12.0 (incubating):
https://www.mail-archive.com/dev@gobblin.incubator.apache.org/msg01981.html
Results:
5 binding +1 votes
1 non-binding +1 vote
No 0 votes
No -1 votes
The feedback from previous release candidates has been addressed:
RC0 thread: https://www.mail-archive.com/general@incubator.apache
.org/msg62151.html
RC0 resolution: LICENSE and NOTICE files have been updated (tracked by
GOBBLIN-431 <https://issues.apache.org/jira/browse/GOBBLIN-431>)
RC1 thread: https://www.mail-archive.com/dev@gobblin.incubator.apache
.org/msg01733.html
RC1 resolution: gradlew scripts have been included in the source
distribution, and the steps for building the distribution has been added to
README (including the way to obtain gradlew jar)
RC 2 thread: https://mail-archives.apache
.org/mod_mbox/incubator-general/201804.mbox/%3CCAD+38UAE+Cpv3syCYH1RHGLbdHNqZHPfVh3YS6g=Qxhhb8n3fg@mail.gmail.com%3E
RC 2 resolution: This release candidate (RC3) has been cut with Justin's
changes to NOTICE file to make it Apache compliant
I'd like to call a vote in general to approve the release.
The source release candidate RC3 can be downloaded here:
https://dist.apache.org/repos/dist/dev/incubator/gobblin/apache-gobblin
-incubating-0.12.0-rc3/
The artifacts (i.e. JARs) corresponding to this release candidate can be
found here:
https://repository.apache.org/content/repositories/orgapachegobblin-1003
This has been signed with PGP key 234E3FE3, corresponding to
abti@apache.org, which is included in the repository's KEYS file (
https://dist.apache.org/repos/dist/release/incubator/gobblin/KEYS). This
key can be found on keyservers, such as:
*http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3
<http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3>*
It is also listed here:
https://people.apache.org/keys/committer/abti.asc
The release candidate has been tagged with release-0.12.0-rc3.
I've also created a branch 0.12.0.
For reference, here is a list of all closed JIRAs tagged with 0.12.0:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20GOBBLIN%20AND%20fixVersion%20%3D%200.12.0%20AND%20status%20in%20(Closed%2C%20Resolved)%20ORDER%20BY%20updatedDate%20DESC%2C%20createdDate%20DESC%2C%20status%20DESC%2C%20priority%20DESC
For a summary of the changes in this release, see:
https://github.com/apache/incubator-gobblin/blob/0.12.0/CHANGELOG.md
Please review and vote. The vote will be open for 72 hours.
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)
Thanks,
Abhishek, on behalf of the Apache Gobblin PPMC
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Matt Sicker <bo...@gmail.com>.
+1 (binding)
* Signatures ok
* Rat check ok
* Build and tests ok
* Disclaimer, License, and Notice ok
On 30 March 2018 at 05:57, Olivier Lamy <ol...@apache.org> wrote:
> Hi,
> I wonder if we could get some review/votes from other IPMCs?
> We still need 2 more votes.
> Thanks
> Olivier
>
>
> On Wed, 28 Mar 2018 at 09:10, Matt Sicker <bo...@gmail.com> wrote:
>
> > It's not a deal breaker IMO, just a difficulty in getting set up.
> >
> > On 27 March 2018 at 16:32, Abhishek Tiwari <ab...@apache.org> wrote:
> >
> > > Thanks Matt for pointing that out, good to know. I have created a Jira
> to
> > > consider that option: https://issues.apache.org/
> jira/browse/GOBBLIN-449
> > > However, I am wondering if this is a deal breaker for the release? Or,
> > can
> > > we use the current process that we have adopted since it works well for
> > our
> > > users, and follows a pre-existing Apache model of Apache Fineract.
> > >
> > > Abhishek
> > >
> > > On Tue, Mar 27, 2018 at 10:44 AM, Matthew Hayes <
> > > matthew.terence.hayes@gmail.com> wrote:
> > >
> > > > Abhishek, what about using a bootstrap gradle task to download the
> jar
> > > and
> > > > gradlew? DataFu does this [1], which was based on Samza's solution.
> > You
> > > > just need to have some version of gradle installed and can run
> `gradle
> > -b
> > > > bootstrap.gradle`. Then you don't need the jar or gradlew checked
> in.
> > > >
> > > > -Matt
> > > >
> > > > [1]https://github.com/apache/datafu/blob/master/bootstrap.gradle
> > > >
> > > > On Tue, Mar 27, 2018 at 10:30 AM, Abhishek Tiwari <ab...@apache.org>
> > > wrote:
> > > >
> > > > > Yes, I understand that gradle-wrapper.jar is a convenience jar that
> > > helps
> > > > > get the gradle.
> > > > > However, we could not include it in the distribution because it is
> > not
> > > > > acceptable to include binaries and instead we went with the
> proposed
> > > > > resolution in this thread:
> > > > > https://issues.apache.org/jira/browse/LEGAL-288?
> > > > focusedCommentId=15980830&
> > > > > page=com.atlassian.jira.plugin.system.issuetabpanels%
> > > > > 3Acomment-tabpanel#comment-15980830
> > > > >
> > > > >
> > > > > This is (almost) exactly the same as what Apache Fineract does to
> > > address
> > > > > the same:
> > > > > - https://github.com/apache/fineract/blob/develop/README.md
> > > > > -
> > > > > https://www.mail-archive.com/dev@gobblin.incubator.apache.
> > > > > org/msg01727.html
> > > > > I like the Fineract model, especially because it requires only one
> > > extra
> > > > > step than what would be required otherwise to build the
> distribution.
> > > > > However, we will continue to improve upon the build process in
> > future.
> > > > >
> > > > > We have not moved to newer versions of gradle yet, and we specify
> the
> > > > > gradle version requirement in README.md.
> > > > >
> > > > > Abhishek
> > > > >
> > > > > On Tue, Mar 27, 2018 at 10:06 AM, Matt Sicker <bo...@gmail.com>
> > > wrote:
> > > > >
> > > > > > I'd suggest not including gradlew and gradlew.bat in your source
> > > > > > distribution then. You are aware that gradle-wrapper.jar is
> itself
> > a
> > > > > > bootstrap jar to get gradle itself, right? It's tiny and
> generally
> > > > > bundled
> > > > > > with source code for convenience. As an aside, in order to
> > regenerate
> > > > the
> > > > > > gradle wrapper the normal way (gradle wrapper --gradle-version
> > > 2.13), I
> > > > > had
> > > > > > to run it outside the project since the latest version of gradle
> is
> > > > > > incompatible, too. :/
> > > > > >
> > > > > > On 27 March 2018 at 11:46, Abhishek Tiwari <ab...@apache.org>
> > wrote:
> > > > > >
> > > > > > > Hi Matt,
> > > > > > >
> > > > > > > Thanks for checking. We intentionally do not bundle
> > > > gradle-wrapper.jar,
> > > > > > and
> > > > > > > instead document the steps to obtain it and build.
> > > > > > > Please check the included README.md file.
> > > > > > >
> > > > > > > Regards,
> > > > > > > Abhishek
> > > > > > >
> > > > > > > On Tue, Mar 27, 2018 at 8:18 AM, Matt Sicker <boards@gmail.com
> >
> > > > wrote:
> > > > > > >
> > > > > > > > The bundled gradle wrapper in the source tgz doesn't work. It
> > > > appears
> > > > > > to
> > > > > > > be
> > > > > > > > missing gradle/wrapper/gradle-wrapper.jar
> > > > > > > >
> > > > > > > > On 26 March 2018 at 19:01, Abhishek Tiwari <ab...@apache.org>
> > > > wrote:
> > > > > > > >
> > > > > > > > > The Apache Gobblin community has voted on and approved the
> > > > release
> > > > > of
> > > > > > > > > Apache Gobblin 0.12.0 (incubating):
> > > > > > > > >
> > > > > > > > > https://www.mail-archive.com/dev@gobblin.incubator.apache.
> > > > > > > > > org/msg01772.html
> > > > > > > > >
> > > > > > > > > Results:
> > > > > > > > > 5 binding +1 votes
> > > > > > > > > No 0 votes
> > > > > > > > > No -1 votes
> > > > > > > > >
> > > > > > > > > The feedback from previous release candidates has been
> > > addressed:
> > > > > > > > > RC0 thread: https://www.mail-archive.com/general@incubator
> .
> > > > > > > > > apache.org/msg62151.html
> > > > > > > > > RC0 resolution: LICENSE and NOTICE files have been updated
> > > > (tracked
> > > > > > by
> > > > > > > > > GOBBLIN-431 <
> > https://issues.apache.org/jira/browse/GOBBLIN-431
> > > >)
> > > > > > > > > RC1 thread: https://www.mail-archive.com/dev@gobblin.
> > > > > > > > > incubator.apache.org/msg01733.html
> > > > > > > > > RC1 resolution: gradlew scripts have been included in the
> > > source
> > > > > > > > > distribution, and the steps for building the distribution
> has
> > > > been
> > > > > > > added
> > > > > > > > to
> > > > > > > > > README (including the way to obtain gradlew jar)
> > > > > > > > >
> > > > > > > > > I'd like to call a vote in general to approve the release.
> > > > > > > > >
> > > > > > > > > The source release candidate RC2 can be downloaded here:
> > > > > > > > >
> > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/gobblin/
> > > > > > > > > apache-gobblin-incubating-0.12.0-rc2/
> > > > > > > > >
> > > > > > > > > The artifacts (i.e. JARs) corresponding to this release
> > > candidate
> > > > > can
> > > > > > > be
> > > > > > > > > found here:
> > > > > > > > >
> > > > > > > > > https://repository.apache.org/content/repositories/
> > > > > > > orgapachegobblin-1002
> > > > > > > > >
> > > > > > > > > This has been signed with PGP key 234E3FE3, corresponding
> to
> > > > > > > > > abti@apache.org, which is included in the repository's
> KEYS
> > > > file (
> > > > > > > > > https://dist.apache.org/repos/dist/release/incubator/
> > > > gobblin/KEYS
> > > > > ).
> > > > > > > > This
> > > > > > > > > key can be found on keyservers, such as:
> > > > > > > > >
> > > > > > > > > *http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3
> > > > > > > > > <http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3>*
> > > > > > > > >
> > > > > > > > > It is also listed here:
> > > > > > > > >
> > > > > > > > > https://people.apache.org/keys/committer/abti.asc
> > > > > > > > >
> > > > > > > > > The release candidate has been tagged with
> > release-0.12.0-rc2.
> > > > > > > > > I've also created a branch 0.12.0.
> > > > > > > > >
> > > > > > > > > For reference, here is a list of all closed JIRAs tagged
> with
> > > > > 0.12.0:
> > > > > > > > >
> > > > > > > > > https://issues.apache.org/jira/issues/?jql=project%20%
> > > > > > > > 3D%20GOBBLIN%20AND%
> > > > > > > > > 20fixVersion%20%3D%200.12.0%20AND%20status%20in%20(Closed%
> > > > > > > > > 2C%20Resolved)%20ORDER%20BY%20updatedDate%20DESC%2C%
> > > > > > > > > 20createdDate%20DESC%2C%
> > > > > > > > > 20status%20DESC%2C%20priority%20DESC
> > > > > > > > >
> > > > > > > > > For a summary of the changes in this release, see:
> > > > > > > > >
> > > > > > > > > https://github.com/apache/incubator-gobblin/blob/0.12.0/
> > > > > CHANGELOG.md
> > > > > > > > >
> > > > > > > > > Please review and vote. The vote will be open for 72 hours.
> > > > > > > > >
> > > > > > > > > [ ] +1 approve
> > > > > > > > > [ ] +0 no opinion
> > > > > > > > > [ ] -1 disapprove (and reason why)
> > > > > > > > >
> > > > > > > > > Thanks,
> > > > > > > > > Abhishek, on behalf of the Apache Gobblin PPMC
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Matt Sicker <bo...@gmail.com>
> > > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Matt Sicker <bo...@gmail.com>
> > > > > >
> > > > >
> > > >
> > >
> >
> >
> >
> > --
> > Matt Sicker <bo...@gmail.com>
> >
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
--
Matt Sicker <bo...@gmail.com>
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Olivier Lamy <ol...@apache.org>.
Hi,
I wonder if we could get some review/votes from other IPMCs?
We still need 2 more votes.
Thanks
Olivier
On Wed, 28 Mar 2018 at 09:10, Matt Sicker <bo...@gmail.com> wrote:
> It's not a deal breaker IMO, just a difficulty in getting set up.
>
> On 27 March 2018 at 16:32, Abhishek Tiwari <ab...@apache.org> wrote:
>
> > Thanks Matt for pointing that out, good to know. I have created a Jira to
> > consider that option: https://issues.apache.org/jira/browse/GOBBLIN-449
> > However, I am wondering if this is a deal breaker for the release? Or,
> can
> > we use the current process that we have adopted since it works well for
> our
> > users, and follows a pre-existing Apache model of Apache Fineract.
> >
> > Abhishek
> >
> > On Tue, Mar 27, 2018 at 10:44 AM, Matthew Hayes <
> > matthew.terence.hayes@gmail.com> wrote:
> >
> > > Abhishek, what about using a bootstrap gradle task to download the jar
> > and
> > > gradlew? DataFu does this [1], which was based on Samza's solution.
> You
> > > just need to have some version of gradle installed and can run `gradle
> -b
> > > bootstrap.gradle`. Then you don't need the jar or gradlew checked in.
> > >
> > > -Matt
> > >
> > > [1]https://github.com/apache/datafu/blob/master/bootstrap.gradle
> > >
> > > On Tue, Mar 27, 2018 at 10:30 AM, Abhishek Tiwari <ab...@apache.org>
> > wrote:
> > >
> > > > Yes, I understand that gradle-wrapper.jar is a convenience jar that
> > helps
> > > > get the gradle.
> > > > However, we could not include it in the distribution because it is
> not
> > > > acceptable to include binaries and instead we went with the proposed
> > > > resolution in this thread:
> > > > https://issues.apache.org/jira/browse/LEGAL-288?
> > > focusedCommentId=15980830&
> > > > page=com.atlassian.jira.plugin.system.issuetabpanels%
> > > > 3Acomment-tabpanel#comment-15980830
> > > >
> > > >
> > > > This is (almost) exactly the same as what Apache Fineract does to
> > address
> > > > the same:
> > > > - https://github.com/apache/fineract/blob/develop/README.md
> > > > -
> > > > https://www.mail-archive.com/dev@gobblin.incubator.apache.
> > > > org/msg01727.html
> > > > I like the Fineract model, especially because it requires only one
> > extra
> > > > step than what would be required otherwise to build the distribution.
> > > > However, we will continue to improve upon the build process in
> future.
> > > >
> > > > We have not moved to newer versions of gradle yet, and we specify the
> > > > gradle version requirement in README.md.
> > > >
> > > > Abhishek
> > > >
> > > > On Tue, Mar 27, 2018 at 10:06 AM, Matt Sicker <bo...@gmail.com>
> > wrote:
> > > >
> > > > > I'd suggest not including gradlew and gradlew.bat in your source
> > > > > distribution then. You are aware that gradle-wrapper.jar is itself
> a
> > > > > bootstrap jar to get gradle itself, right? It's tiny and generally
> > > > bundled
> > > > > with source code for convenience. As an aside, in order to
> regenerate
> > > the
> > > > > gradle wrapper the normal way (gradle wrapper --gradle-version
> > 2.13), I
> > > > had
> > > > > to run it outside the project since the latest version of gradle is
> > > > > incompatible, too. :/
> > > > >
> > > > > On 27 March 2018 at 11:46, Abhishek Tiwari <ab...@apache.org>
> wrote:
> > > > >
> > > > > > Hi Matt,
> > > > > >
> > > > > > Thanks for checking. We intentionally do not bundle
> > > gradle-wrapper.jar,
> > > > > and
> > > > > > instead document the steps to obtain it and build.
> > > > > > Please check the included README.md file.
> > > > > >
> > > > > > Regards,
> > > > > > Abhishek
> > > > > >
> > > > > > On Tue, Mar 27, 2018 at 8:18 AM, Matt Sicker <bo...@gmail.com>
> > > wrote:
> > > > > >
> > > > > > > The bundled gradle wrapper in the source tgz doesn't work. It
> > > appears
> > > > > to
> > > > > > be
> > > > > > > missing gradle/wrapper/gradle-wrapper.jar
> > > > > > >
> > > > > > > On 26 March 2018 at 19:01, Abhishek Tiwari <ab...@apache.org>
> > > wrote:
> > > > > > >
> > > > > > > > The Apache Gobblin community has voted on and approved the
> > > release
> > > > of
> > > > > > > > Apache Gobblin 0.12.0 (incubating):
> > > > > > > >
> > > > > > > > https://www.mail-archive.com/dev@gobblin.incubator.apache.
> > > > > > > > org/msg01772.html
> > > > > > > >
> > > > > > > > Results:
> > > > > > > > 5 binding +1 votes
> > > > > > > > No 0 votes
> > > > > > > > No -1 votes
> > > > > > > >
> > > > > > > > The feedback from previous release candidates has been
> > addressed:
> > > > > > > > RC0 thread: https://www.mail-archive.com/general@incubator.
> > > > > > > > apache.org/msg62151.html
> > > > > > > > RC0 resolution: LICENSE and NOTICE files have been updated
> > > (tracked
> > > > > by
> > > > > > > > GOBBLIN-431 <
> https://issues.apache.org/jira/browse/GOBBLIN-431
> > >)
> > > > > > > > RC1 thread: https://www.mail-archive.com/dev@gobblin.
> > > > > > > > incubator.apache.org/msg01733.html
> > > > > > > > RC1 resolution: gradlew scripts have been included in the
> > source
> > > > > > > > distribution, and the steps for building the distribution has
> > > been
> > > > > > added
> > > > > > > to
> > > > > > > > README (including the way to obtain gradlew jar)
> > > > > > > >
> > > > > > > > I'd like to call a vote in general to approve the release.
> > > > > > > >
> > > > > > > > The source release candidate RC2 can be downloaded here:
> > > > > > > >
> > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/gobblin/
> > > > > > > > apache-gobblin-incubating-0.12.0-rc2/
> > > > > > > >
> > > > > > > > The artifacts (i.e. JARs) corresponding to this release
> > candidate
> > > > can
> > > > > > be
> > > > > > > > found here:
> > > > > > > >
> > > > > > > > https://repository.apache.org/content/repositories/
> > > > > > orgapachegobblin-1002
> > > > > > > >
> > > > > > > > This has been signed with PGP key 234E3FE3, corresponding to
> > > > > > > > abti@apache.org, which is included in the repository's KEYS
> > > file (
> > > > > > > > https://dist.apache.org/repos/dist/release/incubator/
> > > gobblin/KEYS
> > > > ).
> > > > > > > This
> > > > > > > > key can be found on keyservers, such as:
> > > > > > > >
> > > > > > > > *http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3
> > > > > > > > <http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3>*
> > > > > > > >
> > > > > > > > It is also listed here:
> > > > > > > >
> > > > > > > > https://people.apache.org/keys/committer/abti.asc
> > > > > > > >
> > > > > > > > The release candidate has been tagged with
> release-0.12.0-rc2.
> > > > > > > > I've also created a branch 0.12.0.
> > > > > > > >
> > > > > > > > For reference, here is a list of all closed JIRAs tagged with
> > > > 0.12.0:
> > > > > > > >
> > > > > > > > https://issues.apache.org/jira/issues/?jql=project%20%
> > > > > > > 3D%20GOBBLIN%20AND%
> > > > > > > > 20fixVersion%20%3D%200.12.0%20AND%20status%20in%20(Closed%
> > > > > > > > 2C%20Resolved)%20ORDER%20BY%20updatedDate%20DESC%2C%
> > > > > > > > 20createdDate%20DESC%2C%
> > > > > > > > 20status%20DESC%2C%20priority%20DESC
> > > > > > > >
> > > > > > > > For a summary of the changes in this release, see:
> > > > > > > >
> > > > > > > > https://github.com/apache/incubator-gobblin/blob/0.12.0/
> > > > CHANGELOG.md
> > > > > > > >
> > > > > > > > Please review and vote. The vote will be open for 72 hours.
> > > > > > > >
> > > > > > > > [ ] +1 approve
> > > > > > > > [ ] +0 no opinion
> > > > > > > > [ ] -1 disapprove (and reason why)
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > > Abhishek, on behalf of the Apache Gobblin PPMC
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Matt Sicker <bo...@gmail.com>
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matt Sicker <bo...@gmail.com>
> > > > >
> > > >
> > >
> >
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Matt Sicker <bo...@gmail.com>.
It's not a deal breaker IMO, just a difficulty in getting set up.
On 27 March 2018 at 16:32, Abhishek Tiwari <ab...@apache.org> wrote:
> Thanks Matt for pointing that out, good to know. I have created a Jira to
> consider that option: https://issues.apache.org/jira/browse/GOBBLIN-449
> However, I am wondering if this is a deal breaker for the release? Or, can
> we use the current process that we have adopted since it works well for our
> users, and follows a pre-existing Apache model of Apache Fineract.
>
> Abhishek
>
> On Tue, Mar 27, 2018 at 10:44 AM, Matthew Hayes <
> matthew.terence.hayes@gmail.com> wrote:
>
> > Abhishek, what about using a bootstrap gradle task to download the jar
> and
> > gradlew? DataFu does this [1], which was based on Samza's solution. You
> > just need to have some version of gradle installed and can run `gradle -b
> > bootstrap.gradle`. Then you don't need the jar or gradlew checked in.
> >
> > -Matt
> >
> > [1]https://github.com/apache/datafu/blob/master/bootstrap.gradle
> >
> > On Tue, Mar 27, 2018 at 10:30 AM, Abhishek Tiwari <ab...@apache.org>
> wrote:
> >
> > > Yes, I understand that gradle-wrapper.jar is a convenience jar that
> helps
> > > get the gradle.
> > > However, we could not include it in the distribution because it is not
> > > acceptable to include binaries and instead we went with the proposed
> > > resolution in this thread:
> > > https://issues.apache.org/jira/browse/LEGAL-288?
> > focusedCommentId=15980830&
> > > page=com.atlassian.jira.plugin.system.issuetabpanels%
> > > 3Acomment-tabpanel#comment-15980830
> > >
> > >
> > > This is (almost) exactly the same as what Apache Fineract does to
> address
> > > the same:
> > > - https://github.com/apache/fineract/blob/develop/README.md
> > > -
> > > https://www.mail-archive.com/dev@gobblin.incubator.apache.
> > > org/msg01727.html
> > > I like the Fineract model, especially because it requires only one
> extra
> > > step than what would be required otherwise to build the distribution.
> > > However, we will continue to improve upon the build process in future.
> > >
> > > We have not moved to newer versions of gradle yet, and we specify the
> > > gradle version requirement in README.md.
> > >
> > > Abhishek
> > >
> > > On Tue, Mar 27, 2018 at 10:06 AM, Matt Sicker <bo...@gmail.com>
> wrote:
> > >
> > > > I'd suggest not including gradlew and gradlew.bat in your source
> > > > distribution then. You are aware that gradle-wrapper.jar is itself a
> > > > bootstrap jar to get gradle itself, right? It's tiny and generally
> > > bundled
> > > > with source code for convenience. As an aside, in order to regenerate
> > the
> > > > gradle wrapper the normal way (gradle wrapper --gradle-version
> 2.13), I
> > > had
> > > > to run it outside the project since the latest version of gradle is
> > > > incompatible, too. :/
> > > >
> > > > On 27 March 2018 at 11:46, Abhishek Tiwari <ab...@apache.org> wrote:
> > > >
> > > > > Hi Matt,
> > > > >
> > > > > Thanks for checking. We intentionally do not bundle
> > gradle-wrapper.jar,
> > > > and
> > > > > instead document the steps to obtain it and build.
> > > > > Please check the included README.md file.
> > > > >
> > > > > Regards,
> > > > > Abhishek
> > > > >
> > > > > On Tue, Mar 27, 2018 at 8:18 AM, Matt Sicker <bo...@gmail.com>
> > wrote:
> > > > >
> > > > > > The bundled gradle wrapper in the source tgz doesn't work. It
> > appears
> > > > to
> > > > > be
> > > > > > missing gradle/wrapper/gradle-wrapper.jar
> > > > > >
> > > > > > On 26 March 2018 at 19:01, Abhishek Tiwari <ab...@apache.org>
> > wrote:
> > > > > >
> > > > > > > The Apache Gobblin community has voted on and approved the
> > release
> > > of
> > > > > > > Apache Gobblin 0.12.0 (incubating):
> > > > > > >
> > > > > > > https://www.mail-archive.com/dev@gobblin.incubator.apache.
> > > > > > > org/msg01772.html
> > > > > > >
> > > > > > > Results:
> > > > > > > 5 binding +1 votes
> > > > > > > No 0 votes
> > > > > > > No -1 votes
> > > > > > >
> > > > > > > The feedback from previous release candidates has been
> addressed:
> > > > > > > RC0 thread: https://www.mail-archive.com/general@incubator.
> > > > > > > apache.org/msg62151.html
> > > > > > > RC0 resolution: LICENSE and NOTICE files have been updated
> > (tracked
> > > > by
> > > > > > > GOBBLIN-431 <https://issues.apache.org/jira/browse/GOBBLIN-431
> >)
> > > > > > > RC1 thread: https://www.mail-archive.com/dev@gobblin.
> > > > > > > incubator.apache.org/msg01733.html
> > > > > > > RC1 resolution: gradlew scripts have been included in the
> source
> > > > > > > distribution, and the steps for building the distribution has
> > been
> > > > > added
> > > > > > to
> > > > > > > README (including the way to obtain gradlew jar)
> > > > > > >
> > > > > > > I'd like to call a vote in general to approve the release.
> > > > > > >
> > > > > > > The source release candidate RC2 can be downloaded here:
> > > > > > >
> > > > > > > https://dist.apache.org/repos/dist/dev/incubator/gobblin/
> > > > > > > apache-gobblin-incubating-0.12.0-rc2/
> > > > > > >
> > > > > > > The artifacts (i.e. JARs) corresponding to this release
> candidate
> > > can
> > > > > be
> > > > > > > found here:
> > > > > > >
> > > > > > > https://repository.apache.org/content/repositories/
> > > > > orgapachegobblin-1002
> > > > > > >
> > > > > > > This has been signed with PGP key 234E3FE3, corresponding to
> > > > > > > abti@apache.org, which is included in the repository's KEYS
> > file (
> > > > > > > https://dist.apache.org/repos/dist/release/incubator/
> > gobblin/KEYS
> > > ).
> > > > > > This
> > > > > > > key can be found on keyservers, such as:
> > > > > > >
> > > > > > > *http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3
> > > > > > > <http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3>*
> > > > > > >
> > > > > > > It is also listed here:
> > > > > > >
> > > > > > > https://people.apache.org/keys/committer/abti.asc
> > > > > > >
> > > > > > > The release candidate has been tagged with release-0.12.0-rc2.
> > > > > > > I've also created a branch 0.12.0.
> > > > > > >
> > > > > > > For reference, here is a list of all closed JIRAs tagged with
> > > 0.12.0:
> > > > > > >
> > > > > > > https://issues.apache.org/jira/issues/?jql=project%20%
> > > > > > 3D%20GOBBLIN%20AND%
> > > > > > > 20fixVersion%20%3D%200.12.0%20AND%20status%20in%20(Closed%
> > > > > > > 2C%20Resolved)%20ORDER%20BY%20updatedDate%20DESC%2C%
> > > > > > > 20createdDate%20DESC%2C%
> > > > > > > 20status%20DESC%2C%20priority%20DESC
> > > > > > >
> > > > > > > For a summary of the changes in this release, see:
> > > > > > >
> > > > > > > https://github.com/apache/incubator-gobblin/blob/0.12.0/
> > > CHANGELOG.md
> > > > > > >
> > > > > > > Please review and vote. The vote will be open for 72 hours.
> > > > > > >
> > > > > > > [ ] +1 approve
> > > > > > > [ ] +0 no opinion
> > > > > > > [ ] -1 disapprove (and reason why)
> > > > > > >
> > > > > > > Thanks,
> > > > > > > Abhishek, on behalf of the Apache Gobblin PPMC
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Matt Sicker <bo...@gmail.com>
> > > > > >
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Matt Sicker <bo...@gmail.com>
> > > >
> > >
> >
>
--
Matt Sicker <bo...@gmail.com>
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Abhishek Tiwari <ab...@apache.org>.
Thanks Matt for pointing that out, good to know. I have created a Jira to
consider that option: https://issues.apache.org/jira/browse/GOBBLIN-449
However, I am wondering if this is a deal breaker for the release? Or, can
we use the current process that we have adopted since it works well for our
users, and follows a pre-existing Apache model of Apache Fineract.
Abhishek
On Tue, Mar 27, 2018 at 10:44 AM, Matthew Hayes <
matthew.terence.hayes@gmail.com> wrote:
> Abhishek, what about using a bootstrap gradle task to download the jar and
> gradlew? DataFu does this [1], which was based on Samza's solution. You
> just need to have some version of gradle installed and can run `gradle -b
> bootstrap.gradle`. Then you don't need the jar or gradlew checked in.
>
> -Matt
>
> [1]https://github.com/apache/datafu/blob/master/bootstrap.gradle
>
> On Tue, Mar 27, 2018 at 10:30 AM, Abhishek Tiwari <ab...@apache.org> wrote:
>
> > Yes, I understand that gradle-wrapper.jar is a convenience jar that helps
> > get the gradle.
> > However, we could not include it in the distribution because it is not
> > acceptable to include binaries and instead we went with the proposed
> > resolution in this thread:
> > https://issues.apache.org/jira/browse/LEGAL-288?
> focusedCommentId=15980830&
> > page=com.atlassian.jira.plugin.system.issuetabpanels%
> > 3Acomment-tabpanel#comment-15980830
> >
> >
> > This is (almost) exactly the same as what Apache Fineract does to address
> > the same:
> > - https://github.com/apache/fineract/blob/develop/README.md
> > -
> > https://www.mail-archive.com/dev@gobblin.incubator.apache.
> > org/msg01727.html
> > I like the Fineract model, especially because it requires only one extra
> > step than what would be required otherwise to build the distribution.
> > However, we will continue to improve upon the build process in future.
> >
> > We have not moved to newer versions of gradle yet, and we specify the
> > gradle version requirement in README.md.
> >
> > Abhishek
> >
> > On Tue, Mar 27, 2018 at 10:06 AM, Matt Sicker <bo...@gmail.com> wrote:
> >
> > > I'd suggest not including gradlew and gradlew.bat in your source
> > > distribution then. You are aware that gradle-wrapper.jar is itself a
> > > bootstrap jar to get gradle itself, right? It's tiny and generally
> > bundled
> > > with source code for convenience. As an aside, in order to regenerate
> the
> > > gradle wrapper the normal way (gradle wrapper --gradle-version 2.13), I
> > had
> > > to run it outside the project since the latest version of gradle is
> > > incompatible, too. :/
> > >
> > > On 27 March 2018 at 11:46, Abhishek Tiwari <ab...@apache.org> wrote:
> > >
> > > > Hi Matt,
> > > >
> > > > Thanks for checking. We intentionally do not bundle
> gradle-wrapper.jar,
> > > and
> > > > instead document the steps to obtain it and build.
> > > > Please check the included README.md file.
> > > >
> > > > Regards,
> > > > Abhishek
> > > >
> > > > On Tue, Mar 27, 2018 at 8:18 AM, Matt Sicker <bo...@gmail.com>
> wrote:
> > > >
> > > > > The bundled gradle wrapper in the source tgz doesn't work. It
> appears
> > > to
> > > > be
> > > > > missing gradle/wrapper/gradle-wrapper.jar
> > > > >
> > > > > On 26 March 2018 at 19:01, Abhishek Tiwari <ab...@apache.org>
> wrote:
> > > > >
> > > > > > The Apache Gobblin community has voted on and approved the
> release
> > of
> > > > > > Apache Gobblin 0.12.0 (incubating):
> > > > > >
> > > > > > https://www.mail-archive.com/dev@gobblin.incubator.apache.
> > > > > > org/msg01772.html
> > > > > >
> > > > > > Results:
> > > > > > 5 binding +1 votes
> > > > > > No 0 votes
> > > > > > No -1 votes
> > > > > >
> > > > > > The feedback from previous release candidates has been addressed:
> > > > > > RC0 thread: https://www.mail-archive.com/general@incubator.
> > > > > > apache.org/msg62151.html
> > > > > > RC0 resolution: LICENSE and NOTICE files have been updated
> (tracked
> > > by
> > > > > > GOBBLIN-431 <https://issues.apache.org/jira/browse/GOBBLIN-431>)
> > > > > > RC1 thread: https://www.mail-archive.com/dev@gobblin.
> > > > > > incubator.apache.org/msg01733.html
> > > > > > RC1 resolution: gradlew scripts have been included in the source
> > > > > > distribution, and the steps for building the distribution has
> been
> > > > added
> > > > > to
> > > > > > README (including the way to obtain gradlew jar)
> > > > > >
> > > > > > I'd like to call a vote in general to approve the release.
> > > > > >
> > > > > > The source release candidate RC2 can be downloaded here:
> > > > > >
> > > > > > https://dist.apache.org/repos/dist/dev/incubator/gobblin/
> > > > > > apache-gobblin-incubating-0.12.0-rc2/
> > > > > >
> > > > > > The artifacts (i.e. JARs) corresponding to this release candidate
> > can
> > > > be
> > > > > > found here:
> > > > > >
> > > > > > https://repository.apache.org/content/repositories/
> > > > orgapachegobblin-1002
> > > > > >
> > > > > > This has been signed with PGP key 234E3FE3, corresponding to
> > > > > > abti@apache.org, which is included in the repository's KEYS
> file (
> > > > > > https://dist.apache.org/repos/dist/release/incubator/
> gobblin/KEYS
> > ).
> > > > > This
> > > > > > key can be found on keyservers, such as:
> > > > > >
> > > > > > *http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3
> > > > > > <http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3>*
> > > > > >
> > > > > > It is also listed here:
> > > > > >
> > > > > > https://people.apache.org/keys/committer/abti.asc
> > > > > >
> > > > > > The release candidate has been tagged with release-0.12.0-rc2.
> > > > > > I've also created a branch 0.12.0.
> > > > > >
> > > > > > For reference, here is a list of all closed JIRAs tagged with
> > 0.12.0:
> > > > > >
> > > > > > https://issues.apache.org/jira/issues/?jql=project%20%
> > > > > 3D%20GOBBLIN%20AND%
> > > > > > 20fixVersion%20%3D%200.12.0%20AND%20status%20in%20(Closed%
> > > > > > 2C%20Resolved)%20ORDER%20BY%20updatedDate%20DESC%2C%
> > > > > > 20createdDate%20DESC%2C%
> > > > > > 20status%20DESC%2C%20priority%20DESC
> > > > > >
> > > > > > For a summary of the changes in this release, see:
> > > > > >
> > > > > > https://github.com/apache/incubator-gobblin/blob/0.12.0/
> > CHANGELOG.md
> > > > > >
> > > > > > Please review and vote. The vote will be open for 72 hours.
> > > > > >
> > > > > > [ ] +1 approve
> > > > > > [ ] +0 no opinion
> > > > > > [ ] -1 disapprove (and reason why)
> > > > > >
> > > > > > Thanks,
> > > > > > Abhishek, on behalf of the Apache Gobblin PPMC
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matt Sicker <bo...@gmail.com>
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Matt Sicker <bo...@gmail.com>
> > >
> >
>
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Matthew Hayes <ma...@gmail.com>.
Abhishek, what about using a bootstrap gradle task to download the jar and
gradlew? DataFu does this [1], which was based on Samza's solution. You
just need to have some version of gradle installed and can run `gradle -b
bootstrap.gradle`. Then you don't need the jar or gradlew checked in.
-Matt
[1]https://github.com/apache/datafu/blob/master/bootstrap.gradle
On Tue, Mar 27, 2018 at 10:30 AM, Abhishek Tiwari <ab...@apache.org> wrote:
> Yes, I understand that gradle-wrapper.jar is a convenience jar that helps
> get the gradle.
> However, we could not include it in the distribution because it is not
> acceptable to include binaries and instead we went with the proposed
> resolution in this thread:
> https://issues.apache.org/jira/browse/LEGAL-288?focusedCommentId=15980830&
> page=com.atlassian.jira.plugin.system.issuetabpanels%
> 3Acomment-tabpanel#comment-15980830
>
>
> This is (almost) exactly the same as what Apache Fineract does to address
> the same:
> - https://github.com/apache/fineract/blob/develop/README.md
> -
> https://www.mail-archive.com/dev@gobblin.incubator.apache.
> org/msg01727.html
> I like the Fineract model, especially because it requires only one extra
> step than what would be required otherwise to build the distribution.
> However, we will continue to improve upon the build process in future.
>
> We have not moved to newer versions of gradle yet, and we specify the
> gradle version requirement in README.md.
>
> Abhishek
>
> On Tue, Mar 27, 2018 at 10:06 AM, Matt Sicker <bo...@gmail.com> wrote:
>
> > I'd suggest not including gradlew and gradlew.bat in your source
> > distribution then. You are aware that gradle-wrapper.jar is itself a
> > bootstrap jar to get gradle itself, right? It's tiny and generally
> bundled
> > with source code for convenience. As an aside, in order to regenerate the
> > gradle wrapper the normal way (gradle wrapper --gradle-version 2.13), I
> had
> > to run it outside the project since the latest version of gradle is
> > incompatible, too. :/
> >
> > On 27 March 2018 at 11:46, Abhishek Tiwari <ab...@apache.org> wrote:
> >
> > > Hi Matt,
> > >
> > > Thanks for checking. We intentionally do not bundle gradle-wrapper.jar,
> > and
> > > instead document the steps to obtain it and build.
> > > Please check the included README.md file.
> > >
> > > Regards,
> > > Abhishek
> > >
> > > On Tue, Mar 27, 2018 at 8:18 AM, Matt Sicker <bo...@gmail.com> wrote:
> > >
> > > > The bundled gradle wrapper in the source tgz doesn't work. It appears
> > to
> > > be
> > > > missing gradle/wrapper/gradle-wrapper.jar
> > > >
> > > > On 26 March 2018 at 19:01, Abhishek Tiwari <ab...@apache.org> wrote:
> > > >
> > > > > The Apache Gobblin community has voted on and approved the release
> of
> > > > > Apache Gobblin 0.12.0 (incubating):
> > > > >
> > > > > https://www.mail-archive.com/dev@gobblin.incubator.apache.
> > > > > org/msg01772.html
> > > > >
> > > > > Results:
> > > > > 5 binding +1 votes
> > > > > No 0 votes
> > > > > No -1 votes
> > > > >
> > > > > The feedback from previous release candidates has been addressed:
> > > > > RC0 thread: https://www.mail-archive.com/general@incubator.
> > > > > apache.org/msg62151.html
> > > > > RC0 resolution: LICENSE and NOTICE files have been updated (tracked
> > by
> > > > > GOBBLIN-431 <https://issues.apache.org/jira/browse/GOBBLIN-431>)
> > > > > RC1 thread: https://www.mail-archive.com/dev@gobblin.
> > > > > incubator.apache.org/msg01733.html
> > > > > RC1 resolution: gradlew scripts have been included in the source
> > > > > distribution, and the steps for building the distribution has been
> > > added
> > > > to
> > > > > README (including the way to obtain gradlew jar)
> > > > >
> > > > > I'd like to call a vote in general to approve the release.
> > > > >
> > > > > The source release candidate RC2 can be downloaded here:
> > > > >
> > > > > https://dist.apache.org/repos/dist/dev/incubator/gobblin/
> > > > > apache-gobblin-incubating-0.12.0-rc2/
> > > > >
> > > > > The artifacts (i.e. JARs) corresponding to this release candidate
> can
> > > be
> > > > > found here:
> > > > >
> > > > > https://repository.apache.org/content/repositories/
> > > orgapachegobblin-1002
> > > > >
> > > > > This has been signed with PGP key 234E3FE3, corresponding to
> > > > > abti@apache.org, which is included in the repository's KEYS file (
> > > > > https://dist.apache.org/repos/dist/release/incubator/gobblin/KEYS
> ).
> > > > This
> > > > > key can be found on keyservers, such as:
> > > > >
> > > > > *http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3
> > > > > <http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3>*
> > > > >
> > > > > It is also listed here:
> > > > >
> > > > > https://people.apache.org/keys/committer/abti.asc
> > > > >
> > > > > The release candidate has been tagged with release-0.12.0-rc2.
> > > > > I've also created a branch 0.12.0.
> > > > >
> > > > > For reference, here is a list of all closed JIRAs tagged with
> 0.12.0:
> > > > >
> > > > > https://issues.apache.org/jira/issues/?jql=project%20%
> > > > 3D%20GOBBLIN%20AND%
> > > > > 20fixVersion%20%3D%200.12.0%20AND%20status%20in%20(Closed%
> > > > > 2C%20Resolved)%20ORDER%20BY%20updatedDate%20DESC%2C%
> > > > > 20createdDate%20DESC%2C%
> > > > > 20status%20DESC%2C%20priority%20DESC
> > > > >
> > > > > For a summary of the changes in this release, see:
> > > > >
> > > > > https://github.com/apache/incubator-gobblin/blob/0.12.0/
> CHANGELOG.md
> > > > >
> > > > > Please review and vote. The vote will be open for 72 hours.
> > > > >
> > > > > [ ] +1 approve
> > > > > [ ] +0 no opinion
> > > > > [ ] -1 disapprove (and reason why)
> > > > >
> > > > > Thanks,
> > > > > Abhishek, on behalf of the Apache Gobblin PPMC
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Matt Sicker <bo...@gmail.com>
> > > >
> > >
> >
> >
> >
> > --
> > Matt Sicker <bo...@gmail.com>
> >
>
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Abhishek Tiwari <ab...@apache.org>.
Yes, I understand that gradle-wrapper.jar is a convenience jar that helps
get the gradle.
However, we could not include it in the distribution because it is not
acceptable to include binaries and instead we went with the proposed
resolution in this thread:
https://issues.apache.org/jira/browse/LEGAL-288?focusedCommentId=15980830&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-15980830
This is (almost) exactly the same as what Apache Fineract does to address
the same:
- https://github.com/apache/fineract/blob/develop/README.md
-
https://www.mail-archive.com/dev@gobblin.incubator.apache.org/msg01727.html
I like the Fineract model, especially because it requires only one extra
step than what would be required otherwise to build the distribution.
However, we will continue to improve upon the build process in future.
We have not moved to newer versions of gradle yet, and we specify the
gradle version requirement in README.md.
Abhishek
On Tue, Mar 27, 2018 at 10:06 AM, Matt Sicker <bo...@gmail.com> wrote:
> I'd suggest not including gradlew and gradlew.bat in your source
> distribution then. You are aware that gradle-wrapper.jar is itself a
> bootstrap jar to get gradle itself, right? It's tiny and generally bundled
> with source code for convenience. As an aside, in order to regenerate the
> gradle wrapper the normal way (gradle wrapper --gradle-version 2.13), I had
> to run it outside the project since the latest version of gradle is
> incompatible, too. :/
>
> On 27 March 2018 at 11:46, Abhishek Tiwari <ab...@apache.org> wrote:
>
> > Hi Matt,
> >
> > Thanks for checking. We intentionally do not bundle gradle-wrapper.jar,
> and
> > instead document the steps to obtain it and build.
> > Please check the included README.md file.
> >
> > Regards,
> > Abhishek
> >
> > On Tue, Mar 27, 2018 at 8:18 AM, Matt Sicker <bo...@gmail.com> wrote:
> >
> > > The bundled gradle wrapper in the source tgz doesn't work. It appears
> to
> > be
> > > missing gradle/wrapper/gradle-wrapper.jar
> > >
> > > On 26 March 2018 at 19:01, Abhishek Tiwari <ab...@apache.org> wrote:
> > >
> > > > The Apache Gobblin community has voted on and approved the release of
> > > > Apache Gobblin 0.12.0 (incubating):
> > > >
> > > > https://www.mail-archive.com/dev@gobblin.incubator.apache.
> > > > org/msg01772.html
> > > >
> > > > Results:
> > > > 5 binding +1 votes
> > > > No 0 votes
> > > > No -1 votes
> > > >
> > > > The feedback from previous release candidates has been addressed:
> > > > RC0 thread: https://www.mail-archive.com/general@incubator.
> > > > apache.org/msg62151.html
> > > > RC0 resolution: LICENSE and NOTICE files have been updated (tracked
> by
> > > > GOBBLIN-431 <https://issues.apache.org/jira/browse/GOBBLIN-431>)
> > > > RC1 thread: https://www.mail-archive.com/dev@gobblin.
> > > > incubator.apache.org/msg01733.html
> > > > RC1 resolution: gradlew scripts have been included in the source
> > > > distribution, and the steps for building the distribution has been
> > added
> > > to
> > > > README (including the way to obtain gradlew jar)
> > > >
> > > > I'd like to call a vote in general to approve the release.
> > > >
> > > > The source release candidate RC2 can be downloaded here:
> > > >
> > > > https://dist.apache.org/repos/dist/dev/incubator/gobblin/
> > > > apache-gobblin-incubating-0.12.0-rc2/
> > > >
> > > > The artifacts (i.e. JARs) corresponding to this release candidate can
> > be
> > > > found here:
> > > >
> > > > https://repository.apache.org/content/repositories/
> > orgapachegobblin-1002
> > > >
> > > > This has been signed with PGP key 234E3FE3, corresponding to
> > > > abti@apache.org, which is included in the repository's KEYS file (
> > > > https://dist.apache.org/repos/dist/release/incubator/gobblin/KEYS).
> > > This
> > > > key can be found on keyservers, such as:
> > > >
> > > > *http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3
> > > > <http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3>*
> > > >
> > > > It is also listed here:
> > > >
> > > > https://people.apache.org/keys/committer/abti.asc
> > > >
> > > > The release candidate has been tagged with release-0.12.0-rc2.
> > > > I've also created a branch 0.12.0.
> > > >
> > > > For reference, here is a list of all closed JIRAs tagged with 0.12.0:
> > > >
> > > > https://issues.apache.org/jira/issues/?jql=project%20%
> > > 3D%20GOBBLIN%20AND%
> > > > 20fixVersion%20%3D%200.12.0%20AND%20status%20in%20(Closed%
> > > > 2C%20Resolved)%20ORDER%20BY%20updatedDate%20DESC%2C%
> > > > 20createdDate%20DESC%2C%
> > > > 20status%20DESC%2C%20priority%20DESC
> > > >
> > > > For a summary of the changes in this release, see:
> > > >
> > > > https://github.com/apache/incubator-gobblin/blob/0.12.0/CHANGELOG.md
> > > >
> > > > Please review and vote. The vote will be open for 72 hours.
> > > >
> > > > [ ] +1 approve
> > > > [ ] +0 no opinion
> > > > [ ] -1 disapprove (and reason why)
> > > >
> > > > Thanks,
> > > > Abhishek, on behalf of the Apache Gobblin PPMC
> > > >
> > >
> > >
> > >
> > > --
> > > Matt Sicker <bo...@gmail.com>
> > >
> >
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Matt Sicker <bo...@gmail.com>.
I'd suggest not including gradlew and gradlew.bat in your source
distribution then. You are aware that gradle-wrapper.jar is itself a
bootstrap jar to get gradle itself, right? It's tiny and generally bundled
with source code for convenience. As an aside, in order to regenerate the
gradle wrapper the normal way (gradle wrapper --gradle-version 2.13), I had
to run it outside the project since the latest version of gradle is
incompatible, too. :/
On 27 March 2018 at 11:46, Abhishek Tiwari <ab...@apache.org> wrote:
> Hi Matt,
>
> Thanks for checking. We intentionally do not bundle gradle-wrapper.jar, and
> instead document the steps to obtain it and build.
> Please check the included README.md file.
>
> Regards,
> Abhishek
>
> On Tue, Mar 27, 2018 at 8:18 AM, Matt Sicker <bo...@gmail.com> wrote:
>
> > The bundled gradle wrapper in the source tgz doesn't work. It appears to
> be
> > missing gradle/wrapper/gradle-wrapper.jar
> >
> > On 26 March 2018 at 19:01, Abhishek Tiwari <ab...@apache.org> wrote:
> >
> > > The Apache Gobblin community has voted on and approved the release of
> > > Apache Gobblin 0.12.0 (incubating):
> > >
> > > https://www.mail-archive.com/dev@gobblin.incubator.apache.
> > > org/msg01772.html
> > >
> > > Results:
> > > 5 binding +1 votes
> > > No 0 votes
> > > No -1 votes
> > >
> > > The feedback from previous release candidates has been addressed:
> > > RC0 thread: https://www.mail-archive.com/general@incubator.
> > > apache.org/msg62151.html
> > > RC0 resolution: LICENSE and NOTICE files have been updated (tracked by
> > > GOBBLIN-431 <https://issues.apache.org/jira/browse/GOBBLIN-431>)
> > > RC1 thread: https://www.mail-archive.com/dev@gobblin.
> > > incubator.apache.org/msg01733.html
> > > RC1 resolution: gradlew scripts have been included in the source
> > > distribution, and the steps for building the distribution has been
> added
> > to
> > > README (including the way to obtain gradlew jar)
> > >
> > > I'd like to call a vote in general to approve the release.
> > >
> > > The source release candidate RC2 can be downloaded here:
> > >
> > > https://dist.apache.org/repos/dist/dev/incubator/gobblin/
> > > apache-gobblin-incubating-0.12.0-rc2/
> > >
> > > The artifacts (i.e. JARs) corresponding to this release candidate can
> be
> > > found here:
> > >
> > > https://repository.apache.org/content/repositories/
> orgapachegobblin-1002
> > >
> > > This has been signed with PGP key 234E3FE3, corresponding to
> > > abti@apache.org, which is included in the repository's KEYS file (
> > > https://dist.apache.org/repos/dist/release/incubator/gobblin/KEYS).
> > This
> > > key can be found on keyservers, such as:
> > >
> > > *http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3
> > > <http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3>*
> > >
> > > It is also listed here:
> > >
> > > https://people.apache.org/keys/committer/abti.asc
> > >
> > > The release candidate has been tagged with release-0.12.0-rc2.
> > > I've also created a branch 0.12.0.
> > >
> > > For reference, here is a list of all closed JIRAs tagged with 0.12.0:
> > >
> > > https://issues.apache.org/jira/issues/?jql=project%20%
> > 3D%20GOBBLIN%20AND%
> > > 20fixVersion%20%3D%200.12.0%20AND%20status%20in%20(Closed%
> > > 2C%20Resolved)%20ORDER%20BY%20updatedDate%20DESC%2C%
> > > 20createdDate%20DESC%2C%
> > > 20status%20DESC%2C%20priority%20DESC
> > >
> > > For a summary of the changes in this release, see:
> > >
> > > https://github.com/apache/incubator-gobblin/blob/0.12.0/CHANGELOG.md
> > >
> > > Please review and vote. The vote will be open for 72 hours.
> > >
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove (and reason why)
> > >
> > > Thanks,
> > > Abhishek, on behalf of the Apache Gobblin PPMC
> > >
> >
> >
> >
> > --
> > Matt Sicker <bo...@gmail.com>
> >
>
--
Matt Sicker <bo...@gmail.com>
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Abhishek Tiwari <ab...@apache.org>.
Hi Matt,
Thanks for checking. We intentionally do not bundle gradle-wrapper.jar, and
instead document the steps to obtain it and build.
Please check the included README.md file.
Regards,
Abhishek
On Tue, Mar 27, 2018 at 8:18 AM, Matt Sicker <bo...@gmail.com> wrote:
> The bundled gradle wrapper in the source tgz doesn't work. It appears to be
> missing gradle/wrapper/gradle-wrapper.jar
>
> On 26 March 2018 at 19:01, Abhishek Tiwari <ab...@apache.org> wrote:
>
> > The Apache Gobblin community has voted on and approved the release of
> > Apache Gobblin 0.12.0 (incubating):
> >
> > https://www.mail-archive.com/dev@gobblin.incubator.apache.
> > org/msg01772.html
> >
> > Results:
> > 5 binding +1 votes
> > No 0 votes
> > No -1 votes
> >
> > The feedback from previous release candidates has been addressed:
> > RC0 thread: https://www.mail-archive.com/general@incubator.
> > apache.org/msg62151.html
> > RC0 resolution: LICENSE and NOTICE files have been updated (tracked by
> > GOBBLIN-431 <https://issues.apache.org/jira/browse/GOBBLIN-431>)
> > RC1 thread: https://www.mail-archive.com/dev@gobblin.
> > incubator.apache.org/msg01733.html
> > RC1 resolution: gradlew scripts have been included in the source
> > distribution, and the steps for building the distribution has been added
> to
> > README (including the way to obtain gradlew jar)
> >
> > I'd like to call a vote in general to approve the release.
> >
> > The source release candidate RC2 can be downloaded here:
> >
> > https://dist.apache.org/repos/dist/dev/incubator/gobblin/
> > apache-gobblin-incubating-0.12.0-rc2/
> >
> > The artifacts (i.e. JARs) corresponding to this release candidate can be
> > found here:
> >
> > https://repository.apache.org/content/repositories/orgapachegobblin-1002
> >
> > This has been signed with PGP key 234E3FE3, corresponding to
> > abti@apache.org, which is included in the repository's KEYS file (
> > https://dist.apache.org/repos/dist/release/incubator/gobblin/KEYS).
> This
> > key can be found on keyservers, such as:
> >
> > *http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3
> > <http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3>*
> >
> > It is also listed here:
> >
> > https://people.apache.org/keys/committer/abti.asc
> >
> > The release candidate has been tagged with release-0.12.0-rc2.
> > I've also created a branch 0.12.0.
> >
> > For reference, here is a list of all closed JIRAs tagged with 0.12.0:
> >
> > https://issues.apache.org/jira/issues/?jql=project%20%
> 3D%20GOBBLIN%20AND%
> > 20fixVersion%20%3D%200.12.0%20AND%20status%20in%20(Closed%
> > 2C%20Resolved)%20ORDER%20BY%20updatedDate%20DESC%2C%
> > 20createdDate%20DESC%2C%
> > 20status%20DESC%2C%20priority%20DESC
> >
> > For a summary of the changes in this release, see:
> >
> > https://github.com/apache/incubator-gobblin/blob/0.12.0/CHANGELOG.md
> >
> > Please review and vote. The vote will be open for 72 hours.
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
> > Thanks,
> > Abhishek, on behalf of the Apache Gobblin PPMC
> >
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Matt Sicker <bo...@gmail.com>.
The bundled gradle wrapper in the source tgz doesn't work. It appears to be
missing gradle/wrapper/gradle-wrapper.jar
On 26 March 2018 at 19:01, Abhishek Tiwari <ab...@apache.org> wrote:
> The Apache Gobblin community has voted on and approved the release of
> Apache Gobblin 0.12.0 (incubating):
>
> https://www.mail-archive.com/dev@gobblin.incubator.apache.
> org/msg01772.html
>
> Results:
> 5 binding +1 votes
> No 0 votes
> No -1 votes
>
> The feedback from previous release candidates has been addressed:
> RC0 thread: https://www.mail-archive.com/general@incubator.
> apache.org/msg62151.html
> RC0 resolution: LICENSE and NOTICE files have been updated (tracked by
> GOBBLIN-431 <https://issues.apache.org/jira/browse/GOBBLIN-431>)
> RC1 thread: https://www.mail-archive.com/dev@gobblin.
> incubator.apache.org/msg01733.html
> RC1 resolution: gradlew scripts have been included in the source
> distribution, and the steps for building the distribution has been added to
> README (including the way to obtain gradlew jar)
>
> I'd like to call a vote in general to approve the release.
>
> The source release candidate RC2 can be downloaded here:
>
> https://dist.apache.org/repos/dist/dev/incubator/gobblin/
> apache-gobblin-incubating-0.12.0-rc2/
>
> The artifacts (i.e. JARs) corresponding to this release candidate can be
> found here:
>
> https://repository.apache.org/content/repositories/orgapachegobblin-1002
>
> This has been signed with PGP key 234E3FE3, corresponding to
> abti@apache.org, which is included in the repository's KEYS file (
> https://dist.apache.org/repos/dist/release/incubator/gobblin/KEYS). This
> key can be found on keyservers, such as:
>
> *http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3
> <http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3>*
>
> It is also listed here:
>
> https://people.apache.org/keys/committer/abti.asc
>
> The release candidate has been tagged with release-0.12.0-rc2.
> I've also created a branch 0.12.0.
>
> For reference, here is a list of all closed JIRAs tagged with 0.12.0:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20GOBBLIN%20AND%
> 20fixVersion%20%3D%200.12.0%20AND%20status%20in%20(Closed%
> 2C%20Resolved)%20ORDER%20BY%20updatedDate%20DESC%2C%
> 20createdDate%20DESC%2C%
> 20status%20DESC%2C%20priority%20DESC
>
> For a summary of the changes in this release, see:
>
> https://github.com/apache/incubator-gobblin/blob/0.12.0/CHANGELOG.md
>
> Please review and vote. The vote will be open for 72 hours.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Thanks,
> Abhishek, on behalf of the Apache Gobblin PPMC
>
--
Matt Sicker <bo...@gmail.com>
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Jim Jagielski <ji...@jaguNET.com>.
I am also going to vote -1 for the same reason. It seems to me that
simply fixing this issue is all that's required for a successful RC3 and GA.
> On Mar 31, 2018, at 7:08 PM, Justin Mclean <ju...@me.com> wrote:
>
> Hi,
>
> -1 binding as NOTICE should not contain copyrights of bundled 3rd party software. The NOTICE file needs to only contain what is required (and not already in LICENSE) and needs to be as small as possible as it affects downstream projects. [2]
>
> I checked:
> - incubating in name
> - signatures and hashes good
> - DISCLAIMER exists
> - LICENSE is missing info for fonts [1]
> - NOTICE is incorrect
> - Some .sh files are missing ASF headers
> - Can compile from source
>
> Thanks,
> Justin
>
> 1. apache-gobblin-incubating-sources-0.12.0/gobblin-admin/src/main/resources/static/fonts/*
> 2. http://www.apache.org/dev/licensing-howto.html#mod-notice
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
In general just because a TLP does something doesn’t mean it’s in line with policy or may have historic reasons for it being that way.
> Apache Hadoop: https://github.com/apache/hadoop/blob/trunk/NOTICE.txt
> Apache Spark: https://github.com/apache/spark/blob/master/NOTICE
Have been discussed on this list (several times) before that they are not good examples to follow. Some of the issues come from an upstream NOTICE files that also have issues - which is the exact issue we’re trying to prevent.
> Apache HBase: https://github.com/apache/hbase/blob/master/NOTICE.txt
> Apache Ambari: https://github.com/apache/ambari/blob/trunk/ambari-web/app/assets/licenses/NOTICE.txt
And IMO both of those also look to have issues.
> So, isn't enforcing improvements on podling not harsh when it does not
> attracts -1 or blocks releases for other Apache TLP releases?
The incubator has not remit over TLP projects license and notice files. It’s up to those PMCs to get it right and they should of learnt that when they went through the incubator. If they didn’t them perhaps we need to do things a little differently here?
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Jim Jagielski <ji...@jaguNET.com>.
First of all, one cannot "veto" a release, so a -1 vote on a release
is not, really, a blocker. One can still do the release; but it does
indicate a lack of consensus within the (P)PMC that the release
is in a "releasable" state.
> On Apr 1, 2018, at 7:19 PM, Abhishek Tiwari <ab...@apache.org> wrote:
>
> Although the vote is over and successful, at this point I think I will just
> update the NOTICE file and bring in another RC for vote.
>
> However, I am puzzled that this improvement (not blocker) is attracting -1
> votes. I would have expected +1 or 0 with improvement suggestion,
> specifically because I see that this is a very common pattern in many if
> not most of the major Apache TLP projects.
> The two entries in our NOTICE file is for: bootstrap and Glyphicon icons.
> And, for exactly the same included bits, here are the NOTICE files for a
> few other major TLPs:
> Apache Hadoop: https://github.com/apache/hadoop/blob/trunk/NOTICE.txt
> <https://www.google.com/url?q=https://github.com/apache/hadoop/blob/trunk/NOTICE.txt&sa=D&source=hangouts&ust=1522643463206000&usg=AFQjCNGI8Ip-PaJG9FI1khGSq5ErPtu6eQ>
>
> Apache HBase: https://github.com/apache/hbase/blob/master/NOTICE.txt
> <https://www.google.com/url?q=https://github.com/apache/hbase/blob/master/NOTICE.txt&sa=D&source=hangouts&ust=1522643463206000&usg=AFQjCNGuWUiULf55KJuDhruPujU8zDiLhg>
>
> Apache Ambari: https://github.com/apache/ambari/blob/trunk/
> ambari-web/app/assets/licenses/NOTICE.txt
> <https://www.google.com/url?q=https://github.com/apache/ambari/blob/trunk/ambari-web/app/assets/licenses/NOTICE.txt&sa=D&source=hangouts&ust=1522643463206000&usg=AFQjCNHhiS9lcjtDZJi0LCRVKBBkiFslmw>
>
> Apache Spark: https://github.com/apache/spark/blob/master/NOTICE
> <https://www.google.com/url?q=https://github.com/apache/spark/blob/master/NOTICE&sa=D&source=hangouts&ust=1522643463206000&usg=AFQjCNEyNwgI9q--GLEqJJXMLE9gPxD9VQ>
>
> .. there are many more, but I stopped at these.
>
> So, isn't enforcing improvements on podling not harsh when it does not
> attracts -1 or blocks releases for other Apache TLP releases?
>
> Abhishek
>
> On Sun, Apr 1, 2018 at 3:12 PM, Justin Mclean <ju...@classsoftware.com>
> wrote:
>
>> Hi,
>>
>> It's hard to come up with a single simple sentence that applies in all
>> cases. So when I said "if something is bundled then it's license and
>> copyright needs to be in LICENSE not NOTICE.” I’m wrong as it's not going
>> to all cover all cases.
>>
>> For bundling Apache licensed (v2) bits of software the copyright isn’t in
>> the license. If the software has a NOTICE file then that is very likely
>> going to effect your NOTICE file - which I think what Sebb was getting at
>> and this is certainly the most common situation.
>>
>> In general other permissive licenses (like MIT and BSD) include a
>> copyright line in the license text and theres’s no need to include anything
>> in NOTICE.
>>
>> Then we come to required notices which are going to be uncommon. The
>> licenses with required notices (ignoring ALv2) that I know of are the BSD
>> with advertising clause (Category X), CDDL (list of modifications and how
>> to get source) and MPL (info how to get source code) which are both
>> Category B. None of these would be bundled in a source release (but may
>> affect a binary one). I can’t think of any category A license which has a
>> required notices. Does anyone know of one?
>>
>> Thanks,
>> Justin
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I reckon I'm a bit confused as well now as I'm not sure what is the correct fix to apply….
In your case it quite simple see [1] Nothing needs to be added to NOTICE for MIT or BSD licensed software. You just need to remove the lines and copyright notices that refer to any software licensed like that.
Thanks,
Justin
1. http://www.apache.org/dev/licensing-howto.html#permissive-deps
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Olivier Lamy <ol...@apache.org>.
I reckon I'm a bit confused as well now as I'm not sure what is the correct
fix to apply....
Is there any of the folks who voted -1 to propose some fixes?
via pull request or a patch? the git repo is available here:
https://github.com/apache/incubator-gobblin
This will definitely helps a lot as even with few years of experience here,
I'm really confused about what and how to fix the issue.
Thanks a lot
Olivier
On Mon, 2 Apr 2018 at 09:19, Abhishek Tiwari <ab...@apache.org> wrote:
> Although the vote is over and successful, at this point I think I will just
> update the NOTICE file and bring in another RC for vote.
>
> However, I am puzzled that this improvement (not blocker) is attracting -1
> votes. I would have expected +1 or 0 with improvement suggestion,
> specifically because I see that this is a very common pattern in many if
> not most of the major Apache TLP projects.
> The two entries in our NOTICE file is for: bootstrap and Glyphicon icons.
> And, for exactly the same included bits, here are the NOTICE files for a
> few other major TLPs:
> Apache Hadoop: https://github.com/apache/hadoop/blob/trunk/NOTICE.txt
> <
> https://www.google.com/url?q=https://github.com/apache/hadoop/blob/trunk/NOTICE.txt&sa=D&source=hangouts&ust=1522643463206000&usg=AFQjCNGI8Ip-PaJG9FI1khGSq5ErPtu6eQ
> >
>
> Apache HBase: https://github.com/apache/hbase/blob/master/NOTICE.txt
> <
> https://www.google.com/url?q=https://github.com/apache/hbase/blob/master/NOTICE.txt&sa=D&source=hangouts&ust=1522643463206000&usg=AFQjCNGuWUiULf55KJuDhruPujU8zDiLhg
> >
>
> Apache Ambari: https://github.com/apache/ambari/blob/trunk/
> ambari-web/app/assets/licenses/NOTICE.txt
> <
> https://www.google.com/url?q=https://github.com/apache/ambari/blob/trunk/ambari-web/app/assets/licenses/NOTICE.txt&sa=D&source=hangouts&ust=1522643463206000&usg=AFQjCNHhiS9lcjtDZJi0LCRVKBBkiFslmw
> >
>
> Apache Spark: https://github.com/apache/spark/blob/master/NOTICE
> <
> https://www.google.com/url?q=https://github.com/apache/spark/blob/master/NOTICE&sa=D&source=hangouts&ust=1522643463206000&usg=AFQjCNEyNwgI9q--GLEqJJXMLE9gPxD9VQ
> >
>
> .. there are many more, but I stopped at these.
>
> So, isn't enforcing improvements on podling not harsh when it does not
> attracts -1 or blocks releases for other Apache TLP releases?
>
> Abhishek
>
> On Sun, Apr 1, 2018 at 3:12 PM, Justin Mclean <ju...@classsoftware.com>
> wrote:
>
> > Hi,
> >
> > It's hard to come up with a single simple sentence that applies in all
> > cases. So when I said "if something is bundled then it's license and
> > copyright needs to be in LICENSE not NOTICE.” I’m wrong as it's not going
> > to all cover all cases.
> >
> > For bundling Apache licensed (v2) bits of software the copyright isn’t in
> > the license. If the software has a NOTICE file then that is very likely
> > going to effect your NOTICE file - which I think what Sebb was getting at
> > and this is certainly the most common situation.
> >
> > In general other permissive licenses (like MIT and BSD) include a
> > copyright line in the license text and theres’s no need to include
> anything
> > in NOTICE.
> >
> > Then we come to required notices which are going to be uncommon. The
> > licenses with required notices (ignoring ALv2) that I know of are the BSD
> > with advertising clause (Category X), CDDL (list of modifications and how
> > to get source) and MPL (info how to get source code) which are both
> > Category B. None of these would be bundled in a source release (but may
> > affect a binary one). I can’t think of any category A license which has a
> > required notices. Does anyone know of one?
> >
> > Thanks,
> > Justin
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Abhishek Tiwari <ab...@apache.org>.
Although the vote is over and successful, at this point I think I will just
update the NOTICE file and bring in another RC for vote.
However, I am puzzled that this improvement (not blocker) is attracting -1
votes. I would have expected +1 or 0 with improvement suggestion,
specifically because I see that this is a very common pattern in many if
not most of the major Apache TLP projects.
The two entries in our NOTICE file is for: bootstrap and Glyphicon icons.
And, for exactly the same included bits, here are the NOTICE files for a
few other major TLPs:
Apache Hadoop: https://github.com/apache/hadoop/blob/trunk/NOTICE.txt
<https://www.google.com/url?q=https://github.com/apache/hadoop/blob/trunk/NOTICE.txt&sa=D&source=hangouts&ust=1522643463206000&usg=AFQjCNGI8Ip-PaJG9FI1khGSq5ErPtu6eQ>
Apache HBase: https://github.com/apache/hbase/blob/master/NOTICE.txt
<https://www.google.com/url?q=https://github.com/apache/hbase/blob/master/NOTICE.txt&sa=D&source=hangouts&ust=1522643463206000&usg=AFQjCNGuWUiULf55KJuDhruPujU8zDiLhg>
Apache Ambari: https://github.com/apache/ambari/blob/trunk/
ambari-web/app/assets/licenses/NOTICE.txt
<https://www.google.com/url?q=https://github.com/apache/ambari/blob/trunk/ambari-web/app/assets/licenses/NOTICE.txt&sa=D&source=hangouts&ust=1522643463206000&usg=AFQjCNHhiS9lcjtDZJi0LCRVKBBkiFslmw>
Apache Spark: https://github.com/apache/spark/blob/master/NOTICE
<https://www.google.com/url?q=https://github.com/apache/spark/blob/master/NOTICE&sa=D&source=hangouts&ust=1522643463206000&usg=AFQjCNEyNwgI9q--GLEqJJXMLE9gPxD9VQ>
.. there are many more, but I stopped at these.
So, isn't enforcing improvements on podling not harsh when it does not
attracts -1 or blocks releases for other Apache TLP releases?
Abhishek
On Sun, Apr 1, 2018 at 3:12 PM, Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> It's hard to come up with a single simple sentence that applies in all
> cases. So when I said "if something is bundled then it's license and
> copyright needs to be in LICENSE not NOTICE.” I’m wrong as it's not going
> to all cover all cases.
>
> For bundling Apache licensed (v2) bits of software the copyright isn’t in
> the license. If the software has a NOTICE file then that is very likely
> going to effect your NOTICE file - which I think what Sebb was getting at
> and this is certainly the most common situation.
>
> In general other permissive licenses (like MIT and BSD) include a
> copyright line in the license text and theres’s no need to include anything
> in NOTICE.
>
> Then we come to required notices which are going to be uncommon. The
> licenses with required notices (ignoring ALv2) that I know of are the BSD
> with advertising clause (Category X), CDDL (list of modifications and how
> to get source) and MPL (info how to get source code) which are both
> Category B. None of these would be bundled in a source release (but may
> affect a binary one). I can’t think of any category A license which has a
> required notices. Does anyone know of one?
>
> Thanks,
> Justin
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
It's hard to come up with a single simple sentence that applies in all cases. So when I said "if something is bundled then it's license and copyright needs to be in LICENSE not NOTICE.” I’m wrong as it's not going to all cover all cases.
For bundling Apache licensed (v2) bits of software the copyright isn’t in the license. If the software has a NOTICE file then that is very likely going to effect your NOTICE file - which I think what Sebb was getting at and this is certainly the most common situation.
In general other permissive licenses (like MIT and BSD) include a copyright line in the license text and theres’s no need to include anything in NOTICE.
Then we come to required notices which are going to be uncommon. The licenses with required notices (ignoring ALv2) that I know of are the BSD with advertising clause (Category X), CDDL (list of modifications and how to get source) and MPL (info how to get source code) which are both Category B. None of these would be bundled in a source release (but may affect a binary one). I can’t think of any category A license which has a required notices. Does anyone know of one?
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Jim Jagielski <ji...@jaguNET.com>.
> On Apr 1, 2018, at 10:48 AM, sebb <se...@gmail.com> wrote:
>
>
> I don't think that is true; I think bundled bits can affect the NOTICE
> file (albeit perhaps rarely).
That is my position as well, fwiw.
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by sebb <se...@gmail.com>.
On 1 April 2018 at 15:29, Jim Jagielski <ji...@jagunet.com> wrote:
>
>
>> On Apr 1, 2018, at 9:35 AM, sebb <se...@gmail.com> wrote:
>>
>>
>> If bundled bits never affect the NOTICE file, why is there a concern
>> about minimising the NOTICE contents?
>>
>
> Let's consider the "touch points" between what we release and
> the downstream user and consumer eco-system. For these
> entities, the 3 "main" files that affect what they can do, as well
> as information that is of primary importance that determines
> their responsibilities are the README, LICENSE and NOTICE
> files:
>
> o README: because it is the main communication channel between
> the project and downstream
> o LICENSE: because it provides the distribution requirements
> and conditions
> o NOTICE: because it provides the addition information that
> is required to be maintained and "transparent" for the
> downstream
>
> In many ways, NOTICE is extra data that must be included
> for all subsequent downstream and distros and, therefore,
> should include only what MUST be folded into the file. That's
> why it is defined as such ("... and nothing more"). We want
> to minimize extraneous work and efforts required for downstreams
> in order to make the use and consumption of Apache code and
> projects as easy as possible. A bloated NOTICE with lots
> of duplicate information unnecessarily adds addition workload
> and, esp, oversight.
Agreed, but I think you may have misunderstood why I wrote:
>> If bundled bits never affect the NOTICE file, why is there a concern
>> about minimising the NOTICE contents?
To my mind, your reply addresses the latter part of the sentence only.
My point was that NOTICE files need to be minimised because otherwise
bundled bits can cause it to become bloated.
i.e. bundled bits *can* affect the NOTICE file.
If bundled bits did not affect the NOTICE file then the file would not
contain anything more than the bare minimum.
I read Justin's statement to imply that bundled bits do not affect the
NOTICE file.
I don't think that is true; I think bundled bits can affect the NOTICE
file (albeit perhaps rarely).
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Jim Jagielski <ji...@jaguNET.com>.
> On Apr 1, 2018, at 9:35 AM, sebb <se...@gmail.com> wrote:
>
>
> If bundled bits never affect the NOTICE file, why is there a concern
> about minimising the NOTICE contents?
>
Let's consider the "touch points" between what we release and
the downstream user and consumer eco-system. For these
entities, the 3 "main" files that affect what they can do, as well
as information that is of primary importance that determines
their responsibilities are the README, LICENSE and NOTICE
files:
o README: because it is the main communication channel between
the project and downstream
o LICENSE: because it provides the distribution requirements
and conditions
o NOTICE: because it provides the addition information that
is required to be maintained and "transparent" for the
downstream
In many ways, NOTICE is extra data that must be included
for all subsequent downstream and distros and, therefore,
should include only what MUST be folded into the file. That's
why it is defined as such ("... and nothing more"). We want
to minimize extraneous work and efforts required for downstreams
in order to make the use and consumption of Apache code and
projects as easy as possible. A bloated NOTICE with lots
of duplicate information unnecessarily adds addition workload
and, esp, oversight.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by sebb <se...@gmail.com>.
On 1 April 2018 at 14:15, Justin Mclean <ju...@classsoftware.com> wrote:
> Hi,
>
>> I have not looked at the NOTICE file.
>
> Perhaps your should as my statements was in context to that.
>
>> "if something is bundled then it's license and copyright needs to be
>> in LICENSE not NOTICE."
>>
>> As noted above, I don't think that is true.
>
> For what licenses do you think this is not true? license information always goes in license and the license text usually includes the copyright so there’s no need to duplicate it in notice.
Does https://www.apache.org/licenses/example-NOTICE.txt count?
If bundled bits never affect the NOTICE file, why is there a concern
about minimising the NOTICE contents?
> Thanks,
> Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I have not looked at the NOTICE file.
Perhaps your should as my statements was in context to that.
> "if something is bundled then it's license and copyright needs to be
> in LICENSE not NOTICE."
>
> As noted above, I don't think that is true.
For what licenses do you think this is not true? license information always goes in license and the license text usually includes the copyright so there’s no need to duplicate it in notice.
Thanks,
Justin
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by sebb <se...@gmail.com>.
On 1 April 2018 at 13:28, Justin Mclean <ju...@classsoftware.com> wrote:
> Hi,
>
>> non-bundled Dependencies are irrelevant to the contents of NOTICE and LICENSE.
>
> Yep 100% agree.
>
>> Though of course the license does affect whether it is allowed to be a
>> dependency.
>
> Also agree.
>
>> NOTICE and LICENSE are only for bits that are bundled in the release artifact.
>
> Yep 100% in agreement.
>
>> The LICENSE file must reflect the license(s) for all the bundled bits.
>
> Yep - in this case it’s missing some stuff here but that’s minor.
>
>> The NOTICE file must include all required notices and nothing more.
>
> And in this case it includes more than is needed. Do you disagree?
I have not looked at the NOTICE file.
I was responding to your statement:
"if something is bundled then it's license and copyright needs to be
in LICENSE not NOTICE."
As noted above, I don't think that is true.
>> Bundled 3rd party code *can* affect the NOTICE file.
>> That's why it is important to only include required notices.
>
> But usually doesn’t with MIT or BSD licenses as is the case here. In most cases required notices are quite rare.
Indeed, but that does not make the statement true.
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> non-bundled Dependencies are irrelevant to the contents of NOTICE and LICENSE.
Yep 100% agree.
> Though of course the license does affect whether it is allowed to be a
> dependency.
Also agree.
> NOTICE and LICENSE are only for bits that are bundled in the release artifact.
Yep 100% in agreement.
> The LICENSE file must reflect the license(s) for all the bundled bits.
Yep - in this case it’s missing some stuff here but that’s minor.
> The NOTICE file must include all required notices and nothing more.
And in this case it includes more than is needed. Do you disagree?
> Bundled 3rd party code *can* affect the NOTICE file.
> That's why it is important to only include required notices.
But usually doesn’t with MIT or BSD licenses as is the case here. In most cases required notices are quite rare.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by sebb <se...@gmail.com>.
On 1 April 2018 at 09:21, Justin Mclean <ju...@classsoftware.com> wrote:
> Hi,
>
>> Can you elaborate a bit ? I checked the NOTICE file and it looks good to me. It mentions the included dependencies like bootstrap.
>
> Dependancies should not be mentioned in NOTICE. if something is bundled then it's license and copyright needs to be in LICENSE not NOTICE.
Huh?
AIUI:
non-bundled Dependencies are irrelevant to the contents of NOTICE and LICENSE.
Though of course the license does affect whether it is allowed to be a
dependency.
NOTICE and LICENSE are only for bits that are bundled in the release artifact.
The LICENSE file must reflect the license(s) for all the bundled bits.
The NOTICE file must include all required notices and nothing more.
Bundled 3rd party code *can* affect the NOTICE file.
That's why it is important to only include required notices.
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Can you elaborate a bit ? I checked the NOTICE file and it looks good to me. It mentions the included dependencies like bootstrap.
Dependancies should not be mentioned in NOTICE. if something is bundled then it's license and copyright needs to be in LICENSE not NOTICE.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Justin
Can you elaborate a bit ? I checked the NOTICE file and it looks good to me. It mentions the included dependencies like bootstrap.
Thanks
Regards
JB
Le 1 avr. 2018 à 01:08, à 01:08, Justin Mclean <ju...@me.com> a écrit:
>Hi,
>
>-1 binding as NOTICE should not contain copyrights of bundled 3rd party
>software. The NOTICE file needs to only contain what is required (and
>not already in LICENSE) and needs to be as small as possible as it
>affects downstream projects. [2]
>
>I checked:
>- incubating in name
>- signatures and hashes good
>- DISCLAIMER exists
>- LICENSE is missing info for fonts [1]
>- NOTICE is incorrect
>- Some .sh files are missing ASF headers
>- Can compile from source
>
>Thanks,
>Justin
>
>1.
>apache-gobblin-incubating-sources-0.12.0/gobblin-admin/src/main/resources/static/fonts/*
>2. http://www.apache.org/dev/licensing-howto.html#mod-notice
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Abhishek Tiwari <ab...@apache.org>.
Thanks everyone for the feedback.
Summarizing the thread: proposed changes to the NOTICE file is an
improvement and thus we will consider it in the next release.
At the moment, I will close the vote since we have run out of time and have
the necessary votes.
Thanks again,
Abhishek
On Sun, Apr 1, 2018 at 1:51 AM, Romain Manni-Bucau <rm...@gmail.com>
wrote:
> +1, not a blocker since it is more on nice to have helpers than needed
> tools IMHO and legally it looks ok and it builds properly
>
> Le 1 avr. 2018 10:42, "Olivier Lamy" <ol...@apache.org> a écrit :
>
> > Well not a big drama, we can fix that with the next release.
> > ATM 2 mentors have voted +1: Jean-Baptiste and myself.
> > 1 * IPMC with Matt.
> >
> >
> > On Sun, 1 Apr 2018 at 18:36, Justin Mclean <ju...@classsoftware.com>
> > wrote:
> >
> > > Hi,
> > >
> > > PS by my count you only need one more +1 vote and only one of your
> > project
> > > mentors have voted.
> > >
> > > Thanks,
> > > Justin
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: general-help@incubator.apache.org
> > >
> > >
> >
> > --
> > Olivier Lamy
> > http://twitter.com/olamy | http://linkedin.com/in/olamy
> >
>
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Romain Manni-Bucau <rm...@gmail.com>.
+1, not a blocker since it is more on nice to have helpers than needed
tools IMHO and legally it looks ok and it builds properly
Le 1 avr. 2018 10:42, "Olivier Lamy" <ol...@apache.org> a écrit :
> Well not a big drama, we can fix that with the next release.
> ATM 2 mentors have voted +1: Jean-Baptiste and myself.
> 1 * IPMC with Matt.
>
>
> On Sun, 1 Apr 2018 at 18:36, Justin Mclean <ju...@classsoftware.com>
> wrote:
>
> > Hi,
> >
> > PS by my count you only need one more +1 vote and only one of your
> project
> > mentors have voted.
> >
> > Thanks,
> > Justin
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Olivier Lamy <ol...@apache.org>.
Well not a big drama, we can fix that with the next release.
ATM 2 mentors have voted +1: Jean-Baptiste and myself.
1 * IPMC with Matt.
On Sun, 1 Apr 2018 at 18:36, Justin Mclean <ju...@classsoftware.com> wrote:
> Hi,
>
> PS by my count you only need one more +1 vote and only one of your project
> mentors have voted.
>
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
PS by my count you only need one more +1 vote and only one of your project mentors have voted.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Thanks for the update. It makes sense.
Let's see what the other IPMC will say. Definitely something to fix for next release at least.
Regards
JB
Le 1 avr. 2018 à 10:25, à 10:25, Justin Mclean <ju...@classsoftware.com> a écrit:
>Hi,
>
>> Yes but as said we can fix in next release cycle. It's more an
>improvement than a blocker IMHO.
>
>IMO it still warrants a -1, but that is not a veto or a blocker. Other
>IPMC members and the project mentors are free to vote however they
>want. If you get 3 +1 votes and more +1’s than -1’s you can release it.
>
>Thanks,
>Justin
>---------------------------------------------------------------------
>To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Yes but as said we can fix in next release cycle. It's more an improvement than a blocker IMHO.
IMO it still warrants a -1, but that is not a veto or a blocker. Other IPMC members and the project mentors are free to vote however they want. If you get 3 +1 votes and more +1’s than -1’s you can release it.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Yes but as said we can fix in next release cycle. It's more an improvement than a blocker IMHO.
Regards
JB
Le 1 avr. 2018 à 10:10, à 10:10, Willem Jiang <wi...@gmail.com> a écrit:
>Hi Olivier
>
>NOTICE file is not supposed to include the copyright unless the License
>requires.
>As the MIT License already has the copyright statement, we don't need
>to
>specify it in the NOTCE file.
>
>I just copy the Justin's comments from the lega issue discussion[1] ,
>it
>can explain lots of thing.
>
>"While including all of NOTICE is the safest/simplest way.
>
>INAL but I also think removal of obvious things that have been
>documented
>that shouldn't be there is also safe. i.e.
>
> - Don't include ASF duplicate ASF copyright/this product developed at
> the ASF lines [1]
>- Remove anything that should be in LICENSE (that is already there)
>i.e.
> MIT and BSD license information [2]
> - Remove any copyright lines from MIT and BSD (but not ASL 2.0)
>permissive licenses, who headers are still in place in their respective
> files [3]
> - Only include parts if they are bundled in your release [4]
>
>Perhaps also politely ask / provide a patch to the upstream project to
>fix
>their NOTICE file?
>
>1. http://www.apache.org/dev/licensing-howto.html#bundle-asf-product
>2. http://www.apache.org/dev/licensing-howto.html#permissive-deps
>3. http://www.apache.org/dev/licensing-howto.html#mod-notice
>4. http://www.apache.org/dev/licensing-howto.html#guiding-principle"
>
>[1]https://issues.apache.org/jira/browse/LEGAL-262
>
>
>Willem Jiang
>
>Blog: http://willemjiang.blogspot.com (English)
> http://jnn.iteye.com (Chinese)
>Twitter: willemjiang
>Weibo: 姜宁willem
>
>On Sun, Apr 1, 2018 at 8:38 AM, Olivier Lamy <ol...@apache.org> wrote:
>
>> Hi
>> the content is simply.
>> "
>>
>> Apache Gobblin
>>
>> Copyright 2017-2018 The Apache Software Foundation
>>
>>
>> This product includes software developed at
>>
>> The Apache Software Foundation (http://www.apache.org/).
>>
>>
>> This product includes Bootstrap
>>
>> Copyright (c) 2011-2015 Twitter, Inc.
>>
>>
>> This product includes the Glyphicons Halflings icon set
>>
>> Copyright (c) Jan Kovařík (http://glyphicons.com)
>>
>> Licensed under The MIT License (MIT) as a part of the Bootstrap
>project.
>>
>>
>> This product includes normalize.css
>>
>> Copyright (c) Nicolas Gallagher and Jonathan Neal
>> "
>> Can you please explain what is the legal problem with such content?
>> TBH I can see so many similar content in a lot of TLP projects. So
>why we
>> should be more rude here than for other projects?
>>
>>
>> On Sun, 1 Apr 2018 at 09:08, Justin Mclean <ju...@me.com>
>wrote:
>>
>> > Hi,
>> >
>> > -1 binding as NOTICE should not contain copyrights of bundled 3rd
>party
>> > software. The NOTICE file needs to only contain what is required
>(and
>> not
>> > already in LICENSE) and needs to be as small as possible as it
>affects
>> > downstream projects. [2]
>> >
>> > I checked:
>> > - incubating in name
>> > - signatures and hashes good
>> > - DISCLAIMER exists
>> > - LICENSE is missing info for fonts [1]
>> > - NOTICE is incorrect
>> > - Some .sh files are missing ASF headers
>> > - Can compile from source
>> >
>> > Thanks,
>> > Justin
>> >
>> > 1.
>> > apache-gobblin-incubating-sources-0.12.0/gobblin-admin/
>> src/main/resources/static/fonts/*
>> > 2. http://www.apache.org/dev/licensing-howto.html#mod-notice
>> >
>> >
>> >
>> >
>---------------------------------------------------------------------
>> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> > For additional commands, e-mail: general-help@incubator.apache.org
>> >
>> >
>>
>> --
>> Olivier Lamy
>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Willem Jiang <wi...@gmail.com>.
Hi Olivier
NOTICE file is not supposed to include the copyright unless the License
requires.
As the MIT License already has the copyright statement, we don't need to
specify it in the NOTCE file.
I just copy the Justin's comments from the lega issue discussion[1] , it
can explain lots of thing.
"While including all of NOTICE is the safest/simplest way.
INAL but I also think removal of obvious things that have been documented
that shouldn't be there is also safe. i.e.
- Don't include ASF duplicate ASF copyright/this product developed at
the ASF lines [1]
- Remove anything that should be in LICENSE (that is already there) i.e.
MIT and BSD license information [2]
- Remove any copyright lines from MIT and BSD (but not ASL 2.0)
permissive licenses, who headers are still in place in their respective
files [3]
- Only include parts if they are bundled in your release [4]
Perhaps also politely ask / provide a patch to the upstream project to fix
their NOTICE file?
1. http://www.apache.org/dev/licensing-howto.html#bundle-asf-product
2. http://www.apache.org/dev/licensing-howto.html#permissive-deps
3. http://www.apache.org/dev/licensing-howto.html#mod-notice
4. http://www.apache.org/dev/licensing-howto.html#guiding-principle"
[1]https://issues.apache.org/jira/browse/LEGAL-262
Willem Jiang
Blog: http://willemjiang.blogspot.com (English)
http://jnn.iteye.com (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem
On Sun, Apr 1, 2018 at 8:38 AM, Olivier Lamy <ol...@apache.org> wrote:
> Hi
> the content is simply.
> "
>
> Apache Gobblin
>
> Copyright 2017-2018 The Apache Software Foundation
>
>
> This product includes software developed at
>
> The Apache Software Foundation (http://www.apache.org/).
>
>
> This product includes Bootstrap
>
> Copyright (c) 2011-2015 Twitter, Inc.
>
>
> This product includes the Glyphicons Halflings icon set
>
> Copyright (c) Jan Kovařík (http://glyphicons.com)
>
> Licensed under The MIT License (MIT) as a part of the Bootstrap project.
>
>
> This product includes normalize.css
>
> Copyright (c) Nicolas Gallagher and Jonathan Neal
> "
> Can you please explain what is the legal problem with such content?
> TBH I can see so many similar content in a lot of TLP projects. So why we
> should be more rude here than for other projects?
>
>
> On Sun, 1 Apr 2018 at 09:08, Justin Mclean <ju...@me.com> wrote:
>
> > Hi,
> >
> > -1 binding as NOTICE should not contain copyrights of bundled 3rd party
> > software. The NOTICE file needs to only contain what is required (and
> not
> > already in LICENSE) and needs to be as small as possible as it affects
> > downstream projects. [2]
> >
> > I checked:
> > - incubating in name
> > - signatures and hashes good
> > - DISCLAIMER exists
> > - LICENSE is missing info for fonts [1]
> > - NOTICE is incorrect
> > - Some .sh files are missing ASF headers
> > - Can compile from source
> >
> > Thanks,
> > Justin
> >
> > 1.
> > apache-gobblin-incubating-sources-0.12.0/gobblin-admin/
> src/main/resources/static/fonts/*
> > 2. http://www.apache.org/dev/licensing-howto.html#mod-notice
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Can you please explain what is the legal problem with such content?
It’s not a legal probably as such but an ASF policy one. The NOTICE need to be keep as small as possible as it has an affect on downstream projects.
> TBH I can see so many similar content in a lot of TLP projects.
You might think you do but you may be confusing relocated copyrights with copyrights from license files or content from upstream notice files.
Thanks,
Justin.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Olivier Lamy <ol...@apache.org>.
Hi
the content is simply.
"
Apache Gobblin
Copyright 2017-2018 The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
This product includes Bootstrap
Copyright (c) 2011-2015 Twitter, Inc.
This product includes the Glyphicons Halflings icon set
Copyright (c) Jan Kovařík (http://glyphicons.com)
Licensed under The MIT License (MIT) as a part of the Bootstrap project.
This product includes normalize.css
Copyright (c) Nicolas Gallagher and Jonathan Neal
"
Can you please explain what is the legal problem with such content?
TBH I can see so many similar content in a lot of TLP projects. So why we
should be more rude here than for other projects?
On Sun, 1 Apr 2018 at 09:08, Justin Mclean <ju...@me.com> wrote:
> Hi,
>
> -1 binding as NOTICE should not contain copyrights of bundled 3rd party
> software. The NOTICE file needs to only contain what is required (and not
> already in LICENSE) and needs to be as small as possible as it affects
> downstream projects. [2]
>
> I checked:
> - incubating in name
> - signatures and hashes good
> - DISCLAIMER exists
> - LICENSE is missing info for fonts [1]
> - NOTICE is incorrect
> - Some .sh files are missing ASF headers
> - Can compile from source
>
> Thanks,
> Justin
>
> 1.
> apache-gobblin-incubating-sources-0.12.0/gobblin-admin/src/main/resources/static/fonts/*
> 2. http://www.apache.org/dev/licensing-howto.html#mod-notice
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Justin Mclean <ju...@me.com>.
Hi,
-1 binding as NOTICE should not contain copyrights of bundled 3rd party software. The NOTICE file needs to only contain what is required (and not already in LICENSE) and needs to be as small as possible as it affects downstream projects. [2]
I checked:
- incubating in name
- signatures and hashes good
- DISCLAIMER exists
- LICENSE is missing info for fonts [1]
- NOTICE is incorrect
- Some .sh files are missing ASF headers
- Can compile from source
Thanks,
Justin
1. apache-gobblin-incubating-sources-0.12.0/gobblin-admin/src/main/resources/static/fonts/*
2. http://www.apache.org/dev/licensing-howto.html#mod-notice
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Gobblin 0.12.0 release RC2
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
+1 (binding)
Checked build, signatures & headers, DISCLAIMER, NOTICE and LICENSE.
Regards
JB
Le 27 mars 2018 à 02:01, à 02:01, Abhishek Tiwari <ab...@apache.org> a écrit:
>The Apache Gobblin community has voted on and approved the release of
>Apache Gobblin 0.12.0 (incubating):
>
>https://www.mail-archive.com/dev@gobblin.incubator.apache.org/msg01772.html
>
>Results:
>5 binding +1 votes
>No 0 votes
>No -1 votes
>
>The feedback from previous release candidates has been addressed:
>RC0 thread: https://www.mail-archive.com/general@incubator.
>apache.org/msg62151.html
>RC0 resolution: LICENSE and NOTICE files have been updated (tracked by
>GOBBLIN-431 <https://issues.apache.org/jira/browse/GOBBLIN-431>)
>RC1 thread: https://www.mail-archive.com/dev@gobblin.
>incubator.apache.org/msg01733.html
>RC1 resolution: gradlew scripts have been included in the source
>distribution, and the steps for building the distribution has been
>added to
>README (including the way to obtain gradlew jar)
>
>I'd like to call a vote in general to approve the release.
>
>The source release candidate RC2 can be downloaded here:
>
>https://dist.apache.org/repos/dist/dev/incubator/gobblin/
>apache-gobblin-incubating-0.12.0-rc2/
>
>The artifacts (i.e. JARs) corresponding to this release candidate can
>be
>found here:
>
>https://repository.apache.org/content/repositories/orgapachegobblin-1002
>
>This has been signed with PGP key 234E3FE3, corresponding to
>abti@apache.org, which is included in the repository's KEYS file (
>https://dist.apache.org/repos/dist/release/incubator/gobblin/KEYS).
>This
>key can be found on keyservers, such as:
>
>*http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3
><http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3>*
>
>It is also listed here:
>
>https://people.apache.org/keys/committer/abti.asc
>
>The release candidate has been tagged with release-0.12.0-rc2.
>I've also created a branch 0.12.0.
>
>For reference, here is a list of all closed JIRAs tagged with 0.12.0:
>
>https://issues.apache.org/jira/issues/?jql=project%20%3D%20GOBBLIN%20AND%
>20fixVersion%20%3D%200.12.0%20AND%20status%20in%20(Closed%
>2C%20Resolved)%20ORDER%20BY%20updatedDate%20DESC%2C%20createdDate%20DESC%2C%
>20status%20DESC%2C%20priority%20DESC
>
>For a summary of the changes in this release, see:
>
>https://github.com/apache/incubator-gobblin/blob/0.12.0/CHANGELOG.md
>
>Please review and vote. The vote will be open for 72 hours.
>
>[ ] +1 approve
>[ ] +0 no opinion
>[ ] -1 disapprove (and reason why)
>
>Thanks,
>Abhishek, on behalf of the Apache Gobblin PPMC