You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/07/14 23:04:06 UTC

[GitHub] [kafka] mjsax opened a new pull request #9025: MINOR: update required MacOS version

mjsax opened a new pull request #9025:
URL: https://github.com/apache/kafka/pull/9025


   MacOS 10.14 should actually work, too. At least our tests passed while they fail on 10.13.
   
   This PR should be cherry-picked to `2.6` branch.
   
   Call for review @vvcephei 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] mjsax merged pull request #9025: MINOR: update required MacOS version

Posted by GitBox <gi...@apache.org>.
mjsax merged pull request #9025:
URL: https://github.com/apache/kafka/pull/9025


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ableegoldman commented on a change in pull request #9025: MINOR: update required MacOS version

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on a change in pull request #9025:
URL: https://github.com/apache/kafka/pull/9025#discussion_r454708982



##########
File path: docs/streams/upgrade-guide.html
##########
@@ -74,7 +74,7 @@ <h1>Upgrade Guide and API Changes</h1>
         For Kafka Streams 0.10.0, broker version 0.10.0 or higher is required.
     </p>
 
-    <p>Since 2.6.0 release, Kafka Streams depends on a RocksDBs version that requires MacOS 10.15 or higher.</p>
+    <p>Since 2.6.0 release, Kafka Streams depends on a RocksDBs version that requires MacOS 10.14 or higher.</p>

Review comment:
       nit: can you fix `RocksDBs` --> `RocksDB`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] mjsax commented on pull request #9025: MINOR: update required MacOS version

Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #9025:
URL: https://github.com/apache/kafka/pull/9025#issuecomment-658889394


   Merged to `trunk` and cherry-picked to `2.6` branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org