You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/04/19 01:30:32 UTC
[GitHub] zeppelin pull request #2260: [ZEPPELIN-2408] Should use $uibTooltip instead ...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2260
[ZEPPELIN-2408] Should use $uibTooltip instead of $tooltip (master)
### What is this PR for?
Since we are using angular-bootstrap 2.5+, we should use `$uibTooltip` instead of `$tooltip`
otherwise we will get an error like the screenshot below.
See also https://github.com/angular-ui/bootstrap/issues/4591
### What type of PR is it?
[Bug Fix]
### Todos
NONE
### What is the Jira issue?
[ZEPPELIN-2048](https://issues.apache.org/jira/browse/ZEPPELIN-2408)
### How should this be tested?
1. open browser console
2. click the scatter chart.
3. shouldn't see an error
### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2048/fix-tooltip-provider
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2260.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2260
----
commit 60faca77550629828d4e4a30afba13c3ca98fbd2
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-19T01:25:53Z
fix: Use
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2260: [ZEPPELIN-2408] Should use $uibTooltip instead of $too...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2260
@1ambda Thanks for fixing!
Let me check this and I'll leave a comment!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2260: [ZEPPELIN-2408] Should use $uibTooltip instead ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2260
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2260: [ZEPPELIN-2408] Should use $uibTooltip instead of $too...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2260
@soralee Please help review this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2260: [ZEPPELIN-2408] Should use $uibTooltip instead of $too...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2260
LGTM and merge to master and branch-0.7 if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2260: [ZEPPELIN-2408] Should use $uibTooltip instead of $too...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2260
@soralee I just rebased. thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2260: [ZEPPELIN-2408] Should use $uibTooltip instead of $too...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2260
@1ambda Tested and LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2260: [ZEPPELIN-2408] Should use $uibTooltip instead of $too...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2260
@1ambda could you rebase this PR? :slightly_smiling_face:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---