You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/01 19:20:45 UTC
[GitHub] [arrow] nevi-me opened a new pull request #7613: ARROW-8881: [Rust] Add large binary, string and list support
nevi-me opened a new pull request #7613:
URL: https://github.com/apache/arrow/pull/7613
Similar to other implementations, this creates binary, string and list arrays with `i64` offsets instead of `i32`. Behaviourally, everything's the same as the `i32` counterparts, except for the larger array offsets.
I'll look at the relevant integration tests separately.
Code's a bit repetitive, but given that we currently don't have much review bandwidth; I'd rather not spend a lot of time on it now, as I want to try complete other integration-related tasks in time for 1.0.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson edited a comment on pull request #7613: ARROW-8881: [Rust] Add large binary, string and list support
Posted by GitBox <gi...@apache.org>.
nealrichardson edited a comment on pull request #7613:
URL: https://github.com/apache/arrow/pull/7613#issuecomment-652613744
> I'll look at the relevant integration tests separately.
Separately as in another commit to this branch, or is there a JIRA already for enabling these integration tests? Do you expect that the tests would fail if you just unskipped them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #7613: ARROW-8881: [Rust] Add large binary, string and list support
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #7613:
URL: https://github.com/apache/arrow/pull/7613#issuecomment-652613744
> I'll look at the relevant integration tests separately.
Separately as in another commit to this branch, or is there a JIRA already for enabling these integration tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sunchao commented on pull request #7613: ARROW-8881: [Rust] Add large binary, string and list support
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #7613:
URL: https://github.com/apache/arrow/pull/7613#issuecomment-653628617
@nevi-me Are we trying to get this in before the 1.0.0 release? if you are in a hurry we can quickly review this and merge. However IMO the code duplication can largely be avoided by having some base classes. We can do it in a follow up to replace the current code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #7613: ARROW-8881: [Rust] Add large binary, string and list support
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #7613:
URL: https://github.com/apache/arrow/pull/7613#issuecomment-653732507
Yes @sunchao, I wanted to merge this as part of integration support.
I had tried finding a way of using a base, but when I struggled I opted for the repetitive way for now.
There's also `Datatype::Decimal`, but I'm struggling to understand the spec, so I don't think I'd be able to complete it in time for 1.0.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7613: ARROW-8881: [Rust] Add large binary, string and list support
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7613:
URL: https://github.com/apache/arrow/pull/7613#issuecomment-652606493
https://issues.apache.org/jira/browse/ARROW-8881
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me closed pull request #7613: ARROW-8881: [Rust] Add large binary, string and list support
Posted by GitBox <gi...@apache.org>.
nevi-me closed pull request #7613:
URL: https://github.com/apache/arrow/pull/7613
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org