You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by velo <gi...@git.apache.org> on 2016/02/01 05:41:35 UTC
[GitHub] incubator-tinkerpop pull request: Tinkerpop 1041
GitHub user velo opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/207
Tinkerpop 1041
I decided to take a look into Tinkerpop-1041 and by doing so I end up setting up the project to build on a windows cloud CI and also fix a few problems I was able to spot on my machine.
This is not 100% done yet, just decided to give it some visibility before investing more time
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/velo/incubator-tinkerpop TINKERPOP-1041
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/207.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #207
----
commit b4874eb9b324322de6cc411e993b14f293240074
Author: Marvin Froeder <ve...@gmail.com>
Date: 2016-01-21T00:33:56Z
Enabled build on windows
commit 2d33ffe34962eaf02704cdc6264bd3e42a6376a9
Author: Marvin H Froeder <ma...@vizexplorer.com>
Date: 2016-01-21T00:46:05Z
Ignoring rat on eclipse and appveyor files
commit b73adb310d82297e01e47e690f972afaaa431396
Author: Marvin Froeder <ma...@vizexplorer.com>
Date: 2016-01-31T20:47:15Z
TINKERPOP-1041 - give import thread a chance to run
commit 9f4c72632f89fb84d79fb0d32b184a063fac1c0b
Author: Marvin Froeder <ma...@vizexplorer.com>
Date: 2016-02-01T00:15:33Z
Url separator is always / even on windows
commit da4d59402894ffde218f0d50bf837420fafe5898
Author: Marvin Froeder <ma...@vizexplorer.com>
Date: 2016-02-01T04:19:33Z
Changed back slashes into regular ones
commit 8cc612e486dd9655780b9926b649210f9f201ed4
Author: Marvin Froeder <ma...@vizexplorer.com>
Date: 2016-02-01T04:19:55Z
Downloading hadoop winutils.exe when using windows
commit 3581dacc53d056eec916690b043b82b247841620
Author: Marvin Froeder <ma...@vizexplorer.com>
Date: 2016-02-01T04:39:13Z
Changed back slashes into regular ones
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Tinkerpop 1041
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/207#discussion_r51409404
--- Diff: gremlin-groovy/src/test/java/org/apache/tinkerpop/gremlin/groovy/engine/ScriptEnginesTest.java ---
@@ -194,8 +195,8 @@ public void shouldFailUntilImportExecutes() throws Exception {
threadEvalAndTriggerImport.join();
threadImport.join();
- assertTrue(successes.intValue() > 0);
- assertTrue(failures.intValue() >= 500);
+ assertTrue("Success: " + successes.intValue() + " - Failures: " + failures.intValue(), successes.intValue() > 0);
--- End diff --
I tend to convert `assertTrue()` to hamcrest based asserts like `assertThat(success.intValue(), isGreaterThan(0))` which yields a better output on failure which i assume is what you are after here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1041
Posted by steveloughran <gi...@git.apache.org>.
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/207#discussion_r51644931
--- Diff: appveyor.yml ---
@@ -0,0 +1,23 @@
+version: '{build}'
+
+environment:
+ matrix:
+ - JAVA_HOME: C:\Program Files\Java\jdk1.8.0
+
+os: Windows Server 2012
+
+install:
+ - ps: |
+ Add-Type -AssemblyName System.IO.Compression.FileSystem
+ if (!(Test-Path -Path "C:\maven" )) {
+ (new-object System.Net.WebClient).DownloadFile('http://www.us.apache.org/dist/maven/maven-3/3.2.5/binaries/apache-maven-3.2.5-bin.zip', 'C:\maven-bin.zip')
--- End diff --
really? I'd grab it from ASF Central, or think about checking sha1 checksums (extra work)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1041
Posted by velo <gi...@git.apache.org>.
Github user velo closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/207
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1041
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/207#issuecomment-178189004
@pluradj just thought i'd grab your attention on this issue....
@velo i can't just enable it as apache owns the repo - apache infra would have to enable it i guess. we'll have to discuss on the mailing list anyway. i'll bring it up
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1041
Posted by steveloughran <gi...@git.apache.org>.
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/207#discussion_r51560858
--- Diff: appveyor.yml ---
@@ -0,0 +1,23 @@
+version: '{build}'
+
+environment:
+ matrix:
+ - JAVA_HOME: C:\Program Files\Java\jdk1.8.0
+
+os: Windows Server 2012
+
+install:
+ - ps: |
+ Add-Type -AssemblyName System.IO.Compression.FileSystem
+ if (!(Test-Path -Path "C:\maven" )) {
+ (new-object System.Net.WebClient).DownloadFile('http://www.us.apache.org/dist/maven/maven-3/3.2.5/binaries/apache-maven-3.2.5-bin.zip', 'C:\maven-bin.zip')
--- End diff --
https considered more secure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1041
Posted by velo <gi...@git.apache.org>.
Github user velo commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/207#issuecomment-178197946
@spmallette thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1041
Posted by velo <gi...@git.apache.org>.
Github user velo commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/207#issuecomment-178168396
BTW, @spmallette can you enable appveyor on this project as well?
So we would know how does the build look like on windows
https://ci.appveyor.com/project/velo/incubator-tinkerpop
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Tinkerpop 1041
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/207#issuecomment-177941325
Thanks for digging into this. Can you please talk about what the "windows" maven profile is for?
I'd also like to know more about the appveyor config. I guess you have that building against your fork with your appveyor account?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Tinkerpop 1041
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/207#issuecomment-177941545
Sorry - i also meant to mention - can you please also rename this PR to "TINKERPOP-1041" so it hooks into JIRA?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Tinkerpop 1041
Posted by velo <gi...@git.apache.org>.
Github user velo commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/207#issuecomment-178164276
the windows profile is to work around
https://issues.apache.org/jira/browse/HADOOP-10969
and
https://issues.apache.org/jira/browse/SPARK-6961
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1041
Posted by velo <gi...@git.apache.org>.
Github user velo commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/207#discussion_r51620901
--- Diff: appveyor.yml ---
@@ -0,0 +1,23 @@
+version: '{build}'
+
+environment:
+ matrix:
+ - JAVA_HOME: C:\Program Files\Java\jdk1.8.0
+
+os: Windows Server 2012
+
+install:
+ - ps: |
+ Add-Type -AssemblyName System.IO.Compression.FileSystem
+ if (!(Test-Path -Path "C:\maven" )) {
+ (new-object System.Net.WebClient).DownloadFile('http://www.us.apache.org/dist/maven/maven-3/3.2.5/binaries/apache-maven-3.2.5-bin.zip', 'C:\maven-bin.zip')
--- End diff --
https://www.us.apache.org/dist/maven/maven-3/3.3.9/binaries/apache-maven-3.3.9-bin.zip
is considered an insecure connection
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Tinkerpop 1041
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/207#discussion_r51410000
--- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/TestHelper.java ---
@@ -50,6 +52,7 @@
public final class TestHelper {
private static final String SEP = File.separator;
+ private static final char URL_SEP = '/';
--- End diff --
ah! the class lookup is by URL so you need standard URL pathing to handle that (and not the windows file separator). cool
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1041
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/207#discussion_r51709066
--- Diff: appveyor.yml ---
@@ -0,0 +1,23 @@
+version: '{build}'
+
+environment:
+ matrix:
+ - JAVA_HOME: C:\Program Files\Java\jdk1.8.0
+
+os: Windows Server 2012
+
+install:
+ - ps: |
+ Add-Type -AssemblyName System.IO.Compression.FileSystem
+ if (!(Test-Path -Path "C:\maven" )) {
+ (new-object System.Net.WebClient).DownloadFile('http://www.us.apache.org/dist/maven/maven-3/3.2.5/binaries/apache-maven-3.2.5-bin.zip', 'C:\maven-bin.zip')
--- End diff --
+1 for https however that would work
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---