You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "JinHelin404 (via GitHub)" <gi...@apache.org> on 2023/04/26 08:42:15 UTC
[GitHub] [spark] JinHelin404 opened a new pull request, #40957: [SPARK-43257][SQL]Delete the error class _LEGACY_ERROR_TEMP_2010
JinHelin404 opened a new pull request, #40957:
URL: https://github.com/apache/spark/pull/40957
### What changes were proposed in this pull request?
Delete the error class _LEGACY_ERROR_TEMP_2010 as it cannot be accessed.
### Why are the changes needed?
Fix jira issue [SPARK-43257](https://issues.apache.org/jira/browse/SPARK-43257). `ResolveNaturalAndUsingJoin` only handles `UsingJoin` and `NaturalJoin`, and all join types supported by `UsingJoin` and `NaturalJoin` are supported by natural join, so `commonNaturalJoinProcessing` will never go to the default branch and throw `unsupportedNaturalJoinTypeError`. I think this error class could be removed.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Remove useless code, no testing needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #40957: [SPARK-43257][SQL] Replace the error class _LEGACY_ERROR_TEMP_2022 by an internal error
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #40957:
URL: https://github.com/apache/spark/pull/40957#issuecomment-1525534890
@JinHelin404 Do you have an account the JIRA: https://issues.apache.org/jira/browse/SPARK-43257. If not, could you leave a request, or leave a comment if you have one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #40957: [SPARK-43257][SQL] Replace the error class _LEGACY_ERROR_TEMP_2022 by an internal error
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #40957:
URL: https://github.com/apache/spark/pull/40957#issuecomment-1525569182
+1, LGTM. Merged to master.
Thank you, @JinHelin404 and congratulations with your first contribution to Apache Spark!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] JinHelin404 commented on pull request #40957: [SPARK-43257][SQL]Delete the error class _LEGACY_ERROR_TEMP_2022
Posted by "JinHelin404 (via GitHub)" <gi...@apache.org>.
JinHelin404 commented on PR #40957:
URL: https://github.com/apache/spark/pull/40957#issuecomment-1523041923
@MaxGekk hi, could you help to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #40957: [SPARK-43257][SQL] Replace the error class _LEGACY_ERROR_TEMP_2022 by an internal error
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #40957: [SPARK-43257][SQL] Replace the error class _LEGACY_ERROR_TEMP_2022 by an internal error
URL: https://github.com/apache/spark/pull/40957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] JinHelin404 commented on pull request #40957: [SPARK-43257][SQL] Replace the error class _LEGACY_ERROR_TEMP_2022 by an internal error
Posted by "JinHelin404 (via GitHub)" <gi...@apache.org>.
JinHelin404 commented on PR #40957:
URL: https://github.com/apache/spark/pull/40957#issuecomment-1525713232
@MaxGekk Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] JinHelin404 commented on pull request #40957: [SPARK-43257][SQL] replace the error class _LEGACY_ERROR_TEMP_2022 with internal error
Posted by "JinHelin404 (via GitHub)" <gi...@apache.org>.
JinHelin404 commented on PR #40957:
URL: https://github.com/apache/spark/pull/40957#issuecomment-1525154687
@MaxGekk Because scala 2.13 mandates handling default case, I replaced this error class with internal error. But `commonNaturalJoinProcessing` is a private method and I can't trigger the default case, so I didn't add any ut. Could you please help me to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] JinHelin404 commented on pull request #40957: [SPARK-43257][SQL] Replace the error class _LEGACY_ERROR_TEMP_2022 by an internal error
Posted by "JinHelin404 (via GitHub)" <gi...@apache.org>.
JinHelin404 commented on PR #40957:
URL: https://github.com/apache/spark/pull/40957#issuecomment-1525552908
@MaxGekk Yes, and I've just left a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org