[GitHub] [superset] craig-rueda commented on pull request #24488: chore(dao): Add explicit ON DELETE CASCADE when deleting datasets

["craig-rueda (via GitHub)" <gi...@apache.org>]

craig-rueda commented on PR #24488:
URL: https://github.com/apache/superset/pull/24488#issuecomment-1604572286

   Totally agree with this philosophy, except for situations where you really want to leave FK data hanging. IMO, the DB should keep things clean wherever possible and should enforce referential integrity (kinda the point of FK's in the first place :D ). Delegating to the DB to deal with cleanup keeps app-tier logic cleaner and less buggy as it's less concerned with cascades and what not.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org