[GitHub] [incubator-superset] pkdotson commented on a change in pull request #11678: feat(welcome): add SQL snippets to saved queries card

[GitBox <gi...@apache.org>]

pkdotson commented on a change in pull request #11678:
URL: https://github.com/apache/incubator-superset/pull/11678#discussion_r529820845



##########
File path: superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx
##########
@@ -57,19 +64,45 @@ interface SavedQueriesProps {
   mine: Array<Query>;
 }
 
+export const CardStyles = styled.div`
+  cursor: pointer;
+  a {
+    text-decoration: none;
+  }
+  .ant-card-cover {
+    border-bottom: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+  }
+`;
+
 const QueryData = styled.div`
-  display: flex;
-  flex-direction: row;
-  justify-content: flex-start;
-  border-bottom: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
-  .title {
-    font-weight: ${({ theme }) => theme.typography.weights.normal};
-    color: ${({ theme }) => theme.colors.grayscale.light1};
+  svg {
+    margin-left: ${({ theme }) => theme.gridUnit * 10}px;
   }
-  .holder {
-    margin: ${({ theme }) => theme.gridUnit * 2}px;
+  .query-title {
+    padding: ${({ theme }) => theme.gridUnit * 2 + 2}px;
+    font-size: ${({ theme }) => theme.typography.sizes.l}px;
   }
 `;
+
+const ShowEmptyState = styled.div`

Review comment:
       The way the logic is set for the others  it checks  if there is thumbnail url where here we are checking if if there is a query. The way that I'm using the card is a little different from the chart and dashboard since we are depeneding on whether there is a block code of sql for the reactsyntaxhighlighe to show. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org