You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2025/12/26 05:45:29 UTC
[PR] GH-48664: [R] Implement support for keepNA = FALSE in base::nchar() [arrow]
HyukjinKwon opened a new pull request, #48665:
URL: https://github.com/apache/arrow/pull/48665
### Rationale for this change
Should address TODO added in commit 81e1fbc1de (ARROW-17665)
https://github.com/apache/arrow/blob/744f0ec2cf9f8716fcea408d67ede9c14a7e6954/r/R/dplyr-funcs-string.R#L488
Implemented the argument intended to work.
### What changes are included in this PR?
This PR Implement support for `keepNA = FALSE` in `base::nchar()`
### Are these changes tested?
Unittest was added.
### Are there any user-facing changes?
Yes. Now `nchar(..., keepNA = FALSE)` should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48664: [R] Implement support for keepNA = FALSE in base::nchar() [arrow]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #48665:
URL: https://github.com/apache/arrow/pull/48665#issuecomment-3736219257
No problem! Thank you so much for your time 🫡 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48664: [R] Implement support for keepNA = FALSE in base::nchar() [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #48665:
URL: https://github.com/apache/arrow/pull/48665#issuecomment-3732896691
Revision: 7cc044bef6371224b065c923ff4677df80ebc19f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-b70471dfc8](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b70471dfc8)
|Task|Status|
|----|------|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/20879774813/job/59994353214)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48664: [R] Implement support for keepNA = FALSE in base::nchar() [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #48665:
URL: https://github.com/apache/arrow/pull/48665#issuecomment-3692181469
:warning: GitHub issue #48664 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48664: [R] Implement support for keepNA = FALSE in base::nchar() [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #48665:
URL: https://github.com/apache/arrow/pull/48665#issuecomment-3732892649
@github-actions crossbow submit test-r-arrow-backwards-compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48664: [R] Implement support for keepNA = FALSE in base::nchar() [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane merged PR #48665:
URL: https://github.com/apache/arrow/pull/48665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48664: [R] Implement support for keepNA = FALSE in base::nchar() [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #48665:
URL: https://github.com/apache/arrow/pull/48665#issuecomment-3765634002
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 435d8bae14f02ded1a1219b4ecbaa585105fbbc8.
There weren't enough matching historic benchmark results to make a call on whether there were regressions.
The [full Conbench report](https://github.com/apache/arrow/runs/60724520065) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48664: [R] Implement support for keepNA = FALSE in base::nchar() [arrow]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #48665:
URL: https://github.com/apache/arrow/pull/48665#issuecomment-3725979993
@jonkeane do you mind if I ask to take a look when you find some time please 🙇
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org