You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Robert Kanter <rk...@cloudera.com> on 2013/04/10 23:53:18 UTC
Review Request: OOZIE-1311: Refactor action Main classes into sharelibs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10410/
-----------------------------------------------------------
Review request for oozie.
Description
-------
See https://issues.apache.org/jira/browse/OOZIE-1311 for details.
Most of the changes are from moving files around.
This addresses bug OOZIE-1311.
https://issues.apache.org/jira/browse/OOZIE-1311
Diffs
-----
trunk/core/pom.xml 1466656
trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java 1466656
trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java 1466656
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1466656
trunk/core/src/main/java/org/apache/oozie/action/hadoop/OoziePigStats.java 1466656
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java 1466656
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 1466656
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMainWithOldAPI.java 1466656
trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java 1466656
trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java 1466656
trunk/core/src/main/java/org/apache/oozie/action/hadoop/StreamingMain.java 1466656
trunk/core/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java 1466656
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1466656
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java 1466656
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 1466656
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1466656
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1466656
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutorUberJar.java 1466656
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 1466656
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1466656
trunk/core/src/test/java/org/apache/oozie/action/hadoop/UDFTester.java 1466656
trunk/pom.xml 1466656
trunk/sharelib/distcp/pom.xml 1466656
trunk/sharelib/distcp/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java PRE-CREATION
trunk/sharelib/hive/pom.xml 1466656
trunk/sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java PRE-CREATION
trunk/sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java PRE-CREATION
trunk/sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java PRE-CREATION
trunk/sharelib/pig/pom.xml 1466656
trunk/sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/OoziePigStats.java PRE-CREATION
trunk/sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java PRE-CREATION
trunk/sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMainWithOldAPI.java PRE-CREATION
trunk/sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java PRE-CREATION
trunk/sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java PRE-CREATION
trunk/sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java PRE-CREATION
trunk/sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/UDFTester.java PRE-CREATION
trunk/sharelib/sqoop/pom.xml 1466656
trunk/sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java PRE-CREATION
trunk/sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java PRE-CREATION
trunk/sharelib/streaming/pom.xml 1466656
trunk/sharelib/streaming/src/main/java/org/apache/oozie/action/hadoop/StreamingMain.java PRE-CREATION
trunk/sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutorStreaming.java PRE-CREATION
trunk/sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java PRE-CREATION
trunk/src/main/assemblies/partial-sharelib.xml 1466656
trunk/tests/pig/pom.xml 1466656
trunk/tests/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1466656
trunk/tests/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1466656
trunk/tests/pom.xml 1466656
Diff: https://reviews.apache.org/r/10410/diff/
Testing
-------
I ran all of the unit tests and also checked that the example workflows for each of the affected action types still work.
Thanks,
Robert Kanter
Re: Review Request: OOZIE-1311: Refactor action Main classes into sharelibs
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10410/#review18988
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Abdelnur
On April 10, 2013, 9:53 p.m., Robert Kanter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10410/
> -----------------------------------------------------------
>
> (Updated April 10, 2013, 9:53 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> See https://issues.apache.org/jira/browse/OOZIE-1311 for details.
>
> Most of the changes are from moving files around.
>
>
> This addresses bug OOZIE-1311.
> https://issues.apache.org/jira/browse/OOZIE-1311
>
>
> Diffs
> -----
>
> trunk/core/pom.xml 1466656
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java 1466656
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java 1466656
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1466656
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/OoziePigStats.java 1466656
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java 1466656
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 1466656
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMainWithOldAPI.java 1466656
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java 1466656
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java 1466656
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/StreamingMain.java 1466656
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java 1466656
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1466656
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java 1466656
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 1466656
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1466656
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1466656
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutorUberJar.java 1466656
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 1466656
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1466656
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/UDFTester.java 1466656
> trunk/pom.xml 1466656
> trunk/sharelib/distcp/pom.xml 1466656
> trunk/sharelib/distcp/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java PRE-CREATION
> trunk/sharelib/hive/pom.xml 1466656
> trunk/sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java PRE-CREATION
> trunk/sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java PRE-CREATION
> trunk/sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java PRE-CREATION
> trunk/sharelib/pig/pom.xml 1466656
> trunk/sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/OoziePigStats.java PRE-CREATION
> trunk/sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java PRE-CREATION
> trunk/sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMainWithOldAPI.java PRE-CREATION
> trunk/sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java PRE-CREATION
> trunk/sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java PRE-CREATION
> trunk/sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java PRE-CREATION
> trunk/sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/UDFTester.java PRE-CREATION
> trunk/sharelib/sqoop/pom.xml 1466656
> trunk/sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java PRE-CREATION
> trunk/sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java PRE-CREATION
> trunk/sharelib/streaming/pom.xml 1466656
> trunk/sharelib/streaming/src/main/java/org/apache/oozie/action/hadoop/StreamingMain.java PRE-CREATION
> trunk/sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutorStreaming.java PRE-CREATION
> trunk/sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java PRE-CREATION
> trunk/src/main/assemblies/partial-sharelib.xml 1466656
> trunk/tests/pig/pom.xml 1466656
> trunk/tests/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1466656
> trunk/tests/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1466656
> trunk/tests/pom.xml 1466656
>
> Diff: https://reviews.apache.org/r/10410/diff/
>
>
> Testing
> -------
>
> I ran all of the unit tests and also checked that the example workflows for each of the affected action types still work.
>
>
> Thanks,
>
> Robert Kanter
>
>