You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2026/03/15 09:29:12 UTC
[PR] [SPARK-55995][SQL] Support TIMESTAMP WITH LOCAL TIME ZONE in SQL syntax [spark]
pan3793 opened a new pull request, #54813:
URL: https://github.com/apache/spark/pull/54813
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR proposes to add SQL syntax `TIMESTAMP WITH LOCAL TIME ZONE` for `TimestampType`, as a counterpart of `TIMESTAMP WITHOUT TIME ZONE` for `TimestampNTZType`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Spark 3.4 introduced a `spark.sql.timestampType` config to allow switching the alias of `TIMESTAMP` to be either `TimestampType`(default) or `TimestampNTZType`. When setting `spark.sql.timestampType=TIMESTAMP_NTZ`, it's unable to define a `TimestampType` type column due to SQL syntax limitations.
```
-- fine
CREATE TABLE ts_1(ltz TIMESTAMP, ntz TIMESTAMP_NTZ);
-- fine
CREATE TABLE ts_2(ltz TIMESTAMP, ntz TIMESTAMP WITHOUT TIME ZONE);
-- set TIMESTAMP as alias of TimestampNTZ
SET spark.sql.timestampType=TimestampNTZ;
-- fine, both are TimestampNTZ
CREATE TABLE ts_3(ltz TIMESTAMP, ntz TIMESTAMP WITHOUT TIME ZONE);
-- this does not work
CREATE TABLE ts_4(ltz TIMESTAMP WITH LOCAL TIME ZONE, ntz TIMESTAMP WITHOUT TIME ZONE);
```
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
This introduces new SQL syntax without breaking backport compatibility.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
New UTs are added.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55995][SQL] Support TIMESTAMP WITH LOCAL TIME ZONE in SQL syntax [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #54813:
URL: https://github.com/apache/spark/pull/54813#issuecomment-4073154485
@dongjoon-hyun, thank you for merging and taking care of the CI failure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55995][SQL] Support TIMESTAMP WITH LOCAL TIME ZONE in SQL syntax [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #54813:
URL: https://github.com/apache/spark/pull/54813#issuecomment-4072611852
late LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55995][SQL] Support TIMESTAMP WITH LOCAL TIME ZONE in SQL syntax [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #54813: [SPARK-55995][SQL] Support TIMESTAMP WITH LOCAL TIME ZONE in SQL syntax
URL: https://github.com/apache/spark/pull/54813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55995][SQL] Support TIMESTAMP WITH LOCAL TIME ZONE in SQL syntax [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #54813:
URL: https://github.com/apache/spark/pull/54813#issuecomment-4073083638
For the record, the following PR aims to recover `master` branch CI .
- https://github.com/apache/spark/pull/54853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55995][SQL] Support TIMESTAMP WITH LOCAL TIME ZONE in SQL syntax [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #54813:
URL: https://github.com/apache/spark/pull/54813#issuecomment-4072390267
@dongjoon-hyun Yea, as gengliang said, `TIMESTAMP WITH TIME ZONE` and `TIMESTAMP WITH LOCAL TIME ZONE` are two different concepts, https://docs.oracle.com/en/database/oracle/oracle-database/21/nlspg/datetime-data-types-and-time-zone-support.html
AFAIK, PostgreSQL does not support `TIMESTAMP WITH LOCAL TIME ZONE`, and MySQL's `timestamp` is equivalent to `TIMESTAMP WITH LOCAL TIME ZONE`, and MySQL does not support `TIMESTAMP WITH TIME ZONE`, so this won't introduce confusion.
Additionally, Snowflake and Flink support both `TIMESTAMP WITH TIME ZONE` and `TIMESTAMP WITH LOCAL TIME ZONE`, also `TIMESTAMP_TZ` and `TIMESTAMP_LTZ`, so it's actually a common practice.
https://docs.snowflake.com/en/sql-reference/data-types-datetime#timestamp-ltz-timestamp-ntz-timestamp-tz
https://nightlies.apache.org/flink/flink-docs-release-2.2/docs/dev/table/types/#timestamp_ltz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55995][SQL] Support TIMESTAMP WITH LOCAL TIME ZONE in SQL syntax [spark]
Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang commented on PR #54813:
URL: https://github.com/apache/spark/pull/54813#issuecomment-4072224983
> AFAIK, this seems to follow Oracle way, but Apache Spark prefers PostgreSQL way traditionally. In PostgreSQL, it's TIMESTAMP WITH TIME ZONE. For MySQL TIMESTAMP is simply this.
Spark's default timestamp type behaves similarly to `TIMESTAMP WITH LOCAL TIME ZONE`. This differs from `TIMESTAMP WITH TIME ZONE`, which explicitly stores both the timestamp and the time zone in a single value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55995][SQL] Support TIMESTAMP WITH LOCAL TIME ZONE in SQL syntax [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #54813:
URL: https://github.com/apache/spark/pull/54813#issuecomment-4072694132
Just FYI, the `master` branch commit builder has been broken Today due to `dev/spark-test-image/lint/Dockerfile` build failure. It's irrelevant to this PR because of R packages. I'm looking at the failure independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55995][SQL] Support TIMESTAMP WITH LOCAL TIME ZONE in SQL syntax [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #54813:
URL: https://github.com/apache/spark/pull/54813#issuecomment-4072011182
@gengliangwang could you please take a look? as you are the author of the timestamp ntz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55995][SQL] Support TIMESTAMP WITH LOCAL TIME ZONE in SQL syntax [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #54813:
URL: https://github.com/apache/spark/pull/54813#issuecomment-4072556224
Thank you for the explanation, @gengliangwang and @pan3793 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55995][SQL] Support TIMESTAMP WITH LOCAL TIME ZONE in SQL syntax [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #54813:
URL: https://github.com/apache/spark/pull/54813#issuecomment-4072562004
Merged to master for Apache Spark 4.2.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org